From: Dmitry Osipenko <digetx@gmail.com> To: "Laxman Dewangan" <ldewangan@nvidia.com>, "Vinod Koul" <vkoul@kernel.org>, "Dan Williams" <dan.j.williams@intel.com>, "Thierry Reding" <thierry.reding@gmail.com>, "Jonathan Hunter" <jonathanh@nvidia.com>, "Michał Mirosław" <mirq-linux@rere.qmqm.pl> Cc: dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v8 07/19] dmaengine: tegra-apb: Use devm_request_irq Date: Sun, 9 Feb 2020 19:33:44 +0300 [thread overview] Message-ID: <20200209163356.6439-8-digetx@gmail.com> (raw) In-Reply-To: <20200209163356.6439-1-digetx@gmail.com> Use resource-managed variant of request_irq for brevity. Acked-by: Jon Hunter <jonathanh@nvidia.com> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/dma/tegra20-apb-dma.c | 35 +++++++++++------------------------ 1 file changed, 11 insertions(+), 24 deletions(-) diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c index f44291207928..dff21e80ffa4 100644 --- a/drivers/dma/tegra20-apb-dma.c +++ b/drivers/dma/tegra20-apb-dma.c @@ -182,7 +182,6 @@ struct tegra_dma_channel { char name[12]; bool config_init; int id; - int irq; void __iomem *chan_addr; spinlock_t lock; bool busy; @@ -1380,7 +1379,6 @@ static const struct tegra_dma_chip_data tegra148_dma_chip_data = { static int tegra_dma_probe(struct platform_device *pdev) { - struct resource *res; struct tegra_dma *tdma; int ret; int i; @@ -1446,25 +1444,27 @@ static int tegra_dma_probe(struct platform_device *pdev) INIT_LIST_HEAD(&tdma->dma_dev.channels); for (i = 0; i < cdata->nr_channels; i++) { struct tegra_dma_channel *tdc = &tdma->channels[i]; + int irq; tdc->chan_addr = tdma->base_addr + TEGRA_APBDMA_CHANNEL_BASE_ADD_OFFSET + (i * cdata->channel_reg_size); - res = platform_get_resource(pdev, IORESOURCE_IRQ, i); - if (!res) { - ret = -EINVAL; + irq = platform_get_irq(pdev, i); + if (irq < 0) { + ret = irq; dev_err(&pdev->dev, "No irq resource for chan %d\n", i); - goto err_irq; + goto err_pm_disable; } - tdc->irq = res->start; + snprintf(tdc->name, sizeof(tdc->name), "apbdma.%d", i); - ret = request_irq(tdc->irq, tegra_dma_isr, 0, tdc->name, tdc); + ret = devm_request_irq(&pdev->dev, irq, tegra_dma_isr, 0, + tdc->name, tdc); if (ret) { dev_err(&pdev->dev, "request_irq failed with err %d channel %d\n", ret, i); - goto err_irq; + goto err_pm_disable; } tdc->dma_chan.device = &tdma->dma_dev; @@ -1517,7 +1517,7 @@ static int tegra_dma_probe(struct platform_device *pdev) if (ret < 0) { dev_err(&pdev->dev, "Tegra20 APB DMA driver registration failed %d\n", ret); - goto err_irq; + goto err_pm_disable; } ret = of_dma_controller_register(pdev->dev.of_node, @@ -1534,13 +1534,7 @@ static int tegra_dma_probe(struct platform_device *pdev) err_unregister_dma_dev: dma_async_device_unregister(&tdma->dma_dev); -err_irq: - while (--i >= 0) { - struct tegra_dma_channel *tdc = &tdma->channels[i]; - - free_irq(tdc->irq, tdc); - } - +err_pm_disable: pm_runtime_disable(&pdev->dev); if (!pm_runtime_status_suspended(&pdev->dev)) tegra_dma_runtime_suspend(&pdev->dev); @@ -1550,16 +1544,9 @@ static int tegra_dma_probe(struct platform_device *pdev) static int tegra_dma_remove(struct platform_device *pdev) { struct tegra_dma *tdma = platform_get_drvdata(pdev); - int i; - struct tegra_dma_channel *tdc; dma_async_device_unregister(&tdma->dma_dev); - for (i = 0; i < tdma->chip_data->nr_channels; ++i) { - tdc = &tdma->channels[i]; - free_irq(tdc->irq, tdc); - } - pm_runtime_disable(&pdev->dev); if (!pm_runtime_status_suspended(&pdev->dev)) tegra_dma_runtime_suspend(&pdev->dev); -- 2.24.0
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: "Laxman Dewangan" <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>, "Vinod Koul" <vkoul-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "Dan Williams" <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, "Thierry Reding" <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "Jonathan Hunter" <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>, "Michał Mirosław" <mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org> Cc: dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: [PATCH v8 07/19] dmaengine: tegra-apb: Use devm_request_irq Date: Sun, 9 Feb 2020 19:33:44 +0300 [thread overview] Message-ID: <20200209163356.6439-8-digetx@gmail.com> (raw) In-Reply-To: <20200209163356.6439-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Use resource-managed variant of request_irq for brevity. Acked-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Signed-off-by: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> --- drivers/dma/tegra20-apb-dma.c | 35 +++++++++++------------------------ 1 file changed, 11 insertions(+), 24 deletions(-) diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c index f44291207928..dff21e80ffa4 100644 --- a/drivers/dma/tegra20-apb-dma.c +++ b/drivers/dma/tegra20-apb-dma.c @@ -182,7 +182,6 @@ struct tegra_dma_channel { char name[12]; bool config_init; int id; - int irq; void __iomem *chan_addr; spinlock_t lock; bool busy; @@ -1380,7 +1379,6 @@ static const struct tegra_dma_chip_data tegra148_dma_chip_data = { static int tegra_dma_probe(struct platform_device *pdev) { - struct resource *res; struct tegra_dma *tdma; int ret; int i; @@ -1446,25 +1444,27 @@ static int tegra_dma_probe(struct platform_device *pdev) INIT_LIST_HEAD(&tdma->dma_dev.channels); for (i = 0; i < cdata->nr_channels; i++) { struct tegra_dma_channel *tdc = &tdma->channels[i]; + int irq; tdc->chan_addr = tdma->base_addr + TEGRA_APBDMA_CHANNEL_BASE_ADD_OFFSET + (i * cdata->channel_reg_size); - res = platform_get_resource(pdev, IORESOURCE_IRQ, i); - if (!res) { - ret = -EINVAL; + irq = platform_get_irq(pdev, i); + if (irq < 0) { + ret = irq; dev_err(&pdev->dev, "No irq resource for chan %d\n", i); - goto err_irq; + goto err_pm_disable; } - tdc->irq = res->start; + snprintf(tdc->name, sizeof(tdc->name), "apbdma.%d", i); - ret = request_irq(tdc->irq, tegra_dma_isr, 0, tdc->name, tdc); + ret = devm_request_irq(&pdev->dev, irq, tegra_dma_isr, 0, + tdc->name, tdc); if (ret) { dev_err(&pdev->dev, "request_irq failed with err %d channel %d\n", ret, i); - goto err_irq; + goto err_pm_disable; } tdc->dma_chan.device = &tdma->dma_dev; @@ -1517,7 +1517,7 @@ static int tegra_dma_probe(struct platform_device *pdev) if (ret < 0) { dev_err(&pdev->dev, "Tegra20 APB DMA driver registration failed %d\n", ret); - goto err_irq; + goto err_pm_disable; } ret = of_dma_controller_register(pdev->dev.of_node, @@ -1534,13 +1534,7 @@ static int tegra_dma_probe(struct platform_device *pdev) err_unregister_dma_dev: dma_async_device_unregister(&tdma->dma_dev); -err_irq: - while (--i >= 0) { - struct tegra_dma_channel *tdc = &tdma->channels[i]; - - free_irq(tdc->irq, tdc); - } - +err_pm_disable: pm_runtime_disable(&pdev->dev); if (!pm_runtime_status_suspended(&pdev->dev)) tegra_dma_runtime_suspend(&pdev->dev); @@ -1550,16 +1544,9 @@ static int tegra_dma_probe(struct platform_device *pdev) static int tegra_dma_remove(struct platform_device *pdev) { struct tegra_dma *tdma = platform_get_drvdata(pdev); - int i; - struct tegra_dma_channel *tdc; dma_async_device_unregister(&tdma->dma_dev); - for (i = 0; i < tdma->chip_data->nr_channels; ++i) { - tdc = &tdma->channels[i]; - free_irq(tdc->irq, tdc); - } - pm_runtime_disable(&pdev->dev); if (!pm_runtime_status_suspended(&pdev->dev)) tegra_dma_runtime_suspend(&pdev->dev); -- 2.24.0
next prev parent reply other threads:[~2020-02-09 16:42 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-09 16:33 [PATCH v8 00/19] NVIDIA Tegra APB DMA driver fixes and improvements Dmitry Osipenko 2020-02-09 16:33 ` [PATCH v8 01/19] dmaengine: tegra-apb: Fix use-after-free Dmitry Osipenko 2020-02-09 16:33 ` [PATCH v8 02/19] dmaengine: tegra-apb: Prevent race conditions of tasklet vs free list Dmitry Osipenko 2020-02-09 16:33 ` [PATCH v8 03/19] dmaengine: tegra-apb: Implement synchronization hook Dmitry Osipenko 2020-02-09 16:33 ` [PATCH v8 04/19] dmaengine: tegra-apb: Prevent race conditions on channel's freeing Dmitry Osipenko 2020-02-09 16:33 ` [PATCH v8 05/19] dmaengine: tegra-apb: Clean up tasklet releasing Dmitry Osipenko 2020-02-09 16:33 ` [PATCH v8 06/19] dmaengine: tegra-apb: Use devm_platform_ioremap_resource Dmitry Osipenko 2020-02-09 16:33 ` Dmitry Osipenko [this message] 2020-02-09 16:33 ` [PATCH v8 07/19] dmaengine: tegra-apb: Use devm_request_irq Dmitry Osipenko 2020-02-09 16:33 ` [PATCH v8 08/19] dmaengine: tegra-apb: Fix coding style problems Dmitry Osipenko 2020-02-09 16:33 ` [PATCH v8 09/19] dmaengine: tegra-apb: Remove unneeded initialization of tdc->config_init Dmitry Osipenko 2020-02-09 16:33 ` [PATCH v8 10/19] dmaengine: tegra-apb: Remove assumptions about unavailable runtime PM Dmitry Osipenko 2020-02-09 16:33 ` [PATCH v8 11/19] dmaengine: tegra-apb: Remove duplicated pending_sg_req checks Dmitry Osipenko 2020-02-09 16:33 ` Dmitry Osipenko 2020-02-14 14:13 ` Jon Hunter 2020-02-14 14:13 ` Jon Hunter 2020-02-09 16:33 ` [PATCH v8 12/19] dmaengine: tegra-apb: Keep clock enabled only during of DMA transfer Dmitry Osipenko 2020-02-14 14:15 ` Jon Hunter 2020-02-14 14:15 ` Jon Hunter 2020-02-09 16:33 ` [PATCH v8 13/19] dmaengine: tegra-apb: Clean up suspend-resume Dmitry Osipenko 2020-02-09 16:33 ` Dmitry Osipenko 2020-02-09 16:33 ` [PATCH v8 14/19] dmaengine: tegra-apb: Add missing of_dma_controller_free Dmitry Osipenko 2020-02-09 16:33 ` Dmitry Osipenko 2020-02-09 16:33 ` [PATCH v8 15/19] dmaengine: tegra-apb: Allow to compile as a loadable kernel module Dmitry Osipenko 2020-02-09 16:33 ` Dmitry Osipenko 2020-02-09 16:33 ` [PATCH v8 16/19] dmaengine: tegra-apb: Remove MODULE_ALIAS Dmitry Osipenko 2020-02-09 16:33 ` Dmitry Osipenko 2020-02-09 16:33 ` [PATCH v8 17/19] dmaengine: tegra-apb: Support COMPILE_TEST Dmitry Osipenko 2020-02-09 16:33 ` Dmitry Osipenko 2020-02-09 16:33 ` [PATCH v8 18/19] dmaengine: tegra-apb: Remove unused function argument Dmitry Osipenko 2020-02-14 14:16 ` Jon Hunter 2020-02-14 14:16 ` Jon Hunter 2020-02-14 16:54 ` Dmitry Osipenko 2020-02-14 16:54 ` Dmitry Osipenko 2020-02-17 11:15 ` Jon Hunter 2020-02-17 11:15 ` Jon Hunter 2020-02-17 14:56 ` Dmitry Osipenko 2020-02-17 14:56 ` Dmitry Osipenko 2020-02-09 16:33 ` [PATCH v8 19/19] dmaengine: tegra-apb: Improve error message about DMA underflow Dmitry Osipenko 2020-02-14 14:16 ` Jon Hunter 2020-02-14 14:16 ` Jon Hunter 2020-02-25 6:32 ` [PATCH v8 00/19] NVIDIA Tegra APB DMA driver fixes and improvements Vinod Koul 2020-02-25 6:32 ` Vinod Koul 2020-02-25 7:05 ` Dmitry Osipenko 2020-02-25 7:05 ` Dmitry Osipenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200209163356.6439-8-digetx@gmail.com \ --to=digetx@gmail.com \ --cc=dan.j.williams@intel.com \ --cc=dmaengine@vger.kernel.org \ --cc=jonathanh@nvidia.com \ --cc=ldewangan@nvidia.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=mirq-linux@rere.qmqm.pl \ --cc=thierry.reding@gmail.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.