All of lore.kernel.org
 help / color / mirror / Atom feed
From: matthias.bgg@kernel.org
To: robh+dt@kernel.org, mark.rutland@arm.com, ck.hu@mediatek.com,
	p.zabel@pengutronix.de, airlied@linux.ie,
	mturquette@baylibre.com, sboyd@kernel.org,
	ulrich.hecht+renesas@gmail.com,
	laurent.pinchart@ideasonboard.com, enric.balletbo@collabora.com
Cc: devicetree@vger.kernel.org, drinkcat@chromium.org,
	frank-w@public-files.de, sean.wang@mediatek.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	wens@csie.org, linux-mediatek@lists.infradead.org,
	rdunlap@infradead.org, matthias.bgg@kernel.org,
	hsinyi@chromium.org, linux-clk@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org, Matthias Brugger <mbrugger@suse.com>,
	Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
	Houlong Wei <houlong.wei@mediatek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Minghsiu Tsai <minghsiu.tsai@mediatek.com>
Subject: [PATCH v7 06/13] media: mtk-mdp: Check return value of of_clk_get
Date: Thu, 13 Feb 2020 21:19:46 +0100	[thread overview]
Message-ID: <20200213201953.15268-7-matthias.bgg@kernel.org> (raw)
In-Reply-To: <20200213201953.15268-1-matthias.bgg@kernel.org>

From: Matthias Brugger <mbrugger@suse.com>

Check the return value of of_clk_get and print an error
message if not EPROBE_DEFER.

Signed-off-by: Matthias Brugger <mbrugger@suse.com>

---

Changes in v7:
- fix check of return value of of_clk_get
- fix identation

Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None

 drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
index 0c4788af78dd..58abfbdfb82d 100644
--- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
+++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
@@ -110,6 +110,12 @@ int mtk_mdp_comp_init(struct device *dev, struct device_node *node,
 
 	for (i = 0; i < ARRAY_SIZE(comp->clk); i++) {
 		comp->clk[i] = of_clk_get(node, i);
+		if (IS_ERR(comp->clk[i])) {
+			if (PTR_ERR(comp->clk[i]) != -EPROBE_DEFER)
+				dev_err(dev, "Failed to get clock\n");
+
+			return PTR_ERR(comp->clk[i]);
+		}
 
 		/* Only RDMA needs two clocks */
 		if (comp->type != MTK_MDP_RDMA)
-- 
2.24.1


WARNING: multiple messages have this Message-ID (diff)
From: matthias.bgg@kernel.org
To: robh+dt@kernel.org, mark.rutland@arm.com, ck.hu@mediatek.com,
	p.zabel@pengutronix.de, airlied@linux.ie,
	mturquette@baylibre.com, sboyd@kernel.org,
	ulrich.hecht+renesas@gmail.com,
	laurent.pinchart@ideasonboard.com, enric.balletbo@collabora.com
Cc: devicetree@vger.kernel.org, drinkcat@chromium.org,
	Minghsiu Tsai <minghsiu.tsai@mediatek.com>,
	frank-w@public-files.de, sean.wang@mediatek.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Houlong Wei <houlong.wei@mediatek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	wens@csie.org, Matthias Brugger <mbrugger@suse.com>,
	linux-mediatek@lists.infradead.org, rdunlap@infradead.org,
	matthias.bgg@kernel.org,
	Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
	hsinyi@chromium.org, Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Subject: [PATCH v7 06/13] media: mtk-mdp: Check return value of of_clk_get
Date: Thu, 13 Feb 2020 21:19:46 +0100	[thread overview]
Message-ID: <20200213201953.15268-7-matthias.bgg@kernel.org> (raw)
In-Reply-To: <20200213201953.15268-1-matthias.bgg@kernel.org>

From: Matthias Brugger <mbrugger@suse.com>

Check the return value of of_clk_get and print an error
message if not EPROBE_DEFER.

Signed-off-by: Matthias Brugger <mbrugger@suse.com>

---

Changes in v7:
- fix check of return value of of_clk_get
- fix identation

Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None

 drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
index 0c4788af78dd..58abfbdfb82d 100644
--- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
+++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
@@ -110,6 +110,12 @@ int mtk_mdp_comp_init(struct device *dev, struct device_node *node,
 
 	for (i = 0; i < ARRAY_SIZE(comp->clk); i++) {
 		comp->clk[i] = of_clk_get(node, i);
+		if (IS_ERR(comp->clk[i])) {
+			if (PTR_ERR(comp->clk[i]) != -EPROBE_DEFER)
+				dev_err(dev, "Failed to get clock\n");
+
+			return PTR_ERR(comp->clk[i]);
+		}
 
 		/* Only RDMA needs two clocks */
 		if (comp->type != MTK_MDP_RDMA)
-- 
2.24.1


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: matthias.bgg@kernel.org
To: robh+dt@kernel.org, mark.rutland@arm.com, ck.hu@mediatek.com,
	p.zabel@pengutronix.de, airlied@linux.ie,
	mturquette@baylibre.com, sboyd@kernel.org,
	ulrich.hecht+renesas@gmail.com,
	laurent.pinchart@ideasonboard.com, enric.balletbo@collabora.com
Cc: devicetree@vger.kernel.org, drinkcat@chromium.org,
	Minghsiu Tsai <minghsiu.tsai@mediatek.com>,
	frank-w@public-files.de, sean.wang@mediatek.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Houlong Wei <houlong.wei@mediatek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	wens@csie.org, Matthias Brugger <mbrugger@suse.com>,
	linux-mediatek@lists.infradead.org, rdunlap@infradead.org,
	matthias.bgg@kernel.org,
	Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
	hsinyi@chromium.org, Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Subject: [PATCH v7 06/13] media: mtk-mdp: Check return value of of_clk_get
Date: Thu, 13 Feb 2020 21:19:46 +0100	[thread overview]
Message-ID: <20200213201953.15268-7-matthias.bgg@kernel.org> (raw)
In-Reply-To: <20200213201953.15268-1-matthias.bgg@kernel.org>

From: Matthias Brugger <mbrugger@suse.com>

Check the return value of of_clk_get and print an error
message if not EPROBE_DEFER.

Signed-off-by: Matthias Brugger <mbrugger@suse.com>

---

Changes in v7:
- fix check of return value of of_clk_get
- fix identation

Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None

 drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
index 0c4788af78dd..58abfbdfb82d 100644
--- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
+++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
@@ -110,6 +110,12 @@ int mtk_mdp_comp_init(struct device *dev, struct device_node *node,
 
 	for (i = 0; i < ARRAY_SIZE(comp->clk); i++) {
 		comp->clk[i] = of_clk_get(node, i);
+		if (IS_ERR(comp->clk[i])) {
+			if (PTR_ERR(comp->clk[i]) != -EPROBE_DEFER)
+				dev_err(dev, "Failed to get clock\n");
+
+			return PTR_ERR(comp->clk[i]);
+		}
 
 		/* Only RDMA needs two clocks */
 		if (comp->type != MTK_MDP_RDMA)
-- 
2.24.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: matthias.bgg@kernel.org
To: robh+dt@kernel.org, mark.rutland@arm.com, ck.hu@mediatek.com,
	p.zabel@pengutronix.de, airlied@linux.ie,
	mturquette@baylibre.com, sboyd@kernel.org,
	ulrich.hecht+renesas@gmail.com,
	laurent.pinchart@ideasonboard.com, enric.balletbo@collabora.com
Cc: devicetree@vger.kernel.org, drinkcat@chromium.org,
	Minghsiu Tsai <minghsiu.tsai@mediatek.com>,
	frank-w@public-files.de, sean.wang@mediatek.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Houlong Wei <houlong.wei@mediatek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	wens@csie.org, Matthias Brugger <mbrugger@suse.com>,
	linux-mediatek@lists.infradead.org, rdunlap@infradead.org,
	matthias.bgg@kernel.org,
	Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
	hsinyi@chromium.org, Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Subject: [PATCH v7 06/13] media: mtk-mdp: Check return value of of_clk_get
Date: Thu, 13 Feb 2020 21:19:46 +0100	[thread overview]
Message-ID: <20200213201953.15268-7-matthias.bgg@kernel.org> (raw)
In-Reply-To: <20200213201953.15268-1-matthias.bgg@kernel.org>

From: Matthias Brugger <mbrugger@suse.com>

Check the return value of of_clk_get and print an error
message if not EPROBE_DEFER.

Signed-off-by: Matthias Brugger <mbrugger@suse.com>

---

Changes in v7:
- fix check of return value of of_clk_get
- fix identation

Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None

 drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
index 0c4788af78dd..58abfbdfb82d 100644
--- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
+++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
@@ -110,6 +110,12 @@ int mtk_mdp_comp_init(struct device *dev, struct device_node *node,
 
 	for (i = 0; i < ARRAY_SIZE(comp->clk); i++) {
 		comp->clk[i] = of_clk_get(node, i);
+		if (IS_ERR(comp->clk[i])) {
+			if (PTR_ERR(comp->clk[i]) != -EPROBE_DEFER)
+				dev_err(dev, "Failed to get clock\n");
+
+			return PTR_ERR(comp->clk[i]);
+		}
 
 		/* Only RDMA needs two clocks */
 		if (comp->type != MTK_MDP_RDMA)
-- 
2.24.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-02-13 20:20 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-13 20:19 [PATCH v7 00/13] arm/arm64: mediatek: Fix mmsys device probing matthias.bgg
2020-02-13 20:19 ` matthias.bgg
2020-02-13 20:19 ` matthias.bgg
2020-02-13 20:19 ` matthias.bgg
2020-02-13 20:19 ` [PATCH v7 01/13] dt-bindings: arm: move mmsys description to display matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-14  6:42   ` CK Hu
2020-02-14  6:42     ` CK Hu
2020-02-14  6:42     ` CK Hu
2020-02-14  6:42     ` CK Hu
2020-02-14 10:01     ` Matthias Brugger
2020-02-14 10:01       ` Matthias Brugger
2020-02-14 10:01       ` Matthias Brugger
2020-02-14 10:01       ` Matthias Brugger
2020-02-14 12:19       ` Enric Balletbo i Serra
2020-02-14 12:19         ` Enric Balletbo i Serra
2020-02-14 12:19         ` Enric Balletbo i Serra
2020-02-14 12:19         ` Enric Balletbo i Serra
2020-02-14 16:22         ` CK Hu
2020-02-14 16:22           ` CK Hu
2020-02-14 16:22           ` CK Hu
2020-02-14 16:22           ` CK Hu
2020-02-13 20:19 ` [PATCH v7 02/13] dt-bindings: display: mediatek: Add mmsys binding description matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-18 20:31   ` Rob Herring
2020-02-18 20:31     ` Rob Herring
2020-02-18 20:31     ` Rob Herring
2020-02-18 20:31     ` Rob Herring
2020-02-13 20:19 ` [PATCH v7 03/13] dt-bindings: mediatek: Add compatible for mt7623 matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19 ` [PATCH v7 04/13] drm/mediatek: Use regmap for register access matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19 ` [PATCH v7 05/13] drm: mediatek: Omit warning on probe defers matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19 ` matthias.bgg [this message]
2020-02-13 20:19   ` [PATCH v7 06/13] media: mtk-mdp: Check return value of of_clk_get matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-24 17:36   ` Hans Verkuil
2020-02-24 17:36     ` Hans Verkuil
2020-02-24 17:36     ` Hans Verkuil
2020-02-24 17:36     ` Hans Verkuil
2020-02-24 21:47     ` Matthias Brugger
2020-02-24 21:47       ` Matthias Brugger
2020-02-24 21:47       ` Matthias Brugger
2020-02-24 21:47       ` Matthias Brugger
2020-02-13 20:19 ` [PATCH v7 07/13] clk: mediatek: mt2701: switch mmsys to platform device probing matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19 ` [PATCH v7 08/13] clk: mediatek: mt2712e: switch " matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19 ` [PATCH v7 09/13] clk: mediatek: mt6779: switch mmsys " matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19 ` [PATCH v7 10/13] clk: mediatek: mt6797: switch " matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19 ` [PATCH v7 11/13] clk: mediatek: mt8183: switch mmsys " matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-14  1:52   ` CK Hu
2020-02-14  1:52     ` CK Hu
2020-02-14  1:52     ` CK Hu
2020-02-14  1:52     ` CK Hu
2020-02-13 20:19 ` [PATCH v7 12/13] clk: mediatek: mt8173: " matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19 ` [PATCH v7 13/13] drm/mediatek: Add support for mmsys through a pdev matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg
2020-02-13 20:19   ` matthias.bgg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200213201953.15268-7-matthias.bgg@kernel.org \
    --to=matthias.bgg@kernel.org \
    --cc=airlied@linux.ie \
    --cc=andrew-ct.chen@mediatek.com \
    --cc=ck.hu@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=drinkcat@chromium.org \
    --cc=enric.balletbo@collabora.com \
    --cc=frank-w@public-files.de \
    --cc=houlong.wei@mediatek.com \
    --cc=hsinyi@chromium.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mbrugger@suse.com \
    --cc=mchehab@kernel.org \
    --cc=minghsiu.tsai@mediatek.com \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=rdunlap@infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sean.wang@mediatek.com \
    --cc=ulrich.hecht+renesas@gmail.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.