All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Yang <richardw.yang@linux.intel.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	mhocko@suse.com, yang.shi@linux.alibaba.com, rientjes@google.com,
	david@redhat.com, Wei Yang <richardw.yang@linux.intel.com>
Subject: [Patch v5 1/4] mm/migrate.c: no need to check for i > start in do_pages_move()
Date: Fri, 14 Feb 2020 08:30:14 +0800	[thread overview]
Message-ID: <20200214003017.25558-2-richardw.yang@linux.intel.com> (raw)
In-Reply-To: <20200214003017.25558-1-richardw.yang@linux.intel.com>

At this point, we always have i >= start. If i == start, store_status()
will return 0. So we can drop the check for i > start.

[david@redhat.com rephrase changelog]

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
---
 mm/migrate.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/mm/migrate.c b/mm/migrate.c
index b1092876e537..6d466de4d1d0 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1675,11 +1675,9 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes,
 				err += nr_pages - i - 1;
 			goto out;
 		}
-		if (i > start) {
-			err = store_status(status, start, current_node, i - start);
-			if (err)
-				goto out;
-		}
+		err = store_status(status, start, current_node, i - start);
+		if (err)
+			goto out;
 		current_node = NUMA_NO_NODE;
 	}
 out_flush:
-- 
2.17.1


  reply	other threads:[~2020-02-14  0:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14  0:30 [Patch v5 0/4] cleanup on do_pages_move() Wei Yang
2020-02-14  0:30 ` Wei Yang [this message]
2020-02-14  0:30 ` [Patch v5 2/4] mm/migrate.c: wrap do_move_pages_to_node() and store_status() Wei Yang
2020-02-14  0:30 ` [Patch v5 3/4] mm/migrate.c: check pagelist in move_pages_and_store_status() Wei Yang
2020-02-14  0:30 ` [Patch v5 4/4] mm/migrate.c: unify "not queued for migration" handling in do_pages_move() Wei Yang
2020-04-07 12:45 ` [Patch v5 0/4] cleanup on do_pages_move() Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200214003017.25558-2-richardw.yang@linux.intel.com \
    --to=richardw.yang@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=rientjes@google.com \
    --cc=yang.shi@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.