From: Jules Irenge <jbi.octave@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: boqun.feng@gmail.com, Jules Irenge <jbi.octave@gmail.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)),
xen-devel@lists.xenproject.org (moderated list:XEN HYPERVISOR
INTERFACE)
Subject: [PATCH 15/30] x86/xen: Add missing annotation for xen_pte_unlock()
Date: Fri, 14 Feb 2020 20:47:26 +0000 [thread overview]
Message-ID: <20200214204741.94112-16-jbi.octave@gmail.com> (raw)
In-Reply-To: <20200214204741.94112-1-jbi.octave@gmail.com>
Sparse reports warning at xen_pte_unlock()
warning: context imbalance in xen_pte_unlock() - unexpected unlock
The root cause is the missing annotation at xen_pte_unlock()
Add the missing __releases(ptl) annotation
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
arch/x86/xen/mmu_pv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c
index 352f0c80cfcf..777008f8c668 100644
--- a/arch/x86/xen/mmu_pv.c
+++ b/arch/x86/xen/mmu_pv.c
@@ -707,7 +707,7 @@ static spinlock_t *xen_pte_lock(struct page *page, struct mm_struct *mm)
return ptl;
}
-static void xen_pte_unlock(void *v)
+static void xen_pte_unlock(void *v) __releases(ptl)
{
spinlock_t *ptl = v;
spin_unlock(ptl);
--
2.24.1
WARNING: multiple messages have this Message-ID (diff)
From: Jules Irenge <jbi.octave@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
Jules Irenge <jbi.octave@gmail.com>,
Stefano Stabellini <sstabellini@kernel.org>,
boqun.feng@gmail.com,
"maintainer:X86 ARCHITECTURE 32-BIT AND 64-BIT" <x86@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"moderated list:XEN HYPERVISOR INTERFACE"
<xen-devel@lists.xenproject.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [Xen-devel] [PATCH 15/30] x86/xen: Add missing annotation for xen_pte_unlock()
Date: Fri, 14 Feb 2020 20:47:26 +0000 [thread overview]
Message-ID: <20200214204741.94112-16-jbi.octave@gmail.com> (raw)
In-Reply-To: <20200214204741.94112-1-jbi.octave@gmail.com>
Sparse reports warning at xen_pte_unlock()
warning: context imbalance in xen_pte_unlock() - unexpected unlock
The root cause is the missing annotation at xen_pte_unlock()
Add the missing __releases(ptl) annotation
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
arch/x86/xen/mmu_pv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c
index 352f0c80cfcf..777008f8c668 100644
--- a/arch/x86/xen/mmu_pv.c
+++ b/arch/x86/xen/mmu_pv.c
@@ -707,7 +707,7 @@ static spinlock_t *xen_pte_lock(struct page *page, struct mm_struct *mm)
return ptl;
}
-static void xen_pte_unlock(void *v)
+static void xen_pte_unlock(void *v) __releases(ptl)
{
spinlock_t *ptl = v;
spin_unlock(ptl);
--
2.24.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-02-14 20:49 UTC|newest]
Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0/30>
2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
2020-02-14 20:47 ` [PATCH 01/30] x86/apic/vector: Add missing annotation to lock_vector_lock(void) Jules Irenge
2020-02-14 20:47 ` [PATCH 02/30] " Jules Irenge
2020-02-14 20:47 ` [PATCH 03/30] mm/memcontrol: Add missing annotation for unlock_page_lru() Jules Irenge
2020-02-14 20:47 ` Jules Irenge
2020-02-14 20:47 ` [PATCH 04/30] mm/memcontrol: Add missing annotation for lock_page_lru() Jules Irenge
2020-02-14 20:47 ` Jules Irenge
2020-02-14 20:47 ` [PATCH 05/30] mm/compaction: Add missing annotation for compact_lock_irqsave Jules Irenge
2020-02-14 20:47 ` [PATCH 06/30] mm/hugetlb: Add missing annotation for gather_surplus_pages() Jules Irenge
2020-02-14 23:40 ` Mike Kravetz
2020-02-14 20:47 ` [PATCH 07/30] mm/mempolicy: Add missing annotation for queue_pages_pmd() Jules Irenge
2020-02-14 20:47 ` [PATCH 08/30] mm/slub: Add missing annotation for get_map() Jules Irenge
2020-02-14 20:47 ` [PATCH 09/30] mm/slub: Add missing annotation for put_map() Jules Irenge
2020-02-14 20:47 ` [PATCH 10/30] mm/zsmalloc: Add missing annotation for migrate_read_lock() Jules Irenge
2020-02-27 21:52 ` Minchan Kim
2020-02-27 21:52 ` Minchan Kim
2020-02-27 21:52 ` Minchan Kim
2020-02-27 21:52 ` Minchan Kim
2020-02-14 20:47 ` [PATCH 11/30] mm/zsmalloc: Add missing annotation for migrate_read_unlock() Jules Irenge
2020-02-27 21:54 ` Minchan Kim
2020-02-27 21:54 ` Minchan Kim
2020-02-14 20:47 ` [PATCH 12/30] mm/zsmalloc: Add missing annotation for pin_tag() Jules Irenge
2020-02-27 21:53 ` Minchan Kim
2020-02-27 21:53 ` Minchan Kim
2020-02-14 20:47 ` [PATCH 13/30] mm/zsmalloc: Add missing annotation for unpin_tag() Jules Irenge
2020-02-27 21:53 ` Minchan Kim
2020-02-27 21:53 ` Minchan Kim
2020-02-14 20:47 ` [PATCH 14/30] x86/xen: Add missing annotation for xen_pte_lock() Jules Irenge
2020-02-14 20:47 ` [Xen-devel] " Jules Irenge
2020-02-14 22:40 ` Boris Ostrovsky
2020-02-14 22:40 ` Boris Ostrovsky
2020-02-15 21:13 ` Jules Irenge
2020-02-15 21:13 ` Jules Irenge
2020-02-14 20:47 ` Jules Irenge [this message]
2020-02-14 20:47 ` [Xen-devel] [PATCH 15/30] x86/xen: Add missing annotation for xen_pte_unlock() Jules Irenge
2020-02-14 20:47 ` [PATCH 16/30] drm/vkms: Add missing annotation for vkms_crtc_atomic_begin() Jules Irenge
2020-02-14 20:47 ` Jules Irenge
2020-02-14 20:47 ` [PATCH 17/30] drm/vkms: Add missing annotation for vkms_crtc_atomic_flush() Jules Irenge
2020-02-14 20:47 ` Jules Irenge
2020-02-14 20:47 ` [PATCH 18/30] driver core: Add missing annotation for device_links_write_lock() Jules Irenge
2020-02-14 20:47 ` [PATCH 19/30] driver core: Add missing annotation for device_links_read_lock() Jules Irenge
2020-02-14 20:47 ` [PATCH 20/30] pcnet32: Add missing annotation for pcnet32_suspend() Jules Irenge
2020-02-14 20:47 ` [PATCH 21/30] sfc: Add missing annotation for efx_ef10_try_update_nic_stats_vf() Jules Irenge
2020-02-17 18:00 ` Martin Habets
2020-02-14 20:47 ` [PATCH 22/30] xhci: Add missing annotation for xhci_set_port_power() Jules Irenge
2020-02-14 20:47 ` [PATCH 23/30] xhci: Add missing annotation for xhci_enter_test_mode Jules Irenge
2020-02-14 20:47 ` [PATCH 24/30] tipc: Add missing annotation for tipc_node_read_lock() Jules Irenge
2020-02-14 20:47 ` [PATCH 25/30] tipc: Add missing annotation for tipc_node_read_unlock() Jules Irenge
2020-02-14 20:47 ` [PATCH 26/30] tipc: Add missing annotation for tipc_node_write_lock() Jules Irenge
2020-02-14 20:47 ` [PATCH 27/30] tipc: Add missing annotation for tipc_node_write_unlock_fast() Jules Irenge
2020-02-14 20:47 ` [PATCH 28/30] tipc: Add missing annotation for tipc_node_write_unlock() Jules Irenge
2020-02-14 20:47 ` [PATCH 29/30] net: Add missing annotation for netlink_walk_start() Jules Irenge
2020-02-14 20:47 ` [PATCH 30/30] net: Add missing annotation for netlink_walk_stop() Jules Irenge
2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
2020-02-23 23:16 ` [PATCH 01/30] btrfs: Add missing annotation for release_extent_buffer() Jules Irenge
2020-02-23 23:27 ` Nikolay Borisov
2020-02-24 15:19 ` David Sterba
2020-02-23 23:16 ` [PATCH 02/30] dax: Add missing annotations ofr dax_read_lock() and dax_read_unlock() Jules Irenge
2020-02-23 23:16 ` Jules Irenge
2020-02-24 1:23 ` Yi Zhang
2020-02-24 1:23 ` Yi Zhang
2020-02-23 23:16 ` [PATCH 03/30] xfs: Add missing annotation to xfs_ail_check() Jules Irenge
2020-02-25 15:44 ` Darrick J. Wong
2020-02-23 23:16 ` [PATCH 04/30] sctp: Add missing annotation for sctp_err_finish() Jules Irenge
2020-02-23 23:16 ` Jules Irenge
2020-02-24 21:28 ` David Miller
2020-02-24 21:28 ` David Miller
2020-02-23 23:16 ` [PATCH 05/30] sctp: Add missing annotation for sctp_transport_walk_start() Jules Irenge
2020-02-23 23:16 ` Jules Irenge
2020-02-24 21:28 ` David Miller
2020-02-24 21:28 ` David Miller
2020-02-23 23:16 ` [PATCH 06/30] sctp: Add missing annotation for sctp_transport_walk_stop() Jules Irenge
2020-02-23 23:16 ` Jules Irenge
2020-02-24 21:28 ` David Miller
2020-02-24 21:28 ` David Miller
2020-02-23 23:16 ` [PATCH 07/30] net: Add missing annotation for llc_seq_start() Jules Irenge
2020-02-24 21:28 ` David Miller
2020-02-23 23:16 ` [PATCH 08/30] netrom: Add missing annotation for nr_info_start() Jules Irenge
2020-02-23 23:16 ` Jules Irenge
2020-02-24 21:29 ` David Miller
2020-02-23 23:16 ` [PATCH 09/30] netrom: Add missing annotation for nr_info_stop() Jules Irenge
2020-02-23 23:16 ` Jules Irenge
2020-02-24 21:29 ` David Miller
2020-02-23 23:16 ` [PATCH 10/30] net: netrom: Add missing annotation for nr_node_start() Jules Irenge
2020-02-23 23:16 ` Jules Irenge
2020-02-24 21:29 ` David Miller
2020-02-23 23:16 ` [PATCH 11/30] net: netrom: Add missing annotation for nr_node_stop() Jules Irenge
2020-02-23 23:16 ` Jules Irenge
2020-02-24 21:29 ` David Miller
2020-02-23 23:16 ` [PATCH 12/30] net: netrom: Add missing annotation for nr_neigh_start() Jules Irenge
2020-02-23 23:16 ` Jules Irenge
2020-02-24 21:29 ` David Miller
2020-02-23 23:16 ` [PATCH 13/30] net: netrom: Add missing annotation for nr_neigh_stop() Jules Irenge
2020-02-23 23:16 ` Jules Irenge
2020-02-24 21:29 ` David Miller
2020-02-23 23:16 ` [PATCH 14/30] dccp: Add missing annotation for dccp_child_process() Jules Irenge
2020-02-23 23:16 ` Jules Irenge
2020-02-24 21:29 ` David Miller
2020-02-24 21:29 ` David Miller
2020-02-23 23:16 ` [PATCH 15/30] af_unix: Add missing annotation for unix_wait_for_peer() Jules Irenge
2020-02-24 21:29 ` David Miller
2020-02-23 23:16 ` [PATCH 16/30] proc: Add missing annotation for close_pdeo() Jules Irenge
2020-02-23 23:16 ` [PATCH 17/30] mm/zsmalloc: Add missing annotation for zs_map_object() Jules Irenge
2020-02-23 23:16 ` [PATCH 18/30] mm/zsmalloc: Add missing annotation for zs_unmap_object() Jules Irenge
2020-02-23 23:17 ` [PATCH 19/30] mm/zsmalloc: Add missing annotation for migrate_write_lock() Jules Irenge
2020-02-23 23:17 ` [PATCH 20/30] mm/zsmalloc: Add missing annotation for migrate_write_unlock() Jules Irenge
2020-02-23 23:17 ` [PATCH 21/30] scsi: csiostor: Add missing annotation for csio_scsi_cleanup_io_q() Jules Irenge
2020-02-23 23:17 ` [PATCH 22/30] ACPI: OSL: Add missing annotation for acpi_os_acquire_lock() Jules Irenge
2020-03-04 11:00 ` Rafael J. Wysocki
2020-02-23 23:17 ` [PATCH 23/30] ACPI: OSL: Add missing annotation for acpi_os_release_lock() Jules Irenge
2020-02-23 23:17 ` [PATCH 24/30] dmaengine: mic_x100_dma: Add missing annotation for mic_dma_tx_submit_unlock() Jules Irenge
2020-02-23 23:17 ` [PATCH 25/30] zram: Add missing annotatin for zram_slot_lock() Jules Irenge
2020-02-23 23:17 ` [PATCH 26/30] zram: Add missing annotatin for zram_slot_unlock() Jules Irenge
2020-02-23 23:17 ` [PATCH 27/30] habanalabs: Add missing annotation for goya_hw_queues_lock() Jules Irenge
2020-02-25 11:55 ` Oded Gabbay
2020-02-23 23:17 ` [PATCH 28/30] habanalabs: Add missing annotation for goya_hw_queues_unlock() Jules Irenge
2020-02-25 11:56 ` Oded Gabbay
2020-02-23 23:17 ` [PATCH 29/30] sgi-xp: Add missing annotation for xpc_disconnect_channel() Jules Irenge
2020-02-28 19:22 ` Robin Holt
2020-02-23 23:17 ` [PATCH 30/30] sgi-xp: Add missing annotation for ocfs2_inode_cache_lock() and ocfs2_inode_cache_unlock() Jules Irenge
2020-02-23 23:17 ` [Ocfs2-devel] " Jules Irenge
2020-02-24 1:52 ` Joseph Qi
2020-02-24 1:52 ` [Ocfs2-devel] " Joseph Qi
2020-02-25 0:54 ` Joseph Qi
2020-02-25 0:54 ` [Ocfs2-devel] " Joseph Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214204741.94112-16-jbi.octave@gmail.com \
--to=jbi.octave@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.