All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacopo Mondi <jacopo+renesas@jmondi.org>
To: kieran.bingham+renesas@ideasonboard.com,
	laurent.pinchart@ideasonboard.com, niklas.soderlund@ragnatech.se
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
	linux-renesas-soc@vger.kernel.org
Subject: [PATCH v7 1/6] media: i2c: max9286: Disable overlap window
Date: Sun, 16 Feb 2020 11:51:00 +0100	[thread overview]
Message-ID: <20200216105105.3751688-2-jacopo+renesas@jmondi.org> (raw)
In-Reply-To: <20200216105105.3751688-1-jacopo+renesas@jmondi.org>

Disable the overlap window. This settings is briefly documented in the
chip manual, but it probably concur in the frame syncronization timing
calculations.

Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

---
v7:
  - new patch required to capture from RDACM21
---
 drivers/media/i2c/max9286.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
index b5b8d4919c78..ed5dcae6b363 100644
--- a/drivers/media/i2c/max9286.c
+++ b/drivers/media/i2c/max9286.c
@@ -1015,6 +1015,10 @@ static int max9286_setup(struct max9286_priv *priv)
 	max9286_write(priv, 0x01, MAX9286_FSYNCMODE_INT_HIZ |
 		      MAX9286_FSYNCMETH_AUTO);
 
+	/* Disable overlap window. */
+	max9286_write(priv, 0x63, 0);
+	max9286_write(priv, 0x64, 0);
+
 	/* Enable HS/VS encoding, use D14/15 for HS/VS, invert VS. */
 	max9286_write(priv, 0x0c, MAX9286_HVEN | MAX9286_INVVS |
 		      MAX9286_HVSRC_D14);
-- 
2.25.0


  reply	other threads:[~2020-02-16 10:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-16 10:50 [PATCH v7 0/6] RDACM20 and RDACM21 GMSL camera support Jacopo Mondi
2020-02-16 10:51 ` Jacopo Mondi [this message]
2020-02-16 10:51 ` [PATCH v7 2/6] dt-bindings: media: i2c: Add bindings for IMI RDACM2x Jacopo Mondi
2020-02-16 10:51 ` [PATCH v7 3/6] media: i2c: Add driver for RDACM20 camera module Jacopo Mondi
2020-02-16 10:51 ` [PATCH v7 4/6] media: i2c: max9286: Adjust reverse channel amplitude Jacopo Mondi
2020-02-16 10:51 ` [PATCH v7 5/6] media: i2c: max9286: Adjust image format size Jacopo Mondi
2020-02-16 10:51 ` [PATCH v7 6/6] media: i2c: Add driver for RDACM21 camera module Jacopo Mondi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200216105105.3751688-2-jacopo+renesas@jmondi.org \
    --to=jacopo+renesas@jmondi.org \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=niklas.soderlund@ragnatech.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.