All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	Boris Brezillon <bbrezillon@kernel.org>
Subject: [PATCH v6 38/51] drm/omap: hdmi: Remove omap_dss_device operations
Date: Sun, 16 Feb 2020 23:02:55 +0200	[thread overview]
Message-ID: <20200216210308.17312-39-laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <20200216210308.17312-1-laurent.pinchart@ideasonboard.com>

Now that the HDMI outputs are driven fully through the drm_bridge API
their omap_dss_device operations are not used anymore. Remove them.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 drivers/gpu/drm/omapdrm/dss/hdmi.h  |  1 -
 drivers/gpu/drm/omapdrm/dss/hdmi4.c | 18 ------------------
 drivers/gpu/drm/omapdrm/dss/hdmi5.c | 18 ------------------
 3 files changed, 37 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi.h b/drivers/gpu/drm/omapdrm/dss/hdmi.h
index bd43f6abf27b..3a40833d3368 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi.h
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi.h
@@ -380,7 +380,6 @@ struct omap_hdmi {
 	bool display_enabled;
 };
 
-#define dssdev_to_hdmi(dssdev) container_of(dssdev, struct omap_hdmi, output)
 #define drm_bridge_to_hdmi(b) container_of(b, struct omap_hdmi, bridge)
 
 #endif
diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4.c b/drivers/gpu/drm/omapdrm/dss/hdmi4.c
index b9bcd6e681e8..96ef7bd52199 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi4.c
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi4.c
@@ -309,18 +309,6 @@ void hdmi4_core_disable(struct hdmi_core_data *core)
 	mutex_unlock(&hdmi->lock);
 }
 
-static int hdmi_connect(struct omap_dss_device *src,
-			struct omap_dss_device *dst)
-{
-	return omapdss_device_connect(dst->dss, dst, dst->next);
-}
-
-static void hdmi_disconnect(struct omap_dss_device *src,
-			    struct omap_dss_device *dst)
-{
-	omapdss_device_disconnect(dst, dst->next);
-}
-
 static struct edid *
 hdmi_do_read_edid(struct omap_hdmi *hdmi,
 		  struct edid *(*read)(struct omap_hdmi *hdmi,
@@ -370,11 +358,6 @@ hdmi_do_read_edid(struct omap_hdmi *hdmi,
 	return edid;
 }
 
-static const struct omap_dss_device_ops hdmi_ops = {
-	.connect		= hdmi_connect,
-	.disconnect		= hdmi_disconnect,
-};
-
 /* -----------------------------------------------------------------------------
  * DRM Bridge Operations
  */
@@ -741,7 +724,6 @@ static int hdmi4_init_output(struct omap_hdmi *hdmi)
 	out->type = OMAP_DISPLAY_TYPE_HDMI;
 	out->name = "hdmi.0";
 	out->dispc_channel = OMAP_DSS_CHANNEL_DIGIT;
-	out->ops = &hdmi_ops;
 	out->owner = THIS_MODULE;
 	out->of_port = 0;
 
diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5.c b/drivers/gpu/drm/omapdrm/dss/hdmi5.c
index effe4a9401ff..6cb709c775d6 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi5.c
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi5.c
@@ -307,18 +307,6 @@ static void hdmi_core_disable(struct omap_hdmi *hdmi)
 	mutex_unlock(&hdmi->lock);
 }
 
-static int hdmi_connect(struct omap_dss_device *src,
-			struct omap_dss_device *dst)
-{
-	return omapdss_device_connect(dst->dss, dst, dst->next);
-}
-
-static void hdmi_disconnect(struct omap_dss_device *src,
-			    struct omap_dss_device *dst)
-{
-	omapdss_device_disconnect(dst, dst->next);
-}
-
 static struct edid *
 hdmi_do_read_edid(struct omap_hdmi *hdmi,
 		  struct edid *(*read)(struct omap_hdmi *hdmi,
@@ -363,11 +351,6 @@ hdmi_do_read_edid(struct omap_hdmi *hdmi,
 	return (struct edid *)edid;
 }
 
-static const struct omap_dss_device_ops hdmi_ops = {
-	.connect		= hdmi_connect,
-	.disconnect		= hdmi_disconnect,
-};
-
 /* -----------------------------------------------------------------------------
  * DRM Bridge Operations
  */
@@ -715,7 +698,6 @@ static int hdmi5_init_output(struct omap_hdmi *hdmi)
 	out->type = OMAP_DISPLAY_TYPE_HDMI;
 	out->name = "hdmi.0";
 	out->dispc_channel = OMAP_DSS_CHANNEL_DIGIT;
-	out->ops = &hdmi_ops;
 	out->owner = THIS_MODULE;
 	out->of_port = 0;
 
-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-02-16 21:04 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-16 21:02 [PATCH v6 00/51] drm/omap: Replace custom display drivers with drm_bridge and drm_panel Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 01/51] video: hdmi: Change return type of hdmi_avi_infoframe_init() to void Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 02/51] drm/connector: Add helper to get a connector type name Laurent Pinchart
2020-02-17  9:43   ` Daniel Vetter
2020-02-21 14:15     ` Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 03/51] drm/edid: Add flag to drm_display_info to identify HDMI sinks Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 04/51] drm/bridge: Add connector-related bridge operations and data Laurent Pinchart
2020-02-17  9:53   ` Daniel Vetter
2020-02-18  1:21     ` Laurent Pinchart
2020-02-18  6:44       ` Daniel Vetter
2020-02-21 14:23         ` Laurent Pinchart
2020-02-21 17:05           ` Daniel Vetter
2020-02-21 17:18           ` Sam Ravnborg
2020-02-22  9:02             ` Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 05/51] drm/bridge: Add interlace_allowed flag to drm_bridge Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 06/51] drm/bridge: Extend bridge API to disable connector creation Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 07/51] drm/bridge: dumb-vga-dac: Rename internal symbols to simple-bridge Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 08/51] drm/bridge: dumb-vga-dac: Rename driver " Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 09/51] drm/bridge: simple-bridge: Add support for non-VGA bridges Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 10/51] drm/bridge: simple-bridge: Add support for enable GPIO Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 11/51] drm/bridge: simple-bridge: Add support for the TI OPA362 Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 12/51] drm/bridge: Add bridge driver for display connectors Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 13/51] drm/bridge: Add driver for the TI TPD12S015 HDMI level shifter Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 14/51] drm/bridge: panel: Implement bridge connector operations Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 15/51] drm/bridge: tfp410: Replace manual connector handling with bridge Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 16/51] drm/bridge: tfp410: Allow operation without drm_connector Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 17/51] drm: Add helper to create a connector for a chain of bridges Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 18/51] drm/omap: dss: Cleanup DSS ports on initialisation failure Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 19/51] drm/omap: Simplify HDMI mode and infoframe configuration Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 20/51] drm/omap: Factor out display type to connector type conversion Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 21/51] drm/omap: Use the drm_panel_bridge API Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 22/51] drm/omap: dss: Fix output next device lookup in DT Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 23/51] drm/omap: Add infrastructure to support drm_bridge local to DSS outputs Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 24/51] drm/omap: dss: Make omap_dss_device_ops optional Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 25/51] drm/omap: hdmi: Allocate EDID in the .read_edid() operation Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 26/51] drm/omap: hdmi4: Rework EDID read to isolate data read Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 27/51] drm/omap: hdmi5: " Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 28/51] drm/omap: hdmi4: Register a drm_bridge for EDID read Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 29/51] drm/omap: hdmi5: " Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 30/51] drm/omap: hdmi4: Move mode set, enable and disable operations to bridge Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 31/51] drm/omap: hdmi5: " Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 32/51] drm/omap: hdmi4: Implement drm_bridge .hpd_notify() operation Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 33/51] drm/omap: dss: Remove .set_hdmi_mode() and .set_infoframe() operations Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 34/51] drm/omap: venc: Register a drm_bridge Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 35/51] drm/omap: Create connector for bridges Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 36/51] drm/omap: Switch the HDMI and VENC outputs to drm_bridge Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 37/51] drm/omap: Remove HPD, detect and EDID omapdss operations Laurent Pinchart
2020-02-16 21:02 ` Laurent Pinchart [this message]
2020-02-16 21:02 ` [PATCH v6 39/51] drm/omap: venc: Remove omap_dss_device operations Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 40/51] drm/omap: hdmi4: Simplify EDID read Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 41/51] drm/omap: hdmi5: " Laurent Pinchart
2020-02-16 21:02 ` [PATCH v6 42/51] drm/omap: dpi: Sort includes alphabetically Laurent Pinchart
2020-02-16 21:03 ` [PATCH v6 43/51] drm/omap: dpi: Reorder functions in sections Laurent Pinchart
2020-02-16 21:03 ` [PATCH v6 44/51] drm/omap: dpi: Simplify clock setting API Laurent Pinchart
2020-02-16 21:03 ` [PATCH v6 45/51] drm/omap: dpi: Register a drm_bridge Laurent Pinchart
2020-02-21 12:25   ` Tomi Valkeinen
2020-02-16 21:03 ` [PATCH v6 46/51] drm/omap: sdi: Sort includes alphabetically Laurent Pinchart
2020-02-16 21:03 ` [PATCH v6 47/51] drm/omap: sdi: Register a drm_bridge Laurent Pinchart
2020-02-16 21:03 ` [PATCH v6 48/51] drm/omap: Hardcode omap_connector type to DSI Laurent Pinchart
2020-02-21 12:20   ` Tomi Valkeinen
2020-02-16 21:03 ` [PATCH v6 49/51] drm/omap: dss: Remove unused omap_dss_device operations Laurent Pinchart
2020-02-20 21:39   ` Sebastian Reichel
2020-02-20 21:45     ` Laurent Pinchart
2020-02-22  3:13       ` Sebastian Reichel
2020-02-16 21:03 ` [PATCH v6 50/51] drm/omap: dss: Inline the omapdss_display_get() function Laurent Pinchart
2020-02-16 21:03 ` [PATCH v6 51/51] drm/omap: dss: Remove unused omapdss_of_find_connected_device() function Laurent Pinchart
2020-02-17 23:00 ` [PATCH v6 00/51] drm/omap: Replace custom display drivers with drm_bridge and drm_panel Sebastian Reichel
2020-02-17 23:16   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200216210308.17312-39-laurent.pinchart@ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=bbrezillon@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sam@ravnborg.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.