All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Tobin C. Harding" <tobin@kernel.org>
To: Christoph Lameter <cl@linux.com>
Cc: "Tobin C. Harding" <tobin@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] slabinfo: parse all NUMA attributes
Date: Mon, 17 Feb 2020 19:48:26 +1100	[thread overview]
Message-ID: <20200217084828.9092-1-tobin@kernel.org> (raw)

Hi Christoph,

I found a few files in /sys/kernel/slab/foo/ that contain NUMA info that
is not currently being parsed by `slabinfo.c`.  I do not know whether
this is intentional or not?  Since I did not know this I just printed
the info in the NUMA report section like is done for the per node slabs
and partial slabs info.

Just for your interest; I found these while re-writing slabinfo in Rust,
thanks to the type-system.  I guess that if they were unintentionally
missed then this is a small win, if they were intentionally missed then
this series is just noise :)

Patch one is a one line whitespace fix.

To test I comment out the code that inhibits NUMA output for single node
machines and then the output looks like this (relevant bit at the bottom)

$ sudo slabinfo kmem_cache_node
Slabcache: kmem_cache_node  Aliases:  0 Order :  0 Objects: 1877
** Hardware cacheline aligned

Sizes (bytes)     Slabs              Debug                Memory
------------------------------------------------------------------------
Object :      64  Total  :      34   Sanity Checks : Off  Total:  139264
SlabObj:      64  Full   :      15   Redzoning     : Off  Used :  120128
SlabSiz:    4096  Partial:      17   Poisoning     : Off  Loss :   19136
Loss   :       0  CpuSlab:       2   Tracking      : Off  Lalig:       0
Align  :      64  Objects:      64   Tracing       : Off  Lpadd:       0

kmem_cache_node has no kmem_cache operations

kmem_cache_node: Kernel object allocation
-----------------------------------------------------------------------
No Data

kmem_cache_node: Kernel object freeing
------------------------------------------------------------------------
No Data

NUMA nodes           :    0
---------------------------
All slabs                34
Partial slabs            17
CPU slabs                 2
Objects                1.8K
Partial objects         789
Total objects          2.1K

Tobin C. Harding (2):
  tools: vm: slabinfo: Replace tabs with spaces
  tools: vm: slabinfo: Add numa information for objects

 tools/vm/slabinfo.c | 69 +++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 63 insertions(+), 6 deletions(-)

-- 
2.17.1


             reply	other threads:[~2020-02-17  8:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-17  8:48 Tobin C. Harding [this message]
2020-02-17  8:48 ` [PATCH 1/2] tools: vm: slabinfo: Replace tabs with spaces Tobin C. Harding
2020-02-18 16:19   ` Christopher Lameter
2020-02-18 16:19     ` Christopher Lameter
2020-02-17  8:48 ` [PATCH 2/2] tools: vm: slabinfo: Add numa information for objects Tobin C. Harding
2020-02-18 16:24   ` Christopher Lameter
2020-02-18 16:24     ` Christopher Lameter
2020-02-19 20:26     ` Tobin C. Harding
2020-02-18 16:16 ` [PATCH 0/2] slabinfo: parse all NUMA attributes Christopher Lameter
2020-02-18 16:16   ` Christopher Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200217084828.9092-1-tobin@kernel.org \
    --to=tobin@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.