From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Ján Tomko" <jtomko@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: [PATCH v2 1/3] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment
Date: Mon, 17 Feb 2020 10:42:38 +0100 [thread overview]
Message-ID: <20200217094240.9927-2-philmd@redhat.com> (raw)
In-Reply-To: <20200217094240.9927-1-philmd@redhat.com>
Fix warning reported by Clang static code analyzer:
CC tools/virtiofsd/passthrough_ll.o
tools/virtiofsd/passthrough_ll.c:1083:5: warning: Value stored to 'saverr' is never read
saverr = ENOMEM;
^ ~~~~~~
Fixes: 7c6b66027
Reported-by: Clang Static Analyzer
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
tools/virtiofsd/passthrough_ll.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
index c635fc8820..e9e71d5fc2 100644
--- a/tools/virtiofsd/passthrough_ll.c
+++ b/tools/virtiofsd/passthrough_ll.c
@@ -1080,8 +1080,6 @@ static void lo_mknod_symlink(fuse_req_t req, fuse_ino_t parent,
return;
}
- saverr = ENOMEM;
-
saverr = lo_change_cred(req, &old);
if (saverr) {
goto out;
--
2.21.1
next prev parent reply other threads:[~2020-02-17 9:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 9:42 [PATCH v2 0/3] tools/virtiofsd: Fix warning reported by Clang static code analyzer Philippe Mathieu-Daudé
2020-02-17 9:42 ` Philippe Mathieu-Daudé [this message]
2020-02-17 11:37 ` [PATCH v2 1/3] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment Dr. David Alan Gilbert
2020-02-17 14:12 ` Philippe Mathieu-Daudé
2020-02-17 9:42 ` [PATCH v2 2/3] " Philippe Mathieu-Daudé
2020-02-17 11:42 ` Ján Tomko
2020-02-17 12:07 ` Dr. David Alan Gilbert
2020-02-17 9:42 ` [RFC PATCH v2 3/3] tools/virtiofsd/fuse_lowlevel: Fix fuse_out_header::error value Philippe Mathieu-Daudé
2020-02-17 20:06 ` Dr. David Alan Gilbert
2020-02-18 6:07 ` Philippe Mathieu-Daudé
2020-02-18 9:51 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217094240.9927-2-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jtomko@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.