From: Nirmoy Das <nirmoy.aiemd@gmail.com> To: dri-devel@lists.freedesktop.org Cc: thellstrom@vmware.com, airlied@linux.ie, kenny.ho@amd.com, brian.welty@intel.com, amd-gfx@lists.freedesktop.org, nirmoy.das@amd.com, linux-graphics-maintainer@vmware.com, bskeggs@redhat.com, alexander.deucher@amd.com, sean@poorly.run, christian.koenig@amd.com, kraxel@redhat.com Subject: [PATCH 8/8] drm/ttm: do not keep GPU dependent addresses Date: Wed, 19 Feb 2020 14:53:22 +0100 [thread overview] Message-ID: <20200219135322.56463-9-nirmoy.das@amd.com> (raw) In-Reply-To: <20200219135322.56463-1-nirmoy.das@amd.com> GPU address handling is device specific and should be handle by its device driver. Signed-off-by: Nirmoy Das <nirmoy.das@amd.com> --- drivers/gpu/drm/ttm/ttm_bo.c | 7 ------- include/drm/ttm/ttm_bo_api.h | 2 -- include/drm/ttm/ttm_bo_driver.h | 1 - 3 files changed, 10 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 151edfd8de77..d5885cd609a3 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -85,7 +85,6 @@ static void ttm_mem_type_debug(struct ttm_bo_device *bdev, struct drm_printer *p drm_printf(p, " has_type: %d\n", man->has_type); drm_printf(p, " use_type: %d\n", man->use_type); drm_printf(p, " flags: 0x%08X\n", man->flags); - drm_printf(p, " gpu_offset: 0x%08llX\n", man->gpu_offset); drm_printf(p, " size: %llu\n", man->size); drm_printf(p, " available_caching: 0x%08X\n", man->available_caching); drm_printf(p, " default_caching: 0x%08X\n", man->default_caching); @@ -345,12 +344,6 @@ static int ttm_bo_handle_move_mem(struct ttm_buffer_object *bo, moved: bo->evicted = false; - if (bo->mem.mm_node) - bo->offset = (bo->mem.start << PAGE_SHIFT) + - bdev->man[bo->mem.mem_type].gpu_offset; - else - bo->offset = 0; - ctx->bytes_moved += bo->num_pages << PAGE_SHIFT; return 0; diff --git a/include/drm/ttm/ttm_bo_api.h b/include/drm/ttm/ttm_bo_api.h index b9bc1b00142e..d6f39ee5bf5d 100644 --- a/include/drm/ttm/ttm_bo_api.h +++ b/include/drm/ttm/ttm_bo_api.h @@ -213,8 +213,6 @@ struct ttm_buffer_object { * either of these locks held. */ - uint64_t offset; /* GPU address space is independent of CPU word size */ - struct sg_table *sg; }; diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h index c9e0fd09f4b2..c8ce6c181abe 100644 --- a/include/drm/ttm/ttm_bo_driver.h +++ b/include/drm/ttm/ttm_bo_driver.h @@ -177,7 +177,6 @@ struct ttm_mem_type_manager { bool has_type; bool use_type; uint32_t flags; - uint64_t gpu_offset; /* GPU address space is independent of CPU word size */ uint64_t size; uint32_t available_caching; uint32_t default_caching; -- 2.25.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Nirmoy Das <nirmoy.aiemd@gmail.com> To: dri-devel@lists.freedesktop.org Cc: David1.Zhou@amd.com, thellstrom@vmware.com, airlied@linux.ie, kenny.ho@amd.com, brian.welty@intel.com, maarten.lankhorst@linux.intel.com, amd-gfx@lists.freedesktop.org, nirmoy.das@amd.com, linux-graphics-maintainer@vmware.com, bskeggs@redhat.com, daniel@ffwll.ch, alexander.deucher@amd.com, sean@poorly.run, christian.koenig@amd.com, kraxel@redhat.com Subject: [PATCH 8/8] drm/ttm: do not keep GPU dependent addresses Date: Wed, 19 Feb 2020 14:53:22 +0100 [thread overview] Message-ID: <20200219135322.56463-9-nirmoy.das@amd.com> (raw) In-Reply-To: <20200219135322.56463-1-nirmoy.das@amd.com> GPU address handling is device specific and should be handle by its device driver. Signed-off-by: Nirmoy Das <nirmoy.das@amd.com> --- drivers/gpu/drm/ttm/ttm_bo.c | 7 ------- include/drm/ttm/ttm_bo_api.h | 2 -- include/drm/ttm/ttm_bo_driver.h | 1 - 3 files changed, 10 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 151edfd8de77..d5885cd609a3 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -85,7 +85,6 @@ static void ttm_mem_type_debug(struct ttm_bo_device *bdev, struct drm_printer *p drm_printf(p, " has_type: %d\n", man->has_type); drm_printf(p, " use_type: %d\n", man->use_type); drm_printf(p, " flags: 0x%08X\n", man->flags); - drm_printf(p, " gpu_offset: 0x%08llX\n", man->gpu_offset); drm_printf(p, " size: %llu\n", man->size); drm_printf(p, " available_caching: 0x%08X\n", man->available_caching); drm_printf(p, " default_caching: 0x%08X\n", man->default_caching); @@ -345,12 +344,6 @@ static int ttm_bo_handle_move_mem(struct ttm_buffer_object *bo, moved: bo->evicted = false; - if (bo->mem.mm_node) - bo->offset = (bo->mem.start << PAGE_SHIFT) + - bdev->man[bo->mem.mem_type].gpu_offset; - else - bo->offset = 0; - ctx->bytes_moved += bo->num_pages << PAGE_SHIFT; return 0; diff --git a/include/drm/ttm/ttm_bo_api.h b/include/drm/ttm/ttm_bo_api.h index b9bc1b00142e..d6f39ee5bf5d 100644 --- a/include/drm/ttm/ttm_bo_api.h +++ b/include/drm/ttm/ttm_bo_api.h @@ -213,8 +213,6 @@ struct ttm_buffer_object { * either of these locks held. */ - uint64_t offset; /* GPU address space is independent of CPU word size */ - struct sg_table *sg; }; diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h index c9e0fd09f4b2..c8ce6c181abe 100644 --- a/include/drm/ttm/ttm_bo_driver.h +++ b/include/drm/ttm/ttm_bo_driver.h @@ -177,7 +177,6 @@ struct ttm_mem_type_manager { bool has_type; bool use_type; uint32_t flags; - uint64_t gpu_offset; /* GPU address space is independent of CPU word size */ uint64_t size; uint32_t available_caching; uint32_t default_caching; -- 2.25.0 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-02-19 16:18 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-19 13:53 [PATCH v3 0/8] do not store GPU address in TTM Nirmoy Das 2020-02-19 13:53 ` Nirmoy Das 2020-02-19 13:53 ` [PATCH 1/8] drm/amdgpu: move ttm bo->offset to amdgpu_bo Nirmoy Das 2020-02-19 13:53 ` Nirmoy Das 2020-02-21 1:14 ` Luben Tuikov 2020-02-21 1:14 ` Luben Tuikov 2020-02-19 13:53 ` [PATCH 2/8] drm/radeon: don't use ttm bo->offset Nirmoy Das 2020-02-19 13:53 ` Nirmoy Das 2020-02-21 1:19 ` Luben Tuikov 2020-02-21 1:19 ` Luben Tuikov 2020-02-21 13:27 ` Nirmoy 2020-02-19 13:53 ` [PATCH 3/8] drm/vmwgfx: " Nirmoy Das 2020-02-19 13:53 ` Nirmoy Das 2020-02-21 8:45 ` Thomas Hellström (VMware) 2020-02-21 8:45 ` Thomas Hellström (VMware) 2020-02-19 13:53 ` [PATCH 4/8] drm/nouveau: don't use ttm bo->offset v3 Nirmoy Das 2020-02-19 13:53 ` Nirmoy Das 2020-02-21 1:22 ` Luben Tuikov 2020-02-21 1:22 ` Luben Tuikov 2020-02-19 13:53 ` [PATCH 5/8] drm/qxl: don't use ttm bo->offset Nirmoy Das 2020-02-19 13:53 ` Nirmoy Das 2020-02-19 13:53 ` [PATCH 6/8] drm/vram-helper: don't use ttm bo->offset v2 Nirmoy Das 2020-02-19 13:53 ` Nirmoy Das 2020-02-20 18:09 ` Daniel Vetter 2020-02-20 18:09 ` Daniel Vetter 2020-02-20 18:29 ` Nirmoy 2020-02-20 18:29 ` Nirmoy 2020-02-21 11:02 ` Thomas Zimmermann 2020-02-21 11:02 ` Thomas Zimmermann 2020-02-19 13:53 ` [PATCH 7/8] drm/bochs: use drm_gem_vram_offset to get bo offset v2 Nirmoy Das 2020-02-19 13:53 ` Nirmoy Das 2020-02-20 18:11 ` Daniel Vetter 2020-02-20 18:11 ` Daniel Vetter 2020-02-19 13:53 ` Nirmoy Das [this message] 2020-02-19 13:53 ` [PATCH 8/8] drm/ttm: do not keep GPU dependent addresses Nirmoy Das 2020-02-21 8:48 ` [PATCH v3 0/8] do not store GPU address in TTM Thomas Hellström (VMware) 2020-02-21 8:48 ` Thomas Hellström (VMware) 2020-02-21 11:32 ` Nirmoy -- strict thread matches above, loose matches on Subject: below -- 2020-06-24 18:26 [RESEND] [PATCH v6 " Nirmoy Das 2020-06-24 18:26 ` [PATCH 8/8] drm/ttm: do not keep GPU dependent addresses Nirmoy Das 2020-04-01 18:42 [PATCH v5 0/8] do not store GPU address in TTM Nirmoy Das 2020-04-01 18:42 ` [PATCH 8/8] drm/ttm: do not keep GPU dependent addresses Nirmoy Das 2020-03-05 13:29 [PATCH v4 0/8] do not store GPU address in TTM Nirmoy Das 2020-03-05 13:29 ` [PATCH 8/8] drm/ttm: do not keep GPU dependent addresses Nirmoy Das 2020-03-05 13:29 ` Nirmoy Das 2020-03-05 13:34 ` Christian König 2020-03-05 13:34 ` Christian König 2020-02-17 15:04 [PATCH 0/8] do not store GPU address in TTM Nirmoy Das 2020-02-17 15:04 ` [PATCH 8/8] drm/ttm: do not keep GPU dependent addresses Nirmoy Das 2020-02-17 15:04 ` Nirmoy Das 2020-02-18 12:40 ` Thomas Zimmermann 2020-02-18 12:40 ` Thomas Zimmermann 2020-02-18 12:44 ` Christian König 2020-02-18 12:44 ` Christian König [not found] ` <9db59846-90b4-2b9a-8200-69297112693a-5C7GfCeVMHo@public.gmane.org> 2020-02-18 17:13 ` Nirmoy 2020-02-18 17:13 ` Nirmoy 2020-02-18 17:13 ` Nirmoy [not found] ` <edc985f1-8856-4d1a-8960-efe4d21b960d-5C7GfCeVMHo@public.gmane.org> 2020-02-18 17:23 ` Christian König 2020-02-18 17:23 ` Christian König 2020-02-18 17:23 ` Christian König 2020-02-18 18:16 ` Thomas Zimmermann 2020-02-18 18:16 ` Thomas Zimmermann 2020-02-18 18:16 ` Thomas Zimmermann [not found] ` <5b8db944-5a55-8161-6ab6-98490cfb0562-l3A5Bk7waGM@public.gmane.org> 2020-02-18 18:23 ` Christian König 2020-02-18 18:23 ` Christian König 2020-02-18 18:23 ` Christian König [not found] ` <f8534965-ea14-bbac-bd34-06b951766a7c-5C7GfCeVMHo@public.gmane.org> 2020-02-18 18:28 ` Thomas Zimmermann 2020-02-18 18:28 ` Thomas Zimmermann 2020-02-18 18:28 ` Thomas Zimmermann [not found] ` <48a5e3e2-cb9d-8328-1529-3558601ba860-l3A5Bk7waGM@public.gmane.org> 2020-02-18 18:37 ` Christian König 2020-02-18 18:37 ` Christian König 2020-02-18 18:37 ` Christian König [not found] ` <31b0cac7-82c7-60ad-830b-66f7838a1047-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-02-18 19:06 ` Daniel Vetter 2020-02-18 18:30 ` Nirmoy 2020-02-18 18:30 ` Nirmoy 2020-02-18 18:30 ` Nirmoy 2020-02-24 8:04 ` Gerd Hoffmann 2020-02-24 8:04 ` Gerd Hoffmann 2020-02-24 8:04 ` Gerd Hoffmann 2020-02-24 9:59 ` Nirmoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200219135322.56463-9-nirmoy.das@amd.com \ --to=nirmoy.aiemd@gmail.com \ --cc=airlied@linux.ie \ --cc=alexander.deucher@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=brian.welty@intel.com \ --cc=bskeggs@redhat.com \ --cc=christian.koenig@amd.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=kenny.ho@amd.com \ --cc=kraxel@redhat.com \ --cc=linux-graphics-maintainer@vmware.com \ --cc=nirmoy.das@amd.com \ --cc=sean@poorly.run \ --cc=thellstrom@vmware.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.