[Xen-devel] [PATCH] xen/sched: don't disable interrupts all the time when dumping run-queues

From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	George Dunlap <george.dunlap@eu.citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>
Subject: [Xen-devel] [PATCH] xen/sched: don't disable interrupts all the time when dumping run-queues
Date: Wed, 19 Feb 2020 16:33:00 +0100	[thread overview]
Message-ID: <20200219153300.10679-1-jgross@suse.com> (raw)

Having interrupts disabled all the time when running dump_runq() is
not necessary. All the called functions are doing proper locking
and disable interrupts if needed.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/common/sched/cpupool.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index 476916c6ea..b7721b5d02 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -889,12 +889,10 @@ const cpumask_t *cpupool_valid_cpus(const struct cpupool *pool)
 
 void dump_runq(unsigned char key)
 {
-    unsigned long    flags;
     s_time_t         now = NOW();
     struct cpupool **c;
 
     spin_lock(&cpupool_lock);
-    local_irq_save(flags);
 
     printk("sched_smt_power_savings: %s\n",
             sched_smt_power_savings? "enabled":"disabled");
@@ -914,7 +912,6 @@ void dump_runq(unsigned char key)
         schedule_dump(*c);
     }
 
-    local_irq_restore(flags);
     spin_unlock(&cpupool_lock);
 }
 
-- 
2.16.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
