From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org
Cc: lvivier@redhat.com, aik@ozlabs.ru, qemu-devel@nongnu.org,
groug@kaod.org, qemu-ppc@nongnu.org, clg@kaod.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: [PULL 10/20] pnv/phb3: Convert 1u to 1ull
Date: Fri, 21 Feb 2020 14:36:40 +1100 [thread overview]
Message-ID: <20200221033650.444386-11-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20200221033650.444386-1-david@gibson.dropbear.id.au>
From: Greg Kurz <groug@kaod.org>
As reported by Coverity defect CID 1419397, the 'j' variable goes up to
63 and shouldn't be used to left shift a 32-bit integer.
The result of the operation goes to a 64-bit integer : use a 64-bit
constant.
Reported-by: Coverity CID 1419397 Bad bit shift operation
Fixes: 9ae1329ee2fe "ppc/pnv: Add models for POWER8 PHB3 PCIe Host bridge"
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <158153364010.3229002.8004283672455615950.stgit@bahia.lan>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/pci-host/pnv_phb3_msi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci-host/pnv_phb3_msi.c b/hw/pci-host/pnv_phb3_msi.c
index ecfc1b2c4e..d645468f4a 100644
--- a/hw/pci-host/pnv_phb3_msi.c
+++ b/hw/pci-host/pnv_phb3_msi.c
@@ -220,7 +220,7 @@ static void phb3_msi_resend(ICSState *ics)
if ((msi->rba[i] & (1ull << j)) == 0) {
continue;
}
- msi->rba[i] &= ~(1u << j);
+ msi->rba[i] &= ~(1ull << j);
phb3_msi_try_send(msi, i * 64 + j, true);
}
}
--
2.24.1
next prev parent reply other threads:[~2020-02-21 3:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 3:36 [PULL 00/20] ppc-for-5.0 queue 20200221 David Gibson
2020-02-21 3:36 ` [PULL 01/20] spapr/rtas: Print message from "ibm,os-term" David Gibson
2020-02-21 3:36 ` [PULL 02/20] qtest: Fix rtas dependencies David Gibson
2020-02-21 3:36 ` [PULL 03/20] ppc/pnv: Fix PCI_EXPRESS dependency David Gibson
2020-02-21 3:36 ` [PULL 04/20] ppc: function to setup latest class options David Gibson
2020-02-21 3:36 ` [PULL 05/20] mem: move nvdimm_device_list to utilities David Gibson
2020-04-03 12:34 ` Peter Maydell
2020-02-21 3:36 ` [PULL 06/20] nvdimm: add uuid property to nvdimm David Gibson
2020-02-21 3:36 ` [PULL 07/20] spapr: Add NVDIMM device support David Gibson
2020-02-25 10:00 ` Peter Maydell
2020-02-26 12:13 ` Shivaprasad G Bhat
2020-02-21 3:36 ` [PULL 08/20] spapr: Add Hcalls to support PAPR NVDIMM device David Gibson
2020-02-21 3:36 ` [PULL 09/20] target/ppc/cpu.h: Remove duplicate includes David Gibson
2020-02-21 3:36 ` David Gibson [this message]
2020-02-21 3:36 ` [PULL 11/20] pnv/phb4: Fix error path in pnv_pec_realize() David Gibson
2020-02-21 3:36 ` [PULL 12/20] pnv/phb3: Add missing break statement David Gibson
2020-02-21 3:36 ` [PULL 13/20] spapr: Allow changing offset for -kernel image David Gibson
2020-02-21 3:36 ` [PULL 14/20] target/ppc: Fix typo in comments David Gibson
2020-02-21 3:36 ` [PULL 15/20] target/ppc/cpu.h: Move fpu related members closer in cpu env David Gibson
2020-02-21 3:36 ` [PULL 16/20] target/ppc/cpu.h: Clean up comments in the struct CPUPPCState definition David Gibson
2020-02-21 3:36 ` [PULL 17/20] ppc: free 'fdt' after reset the machine David Gibson
2020-02-21 3:36 ` [PULL 18/20] spapr: Don't use spapr_drc_needed() in CAS code David Gibson
2020-02-21 3:36 ` [PULL 19/20] spapr: Fix handling of unplugged devices during CAS and migration David Gibson
2020-02-21 3:36 ` [PULL 20/20] hw/ppc/virtex_ml507:fix leak of fdevice tree blob David Gibson
2020-02-21 15:18 ` [PULL 00/20] ppc-for-5.0 queue 20200221 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221033650.444386-11-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=aik@ozlabs.ru \
--cc=clg@kaod.org \
--cc=groug@kaod.org \
--cc=lvivier@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.