All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: qemu-devel@nongnu.org
Cc: philmd@redhat.com,
	Richard Henderson <richard.henderson@linaro.org>,
	Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: [PATCH RESEND v31 13/22] target/rx: Dump bytes for each insn during disassembly
Date: Sun, 23 Feb 2020 22:27:40 +0900	[thread overview]
Message-ID: <20200223132750.69480-14-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <20200223132750.69480-1-ysato@users.sourceforge.jp>

From: Richard Henderson <richard.henderson@linaro.org>

There are so many different forms of each RX instruction
that it will be very useful to be able to look at the bytes
to see on which path a bug may lie.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Message-Id: <20190607091116.49044-24-ysato@users.sourceforge.jp>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/rx/disas.c | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/target/rx/disas.c b/target/rx/disas.c
index 5a32a87534..d73b53db44 100644
--- a/target/rx/disas.c
+++ b/target/rx/disas.c
@@ -102,7 +102,21 @@ static int bdsp_s(DisasContext *ctx, int d)
 /* Include the auto-generated decoder.  */
 #include "decode.inc.c"
 
-#define prt(...) (ctx->dis->fprintf_func)((ctx->dis->stream), __VA_ARGS__)
+static void dump_bytes(DisasContext *ctx)
+{
+    int i, len = ctx->len;
+
+    for (i = 0; i < len; ++i) {
+        ctx->dis->fprintf_func(ctx->dis->stream, "%02x ", ctx->bytes[i]);
+    }
+    ctx->dis->fprintf_func(ctx->dis->stream, "%*c", (8 - i) * 3, '\t');
+}
+
+#define prt(...) \
+    do {                                                        \
+        dump_bytes(ctx);                                        \
+        ctx->dis->fprintf_func(ctx->dis->stream, __VA_ARGS__);  \
+    } while (0)
 
 #define RX_MEMORY_BYTE 0
 #define RX_MEMORY_WORD 1
-- 
2.20.1



  parent reply	other threads:[~2020-02-23 13:34 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-23 13:27 [PATCH RESEND v31 00/22] Add RX archtecture support Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 01/22] MAINTAINERS: Add RX Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 02/22] qemu/bitops.h: Add extract8 and extract16 Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 03/22] hw/registerfields.h: Add 8bit and 16bit register macros Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 04/22] target/rx: TCG translation Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 05/22] target/rx: TCG helper Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 06/22] target/rx: CPU definition Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 07/22] target/rx: RX disassembler Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 08/22] target/rx: Disassemble rx_index_addr into a string Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 09/22] target/rx: Replace operand with prt_ldmi in disassembler Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 10/22] target/rx: Use prt_ldmi for XCHG_mr disassembly Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 11/22] target/rx: Emit all disassembly in one prt() Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 12/22] target/rx: Collect all bytes during disassembly Yoshinori Sato
2020-02-23 13:27 ` Yoshinori Sato [this message]
2020-02-23 13:27 ` [PATCH RESEND v31 14/22] hw/intc: RX62N interrupt controller (ICUa) Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 15/22] hw/timer: RX62N internal timer modules Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 16/22] hw/char: RX62N serial communication interface (SCI) Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 17/22] hw/rx: RX Target hardware definition Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 18/22] hw/rx: Honor -accel qtest Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 19/22] hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 20/22] Add rx-softmmu Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 21/22] BootLinuxConsoleTest: Test the RX-Virt machine Yoshinori Sato
2020-02-23 13:27 ` [PATCH RESEND v31 22/22] qemu-doc.texi: Add RX section Yoshinori Sato
2020-02-23 13:27 ` [PATCH v31 23/23] fix warning Yoshinori Sato
2020-02-24  8:51   ` Philippe Mathieu-Daudé
2020-02-24 13:56     ` Yoshinori Sato
2020-02-24 14:00       ` Philippe Mathieu-Daudé
2020-02-24 14:28   ` Peter Maydell
2020-02-24 15:02     ` Yoshinori Sato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200223132750.69480-14-ysato@users.sourceforge.jp \
    --to=ysato@users.sourceforge.jp \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.