All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Matthew Auld <matthew.auld@intel.com>
Subject: [Intel-gfx] [PATCH 11/11] drm/i915/gem: Check that the context wasn't closed during setup
Date: Tue, 25 Feb 2020 08:22:33 +0000	[thread overview]
Message-ID: <20200225082233.274530-11-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20200225082233.274530-1-chris@chris-wilson.co.uk>

As setup takes a long time, the user may close the context during the
construction of the execbuf. In order to make sure we correctly track
all outstanding work with non-persistent contexts, we need to serialise
the submission with the context closure and mop up any leaks.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index 4f9c1f5a4ded..a33c466472b3 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -2729,6 +2729,12 @@ i915_gem_do_execbuffer(struct drm_device *dev,
 		goto err_batch_unpin;
 	}
 
+	/* Check that the context wasn't destroyed before setup */
+	if (!rcu_access_pointer(eb.context->gem_context)) {
+		err = -ENOENT;
+		goto err_request;
+	}
+
 	if (in_fence) {
 		err = i915_request_await_dma_fence(eb.request, in_fence);
 		if (err < 0)
-- 
2.25.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2020-02-25  8:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-25  8:22 [Intel-gfx] [PATCH 01/11] drm/i915: Drop assertion that active->fence is unchanged Chris Wilson
2020-02-25  8:22 ` [Intel-gfx] [PATCH 02/11] drm/i915: Manually acquire engine-wakeref around use of kernel_context Chris Wilson
2020-02-25  8:22 ` [Intel-gfx] [PATCH 03/11] drm/i915/gt: Pull marking vm as closed underneath the vm->mutex Chris Wilson
2020-02-25  8:22 ` [Intel-gfx] [PATCH 04/11] drm/i915/gem: Cleanup shadow batch after I915_EXEC_SECURE Chris Wilson
2020-02-25 11:15   ` Matthew Auld
2020-02-25  8:22 ` [Intel-gfx] [PATCH 05/11] drm/i915: Protect i915_request_await_start from early waits Chris Wilson
2020-02-25  9:26   ` [Intel-gfx] [PATCH] " Chris Wilson
2020-02-25  8:22 ` [Intel-gfx] [PATCH 06/11] drm/i915/selftests: Verify LRC isolation Chris Wilson
2020-02-25  8:22 ` [Intel-gfx] [PATCH 07/11] drm/i915/selftests: Check recovery from corrupted LRC Chris Wilson
2020-02-25 18:00   ` Matthew Auld
2020-02-25  8:22 ` [Intel-gfx] [PATCH 08/11] drm/i915/selftests: Be a little more lenient for reset workers Chris Wilson
2020-02-25  8:22 ` [Intel-gfx] [PATCH 09/11] drm/i915/gem: Consolidate ctx->engines[] release Chris Wilson
2020-02-26 16:41   ` Tvrtko Ursulin
2020-02-26 17:06     ` Chris Wilson
2020-02-25  8:22 ` [Intel-gfx] [PATCH 10/11] drm/i915/gt: Prevent allocation on a banned context Chris Wilson
2020-02-25  8:22 ` Chris Wilson [this message]
2020-02-25  8:31 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/11] drm/i915: Drop assertion that active->fence is unchanged Patchwork
2020-02-25  8:57 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-02-25  9:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/11] drm/i915: Drop assertion that active->fence is unchanged (rev2) Patchwork
2020-02-25 10:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-02-25 11:23 ` [Intel-gfx] [PATCH 01/11] drm/i915: Drop assertion that active->fence is unchanged Matthew Auld
2020-02-26 13:22 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [01/11] drm/i915: Drop assertion that active->fence is unchanged (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200225082233.274530-11-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.