All of lore.kernel.org
 help / color / mirror / Atom feed
From: Balbir Singh <sblbir@amazon.com>
To: <linux-kernel@vger.kernel.org>, <linux-block@vger.kernel.org>,
	<linux-nvme@lists.infradead.org>
Cc: <axboe@kernel.dk>, <Chaitanya.Kulkarni@wdc.com>, <mst@redhat.com>,
	<jejb@linux.ibm.com>, <hch@lst.de>,
	Balbir Singh <sblbir@amazon.com>
Subject: [PATCH v2 2/5] drivers/block/virtio_blk.c: Convert to use set_capacity_revalidate_and_notify
Date: Tue, 25 Feb 2020 20:01:26 +0000	[thread overview]
Message-ID: <20200225200129.6687-3-sblbir@amazon.com> (raw)
In-Reply-To: <20200225200129.6687-1-sblbir@amazon.com>

block/genhd provides set_capacity_revalidate_and_notify() for sending RESIZE
notifications via uevents.

Signed-off-by: Balbir Singh <sblbir@amazon.com>
---
 drivers/block/virtio_blk.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index 54158766334b..c913ebb25a52 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -381,18 +381,15 @@ static void virtblk_update_capacity(struct virtio_blk *vblk, bool resize)
 		   cap_str_10,
 		   cap_str_2);
 
-	set_capacity(vblk->disk, capacity);
+	set_capacity_revalidate_and_notify(vblk->disk, capacity, true);
 }
 
 static void virtblk_config_changed_work(struct work_struct *work)
 {
 	struct virtio_blk *vblk =
 		container_of(work, struct virtio_blk, config_work);
-	char *envp[] = { "RESIZE=1", NULL };
 
 	virtblk_update_capacity(vblk, true);
-	revalidate_disk(vblk->disk);
-	kobject_uevent_env(&disk_to_dev(vblk->disk)->kobj, KOBJ_CHANGE, envp);
 }
 
 static void virtblk_config_changed(struct virtio_device *vdev)
-- 
2.16.6


WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <sblbir@amazon.com>
To: <linux-kernel@vger.kernel.org>, <linux-block@vger.kernel.org>,
	<linux-nvme@lists.infradead.org>
Cc: axboe@kernel.dk, Chaitanya.Kulkarni@wdc.com, mst@redhat.com,
	jejb@linux.ibm.com, Balbir Singh <sblbir@amazon.com>,
	hch@lst.de
Subject: [PATCH v2 2/5] drivers/block/virtio_blk.c: Convert to use set_capacity_revalidate_and_notify
Date: Tue, 25 Feb 2020 20:01:26 +0000	[thread overview]
Message-ID: <20200225200129.6687-3-sblbir@amazon.com> (raw)
In-Reply-To: <20200225200129.6687-1-sblbir@amazon.com>

block/genhd provides set_capacity_revalidate_and_notify() for sending RESIZE
notifications via uevents.

Signed-off-by: Balbir Singh <sblbir@amazon.com>
---
 drivers/block/virtio_blk.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index 54158766334b..c913ebb25a52 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -381,18 +381,15 @@ static void virtblk_update_capacity(struct virtio_blk *vblk, bool resize)
 		   cap_str_10,
 		   cap_str_2);
 
-	set_capacity(vblk->disk, capacity);
+	set_capacity_revalidate_and_notify(vblk->disk, capacity, true);
 }
 
 static void virtblk_config_changed_work(struct work_struct *work)
 {
 	struct virtio_blk *vblk =
 		container_of(work, struct virtio_blk, config_work);
-	char *envp[] = { "RESIZE=1", NULL };
 
 	virtblk_update_capacity(vblk, true);
-	revalidate_disk(vblk->disk);
-	kobject_uevent_env(&disk_to_dev(vblk->disk)->kobj, KOBJ_CHANGE, envp);
 }
 
 static void virtblk_config_changed(struct virtio_device *vdev)
-- 
2.16.6


_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  parent reply	other threads:[~2020-02-25 20:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-25 20:01 [PATCH v2 0/5] Add support for block disk resize notification Balbir Singh
2020-02-25 20:01 ` Balbir Singh
2020-02-25 20:01 ` [PATCH v2 1/5] block/genhd: Notify udev about capacity change Balbir Singh
2020-02-25 20:01   ` Balbir Singh
2020-02-25 20:01 ` Balbir Singh [this message]
2020-02-25 20:01   ` [PATCH v2 2/5] drivers/block/virtio_blk.c: Convert to use set_capacity_revalidate_and_notify Balbir Singh
2020-02-25 20:01 ` [PATCH v2 3/5] drivers/block/xen-blkfront.c: " Balbir Singh
2020-02-25 20:01   ` Balbir Singh
2020-02-25 20:01 ` [PATCH v2 4/5] drivers/nvme/host/core.c: " Balbir Singh
2020-02-25 20:01   ` Balbir Singh
2020-02-25 20:24   ` Sagi Grimberg
2020-02-25 20:24     ` Sagi Grimberg
2020-02-26 18:08   ` Keith Busch
2020-02-26 18:08     ` Keith Busch
2020-02-27 22:31     ` Singh, Balbir
2020-02-27 22:31       ` Singh, Balbir
2020-02-25 20:01 ` [PATCH v2 5/5] drivers/scsi/sd.c: " Balbir Singh
2020-02-25 20:01   ` Balbir Singh
2020-03-03  4:03 ` [PATCH v2 0/5] Add support for block disk resize notification Singh, Balbir
2020-03-03  4:03   ` Singh, Balbir
2020-03-12 14:06   ` Jens Axboe
2020-03-12 14:06     ` Jens Axboe
2020-03-12 22:51     ` Singh, Balbir
2020-03-12 22:51       ` Singh, Balbir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200225200129.6687-3-sblbir@amazon.com \
    --to=sblbir@amazon.com \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=jejb@linux.ibm.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mst@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.