From: Gurchetan Singh <gurchetansingh@chromium.org>
To: dri-devel@lists.freedesktop.org
Cc: Gurchetan Singh <gurchetansingh@chromium.org>,
kraxel@redhat.com, jbates@chromium.org
Subject: [RFC PATCH 0/8] *** Refactor struct virtgpu_object ***
Date: Wed, 26 Feb 2020 16:25:53 -0800 [thread overview]
Message-ID: <20200227002601.745-1-gurchetansingh@chromium.org> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 1571 bytes --]
The main motivation behind this is to have eventually have something like this:
struct virtio_gpu_shmem {
struct drm_gem_shmem_object base;
uint32_t hw_res_handle;
struct sg_table *pages;
(...)
};
struct virtio_gpu_vram {
struct drm_gem_object base; // or *drm_gem_vram_object
uint32_t hw_res_handle;
{offset, range};
(...)
};
Sending this out to solicit feedback on this approach. Whichever approach
we decide, landing incremental changes to internal structures is reduces
rebasing costs and avoids mega-changes.
Gurchetan Singh (8):
drm/virtio: make mmap callback consistent with callbacks
drm/virtio: add virtio_gpu_is_shmem helper
drm/virtio: add virtio_gpu_get_handle function
drm/virtio: make RESOURCE_UNREF use virtio_gpu_get_handle(..)
drm/virtio: make {ATTACH_RESOURCE, DETACH_RESOURCE} use
virtio_gpu_get_handle(..)
drm/virtio: rename virtio_gpu_object_array to virtio_gpu_gem_array
drm/virtio: rename virtio_gpu_object_params to
virtio_gpu_create_params
drm/virtio: rename virtio_gpu_object to virtio_gpu_shmem
drivers/gpu/drm/virtio/virtgpu_drv.h | 72 ++++++------
drivers/gpu/drm/virtio/virtgpu_gem.c | 132 ++++++++++-----------
drivers/gpu/drm/virtio/virtgpu_ioctl.c | 50 ++++----
drivers/gpu/drm/virtio/virtgpu_object.c | 148 +++++++++++++-----------
drivers/gpu/drm/virtio/virtgpu_plane.c | 52 ++++-----
drivers/gpu/drm/virtio/virtgpu_vq.c | 113 +++++++++---------
6 files changed, 298 insertions(+), 269 deletions(-)
--
2.25.1.481.gfbce0eb801-goog
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2020-02-27 0:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 0:25 Gurchetan Singh [this message]
2020-02-27 0:25 ` [RFC PATCH 1/8] drm/virtio: make mmap callback consistent with callbacks Gurchetan Singh
2020-02-27 0:25 ` [RFC PATCH 2/8] drm/virtio: add virtio_gpu_is_shmem helper Gurchetan Singh
2020-02-27 0:25 ` [RFC PATCH 3/8] drm/virtio: add virtio_gpu_get_handle function Gurchetan Singh
2020-02-27 0:25 ` [RFC PATCH 4/8] drm/virtio: make RESOURCE_UNREF use virtio_gpu_get_handle(..) Gurchetan Singh
2020-02-27 0:25 ` [RFC PATCH 5/8] drm/virtio: make {ATTACH_RESOURCE, DETACH_RESOURCE} " Gurchetan Singh
2020-02-27 0:25 ` [RFC PATCH 6/8] drm/virtio: rename virtio_gpu_object_array to virtio_gpu_gem_array Gurchetan Singh
2020-02-27 0:26 ` [RFC PATCH 7/8] drm/virtio: rename virtio_gpu_object_params to virtio_gpu_create_params Gurchetan Singh
2020-02-27 0:26 ` [RFC PATCH 8/8] drm/virtio: rename virtio_gpu_object to virtio_gpu_shmem Gurchetan Singh
2020-02-27 7:23 ` [RFC PATCH 0/8] *** Refactor struct virtgpu_object *** Gerd Hoffmann
2020-02-28 2:03 ` Gurchetan Singh
2020-02-28 10:28 ` Gerd Hoffmann
2020-02-27 10:59 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227002601.745-1-gurchetansingh@chromium.org \
--to=gurchetansingh@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jbates@chromium.org \
--cc=kraxel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.