From: Marco Felsch <m.felsch@pengutronix.de> To: p.zabel@pengutronix.de, airlied@linux.ie, daniel@ffwll.ch, shawnguo@kernel.org, stefan@agner.ch, rmk+kernel@armlinux.org.uk Cc: kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: [PATCH 14/17] drm/imx: imx-ldb: add ldb_is_dual helper Date: Thu, 27 Feb 2020 17:21:22 +0100 [thread overview] Message-ID: <20200227162125.10450-15-m.felsch@pengutronix.de> (raw) In-Reply-To: <20200227162125.10450-1-m.felsch@pengutronix.de> There where several places where this bit operation is made. Add a simple helper so we don't need to remember the bit each time. Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- drivers/gpu/drm/imx/imx-ldb.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c index e3fa46e1639d..5ef9fcb9ae94 100644 --- a/drivers/gpu/drm/imx/imx-ldb.c +++ b/drivers/gpu/drm/imx/imx-ldb.c @@ -95,11 +95,16 @@ struct imx_ldb { const struct bus_mux *lvds_mux; }; +static inline int imx_ldb_is_dual(struct imx_ldb *ldb) +{ + return ldb->ldb_ctrl & LDB_SPLIT_MODE_EN; +} + static void imx_ldb_ch_set_bus_format(struct imx_ldb_channel *imx_ldb_ch, u32 bus_format) { struct imx_ldb *ldb = imx_ldb_ch->ldb; - int dual = ldb->ldb_ctrl & LDB_SPLIT_MODE_EN; + int dual = imx_ldb_is_dual(ldb); switch (bus_format) { case MEDIA_BUS_FMT_RGB666_1X7X3_SPWG: @@ -196,7 +201,7 @@ static void imx_ldb_encoder_enable(struct drm_encoder *encoder) { struct imx_ldb_channel *imx_ldb_ch = enc_to_imx_ldb_ch(encoder); struct imx_ldb *ldb = imx_ldb_ch->ldb; - int dual = ldb->ldb_ctrl & LDB_SPLIT_MODE_EN; + int dual = imx_ldb_is_dual(ldb); int mux = drm_of_encoder_active_port_id(imx_ldb_ch->child, encoder); drm_panel_prepare(imx_ldb_ch->panel); @@ -251,7 +256,7 @@ imx_ldb_encoder_atomic_mode_set(struct drm_encoder *encoder, struct imx_ldb_channel *imx_ldb_ch = enc_to_imx_ldb_ch(encoder); struct drm_display_mode *mode = &crtc_state->adjusted_mode; struct imx_ldb *ldb = imx_ldb_ch->ldb; - int dual = ldb->ldb_ctrl & LDB_SPLIT_MODE_EN; + int dual = imx_ldb_is_dual(ldb); unsigned long serial_clk; unsigned long di_clk = mode->clock * 1000; int mux = drm_of_encoder_active_port_id(imx_ldb_ch->child, encoder); @@ -315,7 +320,7 @@ static void imx_ldb_encoder_disable(struct drm_encoder *encoder) regmap_write(ldb->regmap, IOMUXC_GPR2, ldb->ldb_ctrl); - if (ldb->ldb_ctrl & LDB_SPLIT_MODE_EN) { + if (imx_ldb_is_dual(ldb)) { clk_disable_unprepare(ldb->clk[0]); clk_disable_unprepare(ldb->clk[1]); } @@ -434,7 +439,7 @@ static int imx_ldb_register(struct drm_device *drm, if (ret) return ret; - if (ldb->ldb_ctrl & LDB_SPLIT_MODE_EN) { + if (imx_ldb_is_dual(ldb)) { ret = imx_ldb_get_clk(ldb, 1); if (ret) return ret; @@ -557,7 +562,7 @@ static int imx_ldb_bind(struct device *dev, struct device *master, void *data) struct drm_device *drm = data; struct device_node *np = dev->of_node; struct imx_ldb *imx_ldb = dev_get_drvdata(dev); - int dual = imx_ldb->ldb_ctrl & LDB_SPLIT_MODE_EN; + int dual = imx_ldb_is_dual(imx_ldb); struct device_node *child; int ret; int i; -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Marco Felsch <m.felsch@pengutronix.de> To: p.zabel@pengutronix.de, airlied@linux.ie, daniel@ffwll.ch, shawnguo@kernel.org, stefan@agner.ch, rmk+kernel@armlinux.org.uk Cc: kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: [PATCH 14/17] drm/imx: imx-ldb: add ldb_is_dual helper Date: Thu, 27 Feb 2020 17:21:22 +0100 [thread overview] Message-ID: <20200227162125.10450-15-m.felsch@pengutronix.de> (raw) In-Reply-To: <20200227162125.10450-1-m.felsch@pengutronix.de> There where several places where this bit operation is made. Add a simple helper so we don't need to remember the bit each time. Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- drivers/gpu/drm/imx/imx-ldb.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c index e3fa46e1639d..5ef9fcb9ae94 100644 --- a/drivers/gpu/drm/imx/imx-ldb.c +++ b/drivers/gpu/drm/imx/imx-ldb.c @@ -95,11 +95,16 @@ struct imx_ldb { const struct bus_mux *lvds_mux; }; +static inline int imx_ldb_is_dual(struct imx_ldb *ldb) +{ + return ldb->ldb_ctrl & LDB_SPLIT_MODE_EN; +} + static void imx_ldb_ch_set_bus_format(struct imx_ldb_channel *imx_ldb_ch, u32 bus_format) { struct imx_ldb *ldb = imx_ldb_ch->ldb; - int dual = ldb->ldb_ctrl & LDB_SPLIT_MODE_EN; + int dual = imx_ldb_is_dual(ldb); switch (bus_format) { case MEDIA_BUS_FMT_RGB666_1X7X3_SPWG: @@ -196,7 +201,7 @@ static void imx_ldb_encoder_enable(struct drm_encoder *encoder) { struct imx_ldb_channel *imx_ldb_ch = enc_to_imx_ldb_ch(encoder); struct imx_ldb *ldb = imx_ldb_ch->ldb; - int dual = ldb->ldb_ctrl & LDB_SPLIT_MODE_EN; + int dual = imx_ldb_is_dual(ldb); int mux = drm_of_encoder_active_port_id(imx_ldb_ch->child, encoder); drm_panel_prepare(imx_ldb_ch->panel); @@ -251,7 +256,7 @@ imx_ldb_encoder_atomic_mode_set(struct drm_encoder *encoder, struct imx_ldb_channel *imx_ldb_ch = enc_to_imx_ldb_ch(encoder); struct drm_display_mode *mode = &crtc_state->adjusted_mode; struct imx_ldb *ldb = imx_ldb_ch->ldb; - int dual = ldb->ldb_ctrl & LDB_SPLIT_MODE_EN; + int dual = imx_ldb_is_dual(ldb); unsigned long serial_clk; unsigned long di_clk = mode->clock * 1000; int mux = drm_of_encoder_active_port_id(imx_ldb_ch->child, encoder); @@ -315,7 +320,7 @@ static void imx_ldb_encoder_disable(struct drm_encoder *encoder) regmap_write(ldb->regmap, IOMUXC_GPR2, ldb->ldb_ctrl); - if (ldb->ldb_ctrl & LDB_SPLIT_MODE_EN) { + if (imx_ldb_is_dual(ldb)) { clk_disable_unprepare(ldb->clk[0]); clk_disable_unprepare(ldb->clk[1]); } @@ -434,7 +439,7 @@ static int imx_ldb_register(struct drm_device *drm, if (ret) return ret; - if (ldb->ldb_ctrl & LDB_SPLIT_MODE_EN) { + if (imx_ldb_is_dual(ldb)) { ret = imx_ldb_get_clk(ldb, 1); if (ret) return ret; @@ -557,7 +562,7 @@ static int imx_ldb_bind(struct device *dev, struct device *master, void *data) struct drm_device *drm = data; struct device_node *np = dev->of_node; struct imx_ldb *imx_ldb = dev_get_drvdata(dev); - int dual = imx_ldb->ldb_ctrl & LDB_SPLIT_MODE_EN; + int dual = imx_ldb_is_dual(imx_ldb); struct device_node *child; int ret; int i; -- 2.20.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-27 16:25 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-27 16:21 [PATCH 00/17] DRM: imx spring-cleaning Marco Felsch 2020-02-27 16:21 ` Marco Felsch 2020-02-27 16:21 ` [PATCH 01/17] drm/imx: drop useless best_encoder callback Marco Felsch 2020-02-27 16:21 ` Marco Felsch 2020-02-27 16:21 ` [PATCH 02/17] drm/imx: parallel-display: fix edid memory leak Marco Felsch 2020-02-27 16:21 ` Marco Felsch 2020-02-27 16:21 ` [PATCH 03/17] drm/imx: parallel-display: move panel/bridge detection to fail early Marco Felsch 2020-02-27 16:21 ` Marco Felsch 2020-02-27 16:21 ` [PATCH 04/17] drm/imx: parallel-display: detach panel within drm_encoder destroy Marco Felsch 2020-02-27 16:21 ` Marco Felsch 2020-02-27 16:21 ` [PATCH 05/17] drm/imx: parallel-display: split encoder and decoder states Marco Felsch 2020-02-27 16:21 ` Marco Felsch 2020-02-27 16:21 ` [PATCH 06/17] imx/drm: parallel-display: split attach function Marco Felsch 2020-02-27 16:21 ` Marco Felsch 2020-02-27 16:21 ` [PATCH 07/17] drm/imx: tve: add regulator_disable devm_action Marco Felsch 2020-02-27 16:21 ` Marco Felsch 2020-02-27 16:21 ` [PATCH 08/17] drm/imx: tve: split global state container Marco Felsch 2020-02-27 16:21 ` Marco Felsch 2020-02-27 16:21 ` [PATCH 09/17] drm/imx: imx-ldb: remove useless enum Marco Felsch 2020-02-27 16:21 ` Marco Felsch 2020-02-27 16:21 ` [PATCH 10/17] drm/imx: imx-ldb: fix edid memory leak Marco Felsch 2020-02-27 16:21 ` Marco Felsch 2020-02-27 16:21 ` [PATCH 11/17] drm/imx: imx-ldb: release ldb-channel resources within encoder destroy Marco Felsch 2020-02-27 16:21 ` Marco Felsch 2020-02-27 16:21 ` [PATCH 12/17] drm/imx: remove imx_drm_encoder_destroy helper Marco Felsch 2020-02-27 16:21 ` Marco Felsch 2020-02-27 16:21 ` [PATCH 13/17] drm/imx: imx-ldb: split imx_ldb devres allocation context Marco Felsch 2020-02-27 16:21 ` Marco Felsch 2020-02-27 16:21 ` Marco Felsch [this message] 2020-02-27 16:21 ` [PATCH 14/17] drm/imx: imx-ldb: add ldb_is_dual helper Marco Felsch 2020-02-27 16:21 ` [PATCH 15/17] drm/imx: imx-ldb: split encoder and decoder states Marco Felsch 2020-02-27 16:21 ` Marco Felsch 2020-02-27 16:21 ` [PATCH 16/17] drm/imx: imx-ldb: refactor imx_ldb_bind Marco Felsch 2020-02-27 16:21 ` Marco Felsch 2020-02-27 16:21 ` [PATCH 17/17] drm/imx: fix drm_mode_config_cleanup race condition Marco Felsch 2020-02-27 16:21 ` Marco Felsch 2020-02-27 17:29 ` Daniel Vetter 2020-02-27 17:29 ` Daniel Vetter 2020-02-27 17:44 ` Lucas Stach 2020-02-27 17:44 ` Lucas Stach 2020-02-27 18:14 ` Daniel Vetter 2020-02-27 18:14 ` Daniel Vetter 2020-02-27 18:23 ` Marco Felsch 2020-02-27 18:23 ` Marco Felsch 2020-03-02 18:07 ` Philipp Zabel 2020-03-02 18:07 ` Philipp Zabel 2020-03-02 21:32 ` Daniel Vetter 2020-03-02 21:32 ` Daniel Vetter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200227162125.10450-15-m.felsch@pengutronix.de \ --to=m.felsch@pengutronix.de \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=p.zabel@pengutronix.de \ --cc=rmk+kernel@armlinux.org.uk \ --cc=shawnguo@kernel.org \ --cc=stefan@agner.ch \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.