All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Rob Herring <robh@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Cc: Maxime Ripard <mripard@kernel.org>,
	Robert Richter <rric@kernel.org>,
	soc@kernel.org, Jon Loeliger <jdl@jdl.com>,
	Mark Langsdorf <mlangsdo@redhat.com>,
	Eric Auger <eric.auger@redhat.com>, Will Deacon <will@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>
Subject: [PATCH v2 03/13] arm: dts: calxeda: Fix interrupt grouping
Date: Thu, 27 Feb 2020 18:22:00 +0000	[thread overview]
Message-ID: <20200227182210.89512-4-andre.przywara@arm.com> (raw)
In-Reply-To: <20200227182210.89512-1-andre.przywara@arm.com>

Currently multiple interrupts for some devices are written as one array
instead of using the DT grouping notation (<0 42 4>, <0 23 4>).
This ends up in the same binary representation in the .dtb, but is
semantically not equivalent. The yaml schema checks will stumble over
this, so lets fix that first.

I refrained from using the symbolic names for GIC_SPI/GIC_PPI and
IRQ_TYPE_LEVEL_HIGH, mostly because it increases the delta between the
original DTS files and the mainline versions, so it's just additional
churn.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 arch/arm/boot/dts/ecx-2000.dts    | 2 +-
 arch/arm/boot/dts/ecx-common.dtsi | 4 ++--
 arch/arm/boot/dts/highbank.dts    | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/ecx-2000.dts b/arch/arm/boot/dts/ecx-2000.dts
index 81eb382b4c23..93cdd020637b 100644
--- a/arch/arm/boot/dts/ecx-2000.dts
+++ b/arch/arm/boot/dts/ecx-2000.dts
@@ -92,7 +92,7 @@
 
 		pmu {
 			compatible = "arm,cortex-a9-pmu";
-			interrupts = <0 76 4  0 75 4  0 74 4  0 73 4>;
+			interrupts = <0 76 4>, <0 75 4>, <0 74 4>, <0 73 4>;
 		};
 	};
 };
diff --git a/arch/arm/boot/dts/ecx-common.dtsi b/arch/arm/boot/dts/ecx-common.dtsi
index f819e3328a9e..b7e74a357471 100644
--- a/arch/arm/boot/dts/ecx-common.dtsi
+++ b/arch/arm/boot/dts/ecx-common.dtsi
@@ -202,14 +202,14 @@
 		ethernet@fff50000 {
 			compatible = "calxeda,hb-xgmac";
 			reg = <0xfff50000 0x1000>;
-			interrupts = <0 77 4  0 78 4  0 79 4>;
+			interrupts = <0 77 4>, <0 78 4>, <0 79 4>;
 			dma-coherent;
 		};
 
 		ethernet@fff51000 {
 			compatible = "calxeda,hb-xgmac";
 			reg = <0xfff51000 0x1000>;
-			interrupts = <0 80 4  0 81 4  0 82 4>;
+			interrupts = <0 80 4>, <0 81 4>, <0 82 4>;
 			dma-coherent;
 		};
 
diff --git a/arch/arm/boot/dts/highbank.dts b/arch/arm/boot/dts/highbank.dts
index 9e34d1bd7994..b6b0225a769e 100644
--- a/arch/arm/boot/dts/highbank.dts
+++ b/arch/arm/boot/dts/highbank.dts
@@ -142,14 +142,14 @@
 
 		pmu {
 			compatible = "arm,cortex-a9-pmu";
-			interrupts = <0 76 4  0 75 4  0 74 4  0 73 4>;
+			interrupts = <0 76 4>, <0 75 4>, <0 74 4>, <0 73 4>;
 		};
 
 
 		sregs@fff3c200 {
 			compatible = "calxeda,hb-sregs-l2-ecc";
 			reg = <0xfff3c200 0x100>;
-			interrupts = <0 71 4  0 72 4>;
+			interrupts = <0 71 4>, <0 72 4>;
 		};
 
 	};
-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com>
To: Rob Herring <robh@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Cc: Jon Loeliger <jdl@jdl.com>, Mark Langsdorf <mlangsdo@redhat.com>,
	Robert Richter <rric@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Maxime Ripard <mripard@kernel.org>,
	Eric Auger <eric.auger@redhat.com>,
	soc@kernel.org, Will Deacon <will@kernel.org>
Subject: [PATCH v2 03/13] arm: dts: calxeda: Fix interrupt grouping
Date: Thu, 27 Feb 2020 18:22:00 +0000	[thread overview]
Message-ID: <20200227182210.89512-4-andre.przywara@arm.com> (raw)
In-Reply-To: <20200227182210.89512-1-andre.przywara@arm.com>

Currently multiple interrupts for some devices are written as one array
instead of using the DT grouping notation (<0 42 4>, <0 23 4>).
This ends up in the same binary representation in the .dtb, but is
semantically not equivalent. The yaml schema checks will stumble over
this, so lets fix that first.

I refrained from using the symbolic names for GIC_SPI/GIC_PPI and
IRQ_TYPE_LEVEL_HIGH, mostly because it increases the delta between the
original DTS files and the mainline versions, so it's just additional
churn.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 arch/arm/boot/dts/ecx-2000.dts    | 2 +-
 arch/arm/boot/dts/ecx-common.dtsi | 4 ++--
 arch/arm/boot/dts/highbank.dts    | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/ecx-2000.dts b/arch/arm/boot/dts/ecx-2000.dts
index 81eb382b4c23..93cdd020637b 100644
--- a/arch/arm/boot/dts/ecx-2000.dts
+++ b/arch/arm/boot/dts/ecx-2000.dts
@@ -92,7 +92,7 @@
 
 		pmu {
 			compatible = "arm,cortex-a9-pmu";
-			interrupts = <0 76 4  0 75 4  0 74 4  0 73 4>;
+			interrupts = <0 76 4>, <0 75 4>, <0 74 4>, <0 73 4>;
 		};
 	};
 };
diff --git a/arch/arm/boot/dts/ecx-common.dtsi b/arch/arm/boot/dts/ecx-common.dtsi
index f819e3328a9e..b7e74a357471 100644
--- a/arch/arm/boot/dts/ecx-common.dtsi
+++ b/arch/arm/boot/dts/ecx-common.dtsi
@@ -202,14 +202,14 @@
 		ethernet@fff50000 {
 			compatible = "calxeda,hb-xgmac";
 			reg = <0xfff50000 0x1000>;
-			interrupts = <0 77 4  0 78 4  0 79 4>;
+			interrupts = <0 77 4>, <0 78 4>, <0 79 4>;
 			dma-coherent;
 		};
 
 		ethernet@fff51000 {
 			compatible = "calxeda,hb-xgmac";
 			reg = <0xfff51000 0x1000>;
-			interrupts = <0 80 4  0 81 4  0 82 4>;
+			interrupts = <0 80 4>, <0 81 4>, <0 82 4>;
 			dma-coherent;
 		};
 
diff --git a/arch/arm/boot/dts/highbank.dts b/arch/arm/boot/dts/highbank.dts
index 9e34d1bd7994..b6b0225a769e 100644
--- a/arch/arm/boot/dts/highbank.dts
+++ b/arch/arm/boot/dts/highbank.dts
@@ -142,14 +142,14 @@
 
 		pmu {
 			compatible = "arm,cortex-a9-pmu";
-			interrupts = <0 76 4  0 75 4  0 74 4  0 73 4>;
+			interrupts = <0 76 4>, <0 75 4>, <0 74 4>, <0 73 4>;
 		};
 
 
 		sregs@fff3c200 {
 			compatible = "calxeda,hb-sregs-l2-ecc";
 			reg = <0xfff3c200 0x100>;
-			interrupts = <0 71 4  0 72 4>;
+			interrupts = <0 71 4>, <0 72 4>;
 		};
 
 	};
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-02-27 18:22 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27 18:21 [PATCH v2 00/13] arm: calxeda: update DTS, bindings and MAINTAINERS Andre Przywara
2020-02-27 18:21 ` Andre Przywara
2020-02-27 18:21 ` [PATCH v2 01/13] arm: dts: calxeda: Basic DT file fixes Andre Przywara
2020-02-27 18:21   ` Andre Przywara
2020-02-27 21:42   ` Rob Herring
2020-02-27 21:42     ` Rob Herring
2020-02-27 18:21 ` [PATCH v2 02/13] arm: dts: calxeda: Provide UART clock Andre Przywara
2020-02-27 18:21   ` Andre Przywara
2020-02-27 21:43   ` Rob Herring
2020-02-27 21:43     ` Rob Herring
2020-02-27 18:22 ` Andre Przywara [this message]
2020-02-27 18:22   ` [PATCH v2 03/13] arm: dts: calxeda: Fix interrupt grouping Andre Przywara
2020-02-27 21:45   ` Rob Herring
2020-02-27 21:45     ` Rob Herring
2020-02-27 18:22 ` [PATCH v2 04/13] arm: dts: calxeda: Group port-phys and sgpio-gpio items Andre Przywara
2020-02-27 18:22   ` Andre Przywara
2020-02-27 21:45   ` Rob Herring
2020-02-27 21:45     ` Rob Herring
2020-02-27 18:22 ` [PATCH v2 05/13] dt-bindings: clock: Convert Calxeda clock bindings to json-schema Andre Przywara
2020-02-27 18:22   ` Andre Przywara
2020-02-28 22:20   ` Stephen Boyd
2020-02-27 18:22 ` [PATCH v2 06/13] dt-bindings: sata: Convert Calxeda SATA controller " Andre Przywara
2020-02-27 18:22   ` Andre Przywara
2020-02-27 22:05   ` Rob Herring
2020-02-27 22:05     ` Rob Herring
2020-02-27 18:22 ` [PATCH v2 07/13] dt-bindings: net: Convert Calxeda Ethernet binding " Andre Przywara
2020-02-27 18:22   ` Andre Przywara
2020-02-27 18:22 ` [PATCH v2 08/13] dt-bindings: phy: Convert Calxeda ComboPHY " Andre Przywara
2020-02-27 18:22   ` Andre Przywara
2020-02-27 18:22 ` [PATCH v2 09/13] dt-bindings: arm: Convert Calxeda L2 cache controller " Andre Przywara
2020-02-27 18:22   ` Andre Przywara
2020-02-27 18:22 ` [PATCH v2 10/13] dt-bindings: memory-controllers: Convert Calxeda DDR " Andre Przywara
2020-02-27 18:22   ` Andre Przywara
2020-02-27 18:22 ` [PATCH v2 11/13] dt-bindings: ipmi: Convert IPMI-SMIC bindings " Andre Przywara
2020-02-27 18:22   ` Andre Przywara
2020-02-27 22:21   ` Rob Herring
2020-02-27 22:21     ` Rob Herring
2020-02-28  0:21     ` André Przywara
2020-02-28  0:21       ` André Przywara
2020-02-27 18:22 ` [PATCH v2 12/13] dt-bindings: arm: Add Calxeda system registers json-schema binding Andre Przywara
2020-02-27 18:22   ` Andre Przywara
2020-02-27 22:22   ` Rob Herring
2020-02-27 22:22     ` Rob Herring
2020-02-27 18:22 ` [PATCH v2 13/13] MAINTAINERS: Update Calxeda Highbank maintainership Andre Przywara
2020-02-27 18:22   ` Andre Przywara
2020-02-27 22:35   ` Rob Herring
2020-02-27 22:35     ` Rob Herring
2020-02-28  0:39     ` Olof Johansson
2020-02-28  0:39       ` Olof Johansson
2020-02-28 11:53       ` Andre Przywara
2020-02-28 11:53         ` Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200227182210.89512-4-andre.przywara@arm.com \
    --to=andre.przywara@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=eric.auger@redhat.com \
    --cc=jdl@jdl.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlangsdo@redhat.com \
    --cc=mripard@kernel.org \
    --cc=robh@kernel.org \
    --cc=rric@kernel.org \
    --cc=soc@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.