All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Shawn Guo <shawnguo@kernel.org>, Li Yang <leoyang.li@nxp.com>,
	Jiri Slaby <jslaby@suse.com>, Peng Fan <peng.fan@nxp.com>,
	Vabhav Sharma <vabhav.sharma@nxp.com>,
	Yuan Yao <yao.yuan@nxp.com>, Michael Walle <michael@walle.cc>
Subject: [PATCH v3 1/9] Revert "tty: serial: fsl_lpuart: drop EARLYCON_DECLARE"
Date: Tue,  3 Mar 2020 18:42:58 +0100	[thread overview]
Message-ID: <20200303174306.6015-2-michael@walle.cc> (raw)
In-Reply-To: <20200303174306.6015-1-michael@walle.cc>

This reverts commit a659652f6169240a5818cb244b280c5a362ef5a4.

This broke the earlycon on LS1021A processors because the order of the
earlycon_setup() functions were changed. Before the commit the normal
lpuart32_early_console_setup() was called. After the commit the
lpuart32_imx_early_console_setup() is called instead.

Fixes: a659652f6169 ("tty: serial: fsl_lpuart: drop EARLYCON_DECLARE")
Signed-off-by: Michael Walle <michael@walle.cc>
---
 drivers/tty/serial/fsl_lpuart.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index 91e2805e6441..27fdc131c352 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -2390,6 +2390,8 @@ static int __init lpuart32_imx_early_console_setup(struct earlycon_device *devic
 OF_EARLYCON_DECLARE(lpuart, "fsl,vf610-lpuart", lpuart_early_console_setup);
 OF_EARLYCON_DECLARE(lpuart32, "fsl,ls1021a-lpuart", lpuart32_early_console_setup);
 OF_EARLYCON_DECLARE(lpuart32, "fsl,imx7ulp-lpuart", lpuart32_imx_early_console_setup);
+EARLYCON_DECLARE(lpuart, lpuart_early_console_setup);
+EARLYCON_DECLARE(lpuart32, lpuart32_early_console_setup);
 
 #define LPUART_CONSOLE	(&lpuart_console)
 #define LPUART32_CONSOLE	(&lpuart32_console)
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <michael@walle.cc>
To: linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Mark Rutland <mark.rutland@arm.com>, Peng Fan <peng.fan@nxp.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Li Yang <leoyang.li@nxp.com>, Michael Walle <michael@walle.cc>,
	Rob Herring <robh+dt@kernel.org>, Yuan Yao <yao.yuan@nxp.com>,
	Vabhav Sharma <vabhav.sharma@nxp.com>,
	Jiri Slaby <jslaby@suse.com>, Shawn Guo <shawnguo@kernel.org>
Subject: [PATCH v3 1/9] Revert "tty: serial: fsl_lpuart: drop EARLYCON_DECLARE"
Date: Tue,  3 Mar 2020 18:42:58 +0100	[thread overview]
Message-ID: <20200303174306.6015-2-michael@walle.cc> (raw)
In-Reply-To: <20200303174306.6015-1-michael@walle.cc>

This reverts commit a659652f6169240a5818cb244b280c5a362ef5a4.

This broke the earlycon on LS1021A processors because the order of the
earlycon_setup() functions were changed. Before the commit the normal
lpuart32_early_console_setup() was called. After the commit the
lpuart32_imx_early_console_setup() is called instead.

Fixes: a659652f6169 ("tty: serial: fsl_lpuart: drop EARLYCON_DECLARE")
Signed-off-by: Michael Walle <michael@walle.cc>
---
 drivers/tty/serial/fsl_lpuart.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index 91e2805e6441..27fdc131c352 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -2390,6 +2390,8 @@ static int __init lpuart32_imx_early_console_setup(struct earlycon_device *devic
 OF_EARLYCON_DECLARE(lpuart, "fsl,vf610-lpuart", lpuart_early_console_setup);
 OF_EARLYCON_DECLARE(lpuart32, "fsl,ls1021a-lpuart", lpuart32_early_console_setup);
 OF_EARLYCON_DECLARE(lpuart32, "fsl,imx7ulp-lpuart", lpuart32_imx_early_console_setup);
+EARLYCON_DECLARE(lpuart, lpuart_early_console_setup);
+EARLYCON_DECLARE(lpuart32, lpuart32_early_console_setup);
 
 #define LPUART_CONSOLE	(&lpuart_console)
 #define LPUART32_CONSOLE	(&lpuart32_console)
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-03-03 17:43 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-03 17:42 [PATCH v3 0/9] tty: serial: fsl_lpuart various fixes and LS1028A support Michael Walle
2020-03-03 17:42 ` Michael Walle
2020-03-03 17:42 ` Michael Walle [this message]
2020-03-03 17:42   ` [PATCH v3 1/9] Revert "tty: serial: fsl_lpuart: drop EARLYCON_DECLARE" Michael Walle
2020-03-03 17:42 ` [PATCH v3 2/9] tty: serial: fsl_lpuart: free IDs allocated by IDA Michael Walle
2020-03-03 17:42   ` Michael Walle
2020-03-03 17:43 ` [PATCH v3 3/9] tty: serial: fsl_lpuart: handle EPROBE_DEFER for DMA Michael Walle
2020-03-03 17:43   ` Michael Walle
2020-03-03 18:47   ` Rob Herring
2020-03-03 18:47     ` Rob Herring
2020-03-03 20:57     ` Michael Walle
2020-03-03 20:57       ` Michael Walle
2020-03-03 17:43 ` [PATCH v3 4/9] tty: serial: fsl_lpuart: fix DMA mapping Michael Walle
2020-03-03 17:43   ` Michael Walle
2020-03-03 17:43 ` [PATCH v3 5/9] dt-bindings: serial: lpuart: add ls1028a compatibility Michael Walle
2020-03-03 17:43   ` Michael Walle
2020-03-03 17:43 ` [PATCH v3 6/9] tty: serial: fsl_lpuart: add LS1028A support Michael Walle
2020-03-03 17:43   ` Michael Walle
2020-03-03 17:43 ` [PATCH v3 7/9] tty: serial: fsl_lpuart: add LS1028A earlycon support Michael Walle
2020-03-03 17:43   ` Michael Walle
2020-03-03 17:43 ` [PATCH v3 8/9] arm64: dts: ls1028a: add "fsl,vf610-edma" compatible Michael Walle
2020-03-03 17:43   ` Michael Walle
2020-03-03 22:43   ` Leo Li
2020-03-03 22:43     ` Leo Li
2020-03-03 17:43 ` [PATCH v3 9/9] arm64: dts: ls1028a: add missing LPUART nodes Michael Walle
2020-03-03 17:43   ` Michael Walle
2020-03-03 22:49 ` [PATCH v3 0/9] tty: serial: fsl_lpuart various fixes and LS1028A support Leo Li
2020-03-03 22:49   ` Leo Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200303174306.6015-2-michael@walle.cc \
    --to=michael@walle.cc \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=peng.fan@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=vabhav.sharma@nxp.com \
    --cc=yao.yuan@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.