From: Sergiu Cuciurean <sergiu.cuciurean@analog.com> To: <linux-kernel@vger.kernel.org>, <devel@driverdev.osuosl.org>, <linux-wireless@vger.kernel.org>, <gregkh@linuxfoundation.org>, <ajay.kathat@microchip.com>, <adham.abozaeid@microchip.com> Cc: Sergiu Cuciurean <sergiu.cuciurean@analog.com> Subject: [PATCH v2] staging: wilc1000: spi: Use new structure for SPI transfer delays Date: Wed, 4 Mar 2020 09:43:19 +0200 [thread overview] Message-ID: <20200304074319.22107-1-sergiu.cuciurean@analog.com> (raw) In-Reply-To: <20200227145054.24567-1-sergiu.cuciurean@analog.com> In a recent change to the SPI subsystem in commit <bebcfd272df6> ("spi: introduce `delay` field for `spi_transfer` + spi_transfer_delay_exec()"), a new `delay` struct was added to replace the `delay_usecs`. This change replaces the current `delay_usecs` with `delay` for this driver. The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure that both `delay_usecs` & `delay` are used (in this order to preserve backwards compatibility). Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com> --- Changelog v1->v2: *Removed footnote from the commit description drivers/staging/wilc1000/spi.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/spi.c b/drivers/staging/wilc1000/spi.c index 11653ac118cd..a3779d967a24 100644 --- a/drivers/staging/wilc1000/spi.c +++ b/drivers/staging/wilc1000/spi.c @@ -228,7 +228,10 @@ static int wilc_spi_tx(struct wilc *wilc, u8 *b, u32 len) struct spi_transfer tr = { .tx_buf = b, .len = len, - .delay_usecs = 0, + .delay = { + .value = 0, + .unit = SPI_DELAY_UNIT_USECS + }, }; char *r_buffer = kzalloc(len, GFP_KERNEL); @@ -269,7 +272,10 @@ static int wilc_spi_rx(struct wilc *wilc, u8 *rb, u32 rlen) struct spi_transfer tr = { .rx_buf = rb, .len = rlen, - .delay_usecs = 0, + .delay = { + .value = 0, + .unit = SPI_DELAY_UNIT_USECS + }, }; char *t_buffer = kzalloc(rlen, GFP_KERNEL); @@ -311,7 +317,10 @@ static int wilc_spi_tx_rx(struct wilc *wilc, u8 *wb, u8 *rb, u32 rlen) .tx_buf = wb, .len = rlen, .bits_per_word = 8, - .delay_usecs = 0, + .delay = { + .value = 0, + .unit = SPI_DELAY_UNIT_USECS + }, }; -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Sergiu Cuciurean <sergiu.cuciurean@analog.com> To: <linux-kernel@vger.kernel.org>, <devel@driverdev.osuosl.org>, <linux-wireless@vger.kernel.org>, <gregkh@linuxfoundation.org>, <ajay.kathat@microchip.com>, <adham.abozaeid@microchip.com> Cc: Sergiu Cuciurean <sergiu.cuciurean@analog.com> Subject: [PATCH v2] staging: wilc1000: spi: Use new structure for SPI transfer delays Date: Wed, 4 Mar 2020 09:43:19 +0200 [thread overview] Message-ID: <20200304074319.22107-1-sergiu.cuciurean@analog.com> (raw) In-Reply-To: <20200227145054.24567-1-sergiu.cuciurean@analog.com> In a recent change to the SPI subsystem in commit <bebcfd272df6> ("spi: introduce `delay` field for `spi_transfer` + spi_transfer_delay_exec()"), a new `delay` struct was added to replace the `delay_usecs`. This change replaces the current `delay_usecs` with `delay` for this driver. The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure that both `delay_usecs` & `delay` are used (in this order to preserve backwards compatibility). Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com> --- Changelog v1->v2: *Removed footnote from the commit description drivers/staging/wilc1000/spi.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/spi.c b/drivers/staging/wilc1000/spi.c index 11653ac118cd..a3779d967a24 100644 --- a/drivers/staging/wilc1000/spi.c +++ b/drivers/staging/wilc1000/spi.c @@ -228,7 +228,10 @@ static int wilc_spi_tx(struct wilc *wilc, u8 *b, u32 len) struct spi_transfer tr = { .tx_buf = b, .len = len, - .delay_usecs = 0, + .delay = { + .value = 0, + .unit = SPI_DELAY_UNIT_USECS + }, }; char *r_buffer = kzalloc(len, GFP_KERNEL); @@ -269,7 +272,10 @@ static int wilc_spi_rx(struct wilc *wilc, u8 *rb, u32 rlen) struct spi_transfer tr = { .rx_buf = rb, .len = rlen, - .delay_usecs = 0, + .delay = { + .value = 0, + .unit = SPI_DELAY_UNIT_USECS + }, }; char *t_buffer = kzalloc(rlen, GFP_KERNEL); @@ -311,7 +317,10 @@ static int wilc_spi_tx_rx(struct wilc *wilc, u8 *wb, u8 *rb, u32 rlen) .tx_buf = wb, .len = rlen, .bits_per_word = 8, - .delay_usecs = 0, + .delay = { + .value = 0, + .unit = SPI_DELAY_UNIT_USECS + }, }; -- 2.17.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-03-04 7:43 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-27 14:50 [PATCH] staging: wilc1000: spi: Use new structure for SPI transfer delays Sergiu Cuciurean 2020-02-27 14:50 ` Sergiu Cuciurean 2020-03-04 6:51 ` Greg KH 2020-03-04 6:51 ` Greg KH 2020-03-04 7:43 ` Sergiu Cuciurean [this message] 2020-03-04 7:43 ` [PATCH v2] " Sergiu Cuciurean
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200304074319.22107-1-sergiu.cuciurean@analog.com \ --to=sergiu.cuciurean@analog.com \ --cc=adham.abozaeid@microchip.com \ --cc=ajay.kathat@microchip.com \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.