All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH i-g-t] tests/i915/query: Do not assert engine info rsvd being zero
Date: Wed,  4 Mar 2020 09:29:01 +0000	[thread overview]
Message-ID: <20200304092901.2347-1-tvrtko.ursulin@linux.intel.com> (raw)

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

These are not input fields and i915 currently leaves them untouched.

In the spirit of trusting the query as the authoritative source of
information, stop asserting these output only reserved fields are zero.

This should prevent the test from auto-failing if we extend the data in
the future.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Brian Welty <brian.welty@intel.com>
---
 tests/i915/i915_query.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/tests/i915/i915_query.c b/tests/i915/i915_query.c
index 71807425fbc4..e7c6fc91e32b 100644
--- a/tests/i915/i915_query.c
+++ b/tests/i915/i915_query.c
@@ -690,11 +690,6 @@ static void engines(int fd)
 			  engine->flags,
 			  engine->capabilities);
 
-		/* MBZ fields. */
-		igt_assert_eq(engine->rsvd0, 0);
-		igt_assert_eq(engine->rsvd1[0], 0);
-		igt_assert_eq(engine->rsvd1[1], 0);
-
 		switch (engine->engine.engine_class) {
 		case I915_ENGINE_CLASS_RENDER:
 			/* Will be tested later. */
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org,
	Brian Welty <brian.welty@intel.com>,
	Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: [igt-dev] [PATCH i-g-t] tests/i915/query: Do not assert engine info rsvd being zero
Date: Wed,  4 Mar 2020 09:29:01 +0000	[thread overview]
Message-ID: <20200304092901.2347-1-tvrtko.ursulin@linux.intel.com> (raw)

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

These are not input fields and i915 currently leaves them untouched.

In the spirit of trusting the query as the authoritative source of
information, stop asserting these output only reserved fields are zero.

This should prevent the test from auto-failing if we extend the data in
the future.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Brian Welty <brian.welty@intel.com>
---
 tests/i915/i915_query.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/tests/i915/i915_query.c b/tests/i915/i915_query.c
index 71807425fbc4..e7c6fc91e32b 100644
--- a/tests/i915/i915_query.c
+++ b/tests/i915/i915_query.c
@@ -690,11 +690,6 @@ static void engines(int fd)
 			  engine->flags,
 			  engine->capabilities);
 
-		/* MBZ fields. */
-		igt_assert_eq(engine->rsvd0, 0);
-		igt_assert_eq(engine->rsvd1[0], 0);
-		igt_assert_eq(engine->rsvd1[1], 0);
-
 		switch (engine->engine.engine_class) {
 		case I915_ENGINE_CLASS_RENDER:
 			/* Will be tested later. */
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2020-03-04  9:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04  9:29 Tvrtko Ursulin [this message]
2020-03-04  9:29 ` [igt-dev] [PATCH i-g-t] tests/i915/query: Do not assert engine info rsvd being zero Tvrtko Ursulin
2020-03-04 10:10 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-03-04 10:15   ` Chris Wilson
2020-03-04 10:38     ` Tvrtko Ursulin
2020-03-04 17:34 ` [Intel-gfx] [PATCH i-g-t] " Brian Welty
2020-03-04 17:34   ` [igt-dev] " Brian Welty
2020-03-05  2:30 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200304092901.2347-1-tvrtko.ursulin@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.