All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH i-g-t] i915/i915_pm_rpm: Flush pm-idle before waiting for suspend
Date: Wed,  4 Mar 2020 11:13:06 +0000	[thread overview]
Message-ID: <20200304111306.2438943-1-chris@chris-wilson.co.uk> (raw)

After we may have deliberately woken the device up for reading the
debugfs/sysfs file, we then wait for the system to suspend again before
trying the next. Speed up the wait by first flushing the pm-idle.

"Slowest file + suspend: /sys/kernel/debug/dri/0/i915_forcewake_user
took 3951.33ms!"

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/i915_pm_rpm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
index 9118e8953..db035ef86 100644
--- a/tests/i915/i915_pm_rpm.c
+++ b/tests/i915/i915_pm_rpm.c
@@ -964,6 +964,7 @@ static int read_entry(const char *filepath,
 
 	close(fd);
 
+	igt_drop_caches_set(drm_fd, DROP_IDLE); /* flush pm-idle */
 	igt_assert_f(wait_for_suspended(), "After closing: %s (%s)\n",
 		     filepath + pathinfo->base, filepath);
 
-- 
2.25.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] i915/i915_pm_rpm: Flush pm-idle before waiting for suspend
Date: Wed,  4 Mar 2020 11:13:06 +0000	[thread overview]
Message-ID: <20200304111306.2438943-1-chris@chris-wilson.co.uk> (raw)

After we may have deliberately woken the device up for reading the
debugfs/sysfs file, we then wait for the system to suspend again before
trying the next. Speed up the wait by first flushing the pm-idle.

"Slowest file + suspend: /sys/kernel/debug/dri/0/i915_forcewake_user
took 3951.33ms!"

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/i915_pm_rpm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
index 9118e8953..db035ef86 100644
--- a/tests/i915/i915_pm_rpm.c
+++ b/tests/i915/i915_pm_rpm.c
@@ -964,6 +964,7 @@ static int read_entry(const char *filepath,
 
 	close(fd);
 
+	igt_drop_caches_set(drm_fd, DROP_IDLE); /* flush pm-idle */
 	igt_assert_f(wait_for_suspended(), "After closing: %s (%s)\n",
 		     filepath + pathinfo->base, filepath);
 
-- 
2.25.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2020-03-04 11:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04 11:13 Chris Wilson [this message]
2020-03-04 11:13 ` [igt-dev] [PATCH i-g-t] i915/i915_pm_rpm: Flush pm-idle before waiting for suspend Chris Wilson
2020-03-04 12:03 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-03-05  5:32 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200304111306.2438943-1-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.