All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@suse.com,
	david@redhat.com, richardw.yang@linux.intel.com,
	dan.j.williams@intel.com, osalvador@suse.de, rppt@linux.ibm.com,
	bhe@redhat.com
Subject: [PATCH v3 7/7] mm/sparse.c: Use __get_free_pages() instead in populate_section_memmap()
Date: Sat,  7 Mar 2020 16:42:29 +0800	[thread overview]
Message-ID: <20200307084229.28251-8-bhe@redhat.com> (raw)
In-Reply-To: <20200307084229.28251-1-bhe@redhat.com>

This removes the unnecessary goto, and simplify codes.

Signed-off-by: Baoquan He <bhe@redhat.com>
Reviewed-by: Wei Yang <richardw.yang@linux.intel.com>
---
 mm/sparse.c | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/mm/sparse.c b/mm/sparse.c
index fde651ab8741..266f7f5040fb 100644
--- a/mm/sparse.c
+++ b/mm/sparse.c
@@ -735,23 +735,19 @@ static void free_map_bootmem(struct page *memmap)
 struct page * __meminit populate_section_memmap(unsigned long pfn,
 		unsigned long nr_pages, int nid, struct vmem_altmap *altmap)
 {
-	struct page *page, *ret;
+	struct page *ret;
 	unsigned long memmap_size = sizeof(struct page) * PAGES_PER_SECTION;
 
-	page = alloc_pages(GFP_KERNEL|__GFP_NOWARN, get_order(memmap_size));
-	if (page)
-		goto got_map_page;
+	ret = (void*)__get_free_pages(GFP_KERNEL|__GFP_NOWARN,
+				get_order(memmap_size));
+	if (ret)
+		return ret;
 
 	ret = vmalloc(memmap_size);
 	if (ret)
-		goto got_map_ptr;
+		return ret;
 
 	return NULL;
-got_map_page:
-	ret = (struct page *)pfn_to_kaddr(page_to_pfn(page));
-got_map_ptr:
-
-	return ret;
 }
 
 static void depopulate_section_memmap(unsigned long pfn, unsigned long nr_pages,
-- 
2.17.2


  parent reply	other threads:[~2020-03-07  8:43 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-07  8:42 [PATCH v3 0/7] mm/hotplug: Only use subsection map for VMEMMAP Baoquan He
2020-03-07  8:42 ` [PATCH v3 1/7] mm/hotplug: fix hot remove failure in SPARSEMEM|!VMEMMAP case Baoquan He
2020-03-07 20:59   ` Andrew Morton
2020-03-07 22:55     ` Baoquan He
2020-03-09  8:56   ` David Hildenbrand
2020-03-09  8:58   ` David Hildenbrand
2020-03-09 13:18     ` Baoquan He
2020-03-09 13:22       ` David Hildenbrand
2020-03-09 10:13   ` Pankaj Gupta
2020-03-09 10:13     ` Pankaj Gupta
2020-03-09 12:56   ` Michal Hocko
2020-03-07  8:42 ` [PATCH v3 2/7] mm/sparse.c: introduce new function fill_subsection_map() Baoquan He
2020-03-07  8:42 ` [PATCH v3 3/7] mm/sparse.c: introduce a new function clear_subsection_map() Baoquan He
2020-03-09  8:59   ` David Hildenbrand
2020-03-09 13:32     ` Baoquan He
2020-03-09 13:38       ` David Hildenbrand
2020-03-09 14:07         ` Baoquan He
2020-03-07  8:42 ` [PATCH v3 4/7] mm/sparse.c: only use subsection map in VMEMMAP case Baoquan He
2020-03-09  9:00   ` David Hildenbrand
2020-03-07  8:42 ` [PATCH v3 5/7] mm/sparse.c: add note about only VMEMMAP supporting sub-section support Baoquan He
2020-03-07 11:55   ` Baoquan He
2020-03-10 14:46   ` Michal Hocko
2020-03-11  4:20     ` Baoquan He
2020-03-07  8:42 ` [PATCH v3 6/7] mm/sparse.c: move subsection_map related codes together Baoquan He
2020-03-09  9:08   ` David Hildenbrand
2020-03-09 13:41     ` Baoquan He
2020-03-07  8:42 ` Baoquan He [this message]
2020-03-10 14:56   ` [PATCH v3 7/7] mm/sparse.c: Use __get_free_pages() instead in populate_section_memmap() Michal Hocko
2020-03-10 14:59     ` David Hildenbrand
2020-03-11  9:31     ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200307084229.28251-8-bhe@redhat.com \
    --to=bhe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=osalvador@suse.de \
    --cc=richardw.yang@linux.intel.com \
    --cc=rppt@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.