From: "Yan, Zheng" <zyan@redhat.com>
To: ceph-devel@vger.kernel.org
Cc: jlayton@kernel.org, "Yan, Zheng" <zyan@redhat.com>
Subject: [PATCH 2/4] ceph: request new max size only when there is auth cap
Date: Tue, 10 Mar 2020 19:34:19 +0800 [thread overview]
Message-ID: <20200310113421.174873-3-zyan@redhat.com> (raw)
In-Reply-To: <20200310113421.174873-1-zyan@redhat.com>
When there is no auth cap, check_max_size() can't do anything, may
cause infinite loop inside ceph_get_caps().
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
---
fs/ceph/caps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c
index 804f4c65251a..295b61201d85 100644
--- a/fs/ceph/caps.c
+++ b/fs/ceph/caps.c
@@ -2582,7 +2582,7 @@ static int try_get_cap_refs(struct inode *inode, int need, int want,
dout("get_cap_refs %p endoff %llu > maxsize %llu\n",
inode, endoff, ci->i_max_size);
if (endoff > ci->i_requested_max_size)
- ret = -EFBIG;
+ ret = ci->i_auth_cap ? -EFBIG : -ESTALE;
goto out_unlock;
}
/*
--
2.21.1
next prev parent reply other threads:[~2020-03-10 11:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 11:34 [PATCH 0/4] fix ceph_get_caps() bugs Yan, Zheng
2020-03-10 11:34 ` [PATCH 1/4] ceph: cleanup return error of try_get_cap_refs() Yan, Zheng
2020-03-16 12:48 ` Jeff Layton
2020-03-16 15:26 ` Yan, Zheng
2020-03-10 11:34 ` Yan, Zheng [this message]
2020-03-10 11:34 ` [PATCH 3/4] ceph: don't skip updating wanted caps when cap is stale Yan, Zheng
2020-03-10 11:34 ` [PATCH 4/4] ceph: wait for async creating inode before requesting new max size Yan, Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310113421.174873-3-zyan@redhat.com \
--to=zyan@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=jlayton@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.