From: Lokesh Vutla <lokeshvutla@ti.com> To: "Thierry Reding" <thierry.reding@gmail.com>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> Cc: Tony Lindgren <tony@atomide.com>, Linux OMAP Mailing List <linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-pwm@vger.kernel.org>, Sekhar Nori <nsekhar@ti.com>, Vignesh R <vigneshr@ti.com>, Lokesh Vutla <lokeshvutla@ti.com> Subject: [PATCH v3 3/5] pwm: omap-dmtimer: Fix pwm enabling sequence Date: Thu, 12 Mar 2020 09:52:08 +0530 [thread overview] Message-ID: <20200312042210.17344-4-lokeshvutla@ti.com> (raw) In-Reply-To: <20200312042210.17344-1-lokeshvutla@ti.com> To configure DM timer is pwm mode the following needs to be set in OMAP_TIMER_CTRL_REG using set_pwm callback: - Set toggle mode on PORTIMERPWM output pin - Set trigger on overflow and match on PORTIMERPWM output pin. - Set auto reload This is a one time configuration and needs to be set before the start of the dm timer. But the current driver tries to set the same configuration for every period/duty cycle update, which is not needed. So move the pwm setup before enabling timer and do not update it in pwm_omap_dmtimer_config. Tested-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> --- drivers/pwm/pwm-omap-dmtimer.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pwm/pwm-omap-dmtimer.c b/drivers/pwm/pwm-omap-dmtimer.c index 92aac6c86b95..85b17b49980b 100644 --- a/drivers/pwm/pwm-omap-dmtimer.c +++ b/drivers/pwm/pwm-omap-dmtimer.c @@ -81,6 +81,11 @@ static int pwm_omap_dmtimer_enable(struct pwm_chip *chip, struct pwm_omap_dmtimer_chip *omap = to_pwm_omap_dmtimer_chip(chip); mutex_lock(&omap->mutex); + omap->pdata->set_pwm(omap->dm_timer, + pwm_get_polarity(pwm) == PWM_POLARITY_INVERSED, + true, OMAP_TIMER_TRIGGER_OVERFLOW_AND_COMPARE, + true); + pwm_omap_dmtimer_start(omap); mutex_unlock(&omap->mutex); @@ -197,11 +202,6 @@ static int pwm_omap_dmtimer_config(struct pwm_chip *chip, dev_dbg(chip->dev, "load value: %#08x (%d), match value: %#08x (%d)\n", load_value, load_value, match_value, match_value); - omap->pdata->set_pwm(omap->dm_timer, - pwm_get_polarity(pwm) == PWM_POLARITY_INVERSED, - true, OMAP_TIMER_TRIGGER_OVERFLOW_AND_COMPARE, - true); - /* If config was called while timer was running it must be reenabled. */ if (timer_active) pwm_omap_dmtimer_start(omap); -- 2.23.0
WARNING: multiple messages have this Message-ID (diff)
From: Lokesh Vutla <lokeshvutla@ti.com> To: "Thierry Reding" <thierry.reding@gmail.com>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> Cc: Tony Lindgren <tony@atomide.com>, Linux OMAP Mailing List <linux-omap@vger.kernel.org>, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Sekhar Nori <nsekhar@ti.com>, Vignesh R <vigneshr@ti.com>, Lokesh Vutla <lokeshvutla@ti.com> Subject: [PATCH v3 3/5] pwm: omap-dmtimer: Fix pwm enabling sequence Date: Thu, 12 Mar 2020 09:52:08 +0530 [thread overview] Message-ID: <20200312042210.17344-4-lokeshvutla@ti.com> (raw) In-Reply-To: <20200312042210.17344-1-lokeshvutla@ti.com> To configure DM timer is pwm mode the following needs to be set in OMAP_TIMER_CTRL_REG using set_pwm callback: - Set toggle mode on PORTIMERPWM output pin - Set trigger on overflow and match on PORTIMERPWM output pin. - Set auto reload This is a one time configuration and needs to be set before the start of the dm timer. But the current driver tries to set the same configuration for every period/duty cycle update, which is not needed. So move the pwm setup before enabling timer and do not update it in pwm_omap_dmtimer_config. Tested-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> --- drivers/pwm/pwm-omap-dmtimer.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pwm/pwm-omap-dmtimer.c b/drivers/pwm/pwm-omap-dmtimer.c index 92aac6c86b95..85b17b49980b 100644 --- a/drivers/pwm/pwm-omap-dmtimer.c +++ b/drivers/pwm/pwm-omap-dmtimer.c @@ -81,6 +81,11 @@ static int pwm_omap_dmtimer_enable(struct pwm_chip *chip, struct pwm_omap_dmtimer_chip *omap = to_pwm_omap_dmtimer_chip(chip); mutex_lock(&omap->mutex); + omap->pdata->set_pwm(omap->dm_timer, + pwm_get_polarity(pwm) == PWM_POLARITY_INVERSED, + true, OMAP_TIMER_TRIGGER_OVERFLOW_AND_COMPARE, + true); + pwm_omap_dmtimer_start(omap); mutex_unlock(&omap->mutex); @@ -197,11 +202,6 @@ static int pwm_omap_dmtimer_config(struct pwm_chip *chip, dev_dbg(chip->dev, "load value: %#08x (%d), match value: %#08x (%d)\n", load_value, load_value, match_value, match_value); - omap->pdata->set_pwm(omap->dm_timer, - pwm_get_polarity(pwm) == PWM_POLARITY_INVERSED, - true, OMAP_TIMER_TRIGGER_OVERFLOW_AND_COMPARE, - true); - /* If config was called while timer was running it must be reenabled. */ if (timer_active) pwm_omap_dmtimer_start(omap); -- 2.23.0
next prev parent reply other threads:[~2020-03-12 4:23 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-12 4:22 [PATCH v3 0/5] pwm: omap-dmtimer: Allow for dynamic pwm period updates Lokesh Vutla 2020-03-12 4:22 ` Lokesh Vutla 2020-03-12 4:22 ` [PATCH v3 1/5] pwm: omap-dmtimer: Drop unused header file Lokesh Vutla 2020-03-12 4:22 ` Lokesh Vutla 2020-03-12 6:35 ` Uwe Kleine-König 2020-03-12 4:22 ` [PATCH v3 2/5] pwm: omap-dmtimer: Update description for pwm omap dm timer Lokesh Vutla 2020-03-12 4:22 ` Lokesh Vutla 2020-03-12 6:35 ` Uwe Kleine-König 2020-03-12 4:22 ` Lokesh Vutla [this message] 2020-03-12 4:22 ` [PATCH v3 3/5] pwm: omap-dmtimer: Fix pwm enabling sequence Lokesh Vutla 2020-03-12 4:22 ` [PATCH v3 4/5] pwm: omap-dmtimer: Do not disable pwm before changing period/duty_cycle Lokesh Vutla 2020-03-12 4:22 ` Lokesh Vutla 2020-03-12 6:40 ` Uwe Kleine-König 2020-03-12 8:05 ` Lokesh Vutla 2020-03-12 8:05 ` Lokesh Vutla 2020-03-12 8:47 ` Uwe Kleine-König 2020-03-12 10:44 ` Lokesh Vutla 2020-03-12 10:44 ` Lokesh Vutla 2020-03-12 14:21 ` Richard Cochran 2020-03-12 17:14 ` Lokesh Vutla 2020-03-18 4:40 ` Lokesh Vutla 2020-03-18 4:40 ` Lokesh Vutla 2020-03-30 14:14 ` Thierry Reding 2020-03-30 19:16 ` Uwe Kleine-König 2020-03-31 20:45 ` Thierry Reding 2020-04-01 8:22 ` Uwe Kleine-König 2020-04-01 10:22 ` Lokesh Vutla 2020-04-01 10:22 ` Lokesh Vutla 2020-04-01 11:47 ` Uwe Kleine-König 2020-04-01 18:39 ` Thierry Reding 2020-04-01 20:36 ` Uwe Kleine-König 2020-04-01 18:28 ` Thierry Reding 2020-04-01 20:31 ` Uwe Kleine-König 2020-04-01 21:37 ` Thierry Reding 2020-04-02 14:02 ` Uwe Kleine-König 2020-04-03 8:51 ` Lokesh Vutla 2020-04-03 8:51 ` Lokesh Vutla 2020-04-03 13:59 ` Uwe Kleine-König 2020-03-31 15:29 ` Lokesh Vutla 2020-03-31 15:29 ` Lokesh Vutla 2020-03-31 20:10 ` Thierry Reding 2020-04-01 10:15 ` Lokesh Vutla 2020-03-12 4:22 ` [PATCH v3 5/5] pwm: omap-dmtimer: Implement .apply callback Lokesh Vutla 2020-03-12 4:22 ` Lokesh Vutla 2020-03-13 15:31 ` Tony Lindgren 2020-03-23 11:30 ` [PATCH v3 0/5] pwm: omap-dmtimer: Allow for dynamic pwm period updates Lokesh Vutla 2020-03-23 11:30 ` Lokesh Vutla 2020-03-30 14:04 ` Thierry Reding
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200312042210.17344-4-lokeshvutla@ti.com \ --to=lokeshvutla@ti.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=nsekhar@ti.com \ --cc=thierry.reding@gmail.com \ --cc=tony@atomide.com \ --cc=u.kleine-koenig@pengutronix.de \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.