All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>
Subject: [PATCH v2 02/10] ASoC: Intel: sof_pcm512x: drop reverse deps for SND_HDA_CODEC_HDMI
Date: Thu, 12 Mar 2020 14:48:51 -0500	[thread overview]
Message-ID: <20200312194859.4051-3-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20200312194859.4051-1-pierre-louis.bossart@linux.intel.com>

From: Kai Vehmanen <kai.vehmanen@linux.intel.com>

Having a reverse dependency to a config that has its own additional
dependencies, is generally not recommended. And this applies to
select statements for SND_HDA_CODEC_HDMI, e.g. the case where SND_HDA
and SND_SOC_SOF_HDA are built as modules, but the machine driver is
built-in, leading to compile errors (reported as
i386-randconfig-e003-20200206).

Give up on trying to define different dependencies based on SOF/SST
selection, and simply add a "depends on" for SND_HDA_CODEC_HDMI. This
fixes the issue with randconfigs. Only downside is that SND_HDA_CODEC_HDMI
may be built unnecessarily in some cases, but this seems like the lesser
evil.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/intel/boards/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig
index 67d85a7be559..6833ef548710 100644
--- a/sound/soc/intel/boards/Kconfig
+++ b/sound/soc/intel/boards/Kconfig
@@ -464,8 +464,8 @@ config SND_SOC_INTEL_SOF_PCM512x_MACH
 	depends on I2C && ACPI
 	depends on (SND_SOC_SOF_HDA_AUDIO_CODEC && (MFD_INTEL_LPSS || COMPILE_TEST)) ||\
 		   (SND_SOC_SOF_BAYTRAIL && (X86_INTEL_LPSS || COMPILE_TEST))
+	depends on SND_HDA_CODEC_HDMI
 	select SND_SOC_PCM512x_I2C
-	select SND_HDA_CODEC_HDMI if SND_SOC_SOF_HDA_AUDIO_CODEC
 	help
 	  This adds support for ASoC machine driver for SOF platforms
 	  with TI PCM512x I2S audio codec.
-- 
2.20.1


  parent reply	other threads:[~2020-03-12 19:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-12 19:48 [PATCH v2 00/10] ASoC: Intel: machine driver updates for 5.7 Pierre-Louis Bossart
2020-03-12 19:48 ` [PATCH v2 01/10] ASoC: Intel: boards: drop reverse deps for SND_HDA_CODEC_HDMI Pierre-Louis Bossart
2020-03-12 19:48 ` Pierre-Louis Bossart [this message]
2020-03-12 19:48 ` [PATCH v2 03/10] ASoC: Intel: sof_pcm512x: make HDMI optional for all platforms Pierre-Louis Bossart
2020-03-12 19:48 ` [PATCH v2 04/10] ASoC: SOF: Intel: hda: remove SND_SOC_SOF_HDA_COMMON_HDMI_CODEC Pierre-Louis Bossart
2020-03-12 19:48 ` [PATCH v2 05/10] ASoC: codecs: hdac_hdmi: (cosmetic) remove redundant variable initialisations Pierre-Louis Bossart
2020-03-15 20:05   ` Cezary Rojewski
2020-03-12 19:48 ` [PATCH v2 06/10] ASoC: Intel: skylake: " Pierre-Louis Bossart
2020-03-12 19:48 ` [PATCH v2 07/10] ASoC: Intel: (cosmetic) simplify structure member access Pierre-Louis Bossart
2020-03-15 19:59   ` Cezary Rojewski
2020-03-12 19:48 ` [PATCH v2 08/10] ASoC: Intel: sof_da7219_max98373: Add support for max98360a speaker amp Pierre-Louis Bossart
2020-03-12 19:48 ` [PATCH v2 09/10] ASoC: Intel: sof_rt5682: Add rt1015 speaker amp support Pierre-Louis Bossart
2020-03-13 16:17   ` Applied "ASoC: Intel: sof_rt5682: Add rt1015 speaker amp support" to the asoc tree Mark Brown
2020-03-12 19:48 ` [PATCH v2 10/10] ASoC: Intel: don't use GFP_ATOMIC for machine driver contexts Pierre-Louis Bossart
2020-03-13 16:17   ` Applied "ASoC: Intel: don't use GFP_ATOMIC for machine driver contexts" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200312194859.4051-3-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.