All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: lee.jones@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com,
	a.zummo@towertech.it, alexandre.belloni@bootlin.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-rtc@vger.kernel.org, stefan@agner.ch, b.galvani@gmail.com,
	phh@phh.me, letux-kernel@openphoenux.org, knaack.h@gmx.de,
	lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
	jic23@kernel.org
Cc: Andreas Kemnade <andreas@kemnade.info>
Subject: [PATCH RESEND v6 7/7] mfd: rn5t618: cleanup i2c_device_id
Date: Fri, 13 Mar 2020 07:45:34 +0100	[thread overview]
Message-ID: <20200313064535.31503-8-andreas@kemnade.info> (raw)
In-Reply-To: <20200313064535.31503-1-andreas@kemnade.info>

That list was just empty, so it can be removed if .probe_new
instead of .probe is used

Suggested-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
Functional independent from the other patches, but since they are
touching similar areas, commit/merge conflicts would occur.
 drivers/mfd/rn5t618.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618.c
index 321836f78120..b8033e2d650f 100644
--- a/drivers/mfd/rn5t618.c
+++ b/drivers/mfd/rn5t618.c
@@ -153,8 +153,7 @@ static const struct of_device_id rn5t618_of_match[] = {
 };
 MODULE_DEVICE_TABLE(of, rn5t618_of_match);
 
-static int rn5t618_i2c_probe(struct i2c_client *i2c,
-			     const struct i2c_device_id *id)
+static int rn5t618_i2c_probe(struct i2c_client *i2c)
 {
 	const struct of_device_id *of_id;
 	struct rn5t618 *priv;
@@ -256,11 +255,6 @@ static int __maybe_unused rn5t618_i2c_resume(struct device *dev)
 	return 0;
 }
 
-static const struct i2c_device_id rn5t618_i2c_id[] = {
-	{ }
-};
-MODULE_DEVICE_TABLE(i2c, rn5t618_i2c_id);
-
 static SIMPLE_DEV_PM_OPS(rn5t618_i2c_dev_pm_ops,
 			rn5t618_i2c_suspend,
 			rn5t618_i2c_resume);
@@ -271,9 +265,8 @@ static struct i2c_driver rn5t618_i2c_driver = {
 		.of_match_table = of_match_ptr(rn5t618_of_match),
 		.pm = &rn5t618_i2c_dev_pm_ops,
 	},
-	.probe = rn5t618_i2c_probe,
+	.probe_new = rn5t618_i2c_probe,
 	.remove = rn5t618_i2c_remove,
-	.id_table = rn5t618_i2c_id,
 };
 
 module_i2c_driver(rn5t618_i2c_driver);
-- 
2.20.1


      parent reply	other threads:[~2020-03-13  6:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-13  6:45 [PATCH RESEND v6 0/7] mfd: rn5t618: Add RTC/ADC support Andreas Kemnade
2020-03-13  6:45 ` [PATCH RESEND v6 1/7] dt-bindings: mfd: rn5t618: Document optional property interrupts Andreas Kemnade
2020-03-13  6:45 ` [PATCH RESEND v6 2/7] mfd: rn5t618: add IRQ support Andreas Kemnade
2020-03-19 16:11   ` Lee Jones
2020-03-19 17:22     ` Andreas Kemnade
2020-03-19 22:40     ` Andreas Kemnade
2020-03-13  6:45 ` [PATCH RESEND v6 3/7] mfd: rn5t618: add RTC related registers Andreas Kemnade
2020-03-13  6:45 ` [PATCH RESEND v6 4/7] mfd: rn5t618: add more subdevices Andreas Kemnade
2020-03-13  6:45 ` [PATCH RESEND v6 5/7] rtc: rc5t619: add Ricoh RC5T619 RTC driver Andreas Kemnade
2020-03-13  6:45 ` [PATCH RESEND v6 6/7] iio: adc: rn5t618: Add ADC driver for RN5T618/RC5T619 Andreas Kemnade
2020-03-13  6:45 ` Andreas Kemnade [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200313064535.31503-8-andreas@kemnade.info \
    --to=andreas@kemnade.info \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=b.galvani@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=lee.jones@linaro.org \
    --cc=letux-kernel@openphoenux.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=phh@phh.me \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.