From: Tero Kristo <t-kristo@ti.com> To: bjorn.andersson@linaro.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org, s-anna@ti.com, afd@ti.com, Tero Kristo <t-kristo@ti.com> Subject: [PATCHv8 06/15] remoteproc/omap: Initialize and assign reserved memory node Date: Fri, 13 Mar 2020 10:17:09 +0200 [thread overview] Message-ID: <20200313081718.30612-7-t-kristo@ti.com> (raw) In-Reply-To: <20200313081718.30612-1-t-kristo@ti.com> From: Suman Anna <s-anna@ti.com> The reserved memory nodes are not assigned to platform devices by default in the driver core to avoid the lookup for every platform device and incur a penalty as the real users are expected to be only a few devices. OMAP remoteproc devices fall into the above category and the OMAP remoteproc driver _requires_ specific CMA pools to be assigned for each device at the moment to align on the location of the vrings and vring buffers in the RTOS-side firmware images. So, use the of_reserved_mem_device_init/release() API appropriately to assign the corresponding reserved memory region to the OMAP remoteproc device. Note that only one region per device is allowed by the framework. Signed-off-by: Suman Anna <s-anna@ti.com> Signed-off-by: Tero Kristo <t-kristo@ti.com> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Reviewed-by: Andrew F. Davis <afd@ti.com> Acked-by: Mathieu Poirier <mathieu.poirier@linaro.org> --- drivers/remoteproc/omap_remoteproc.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c index 9a82d5c4a06b..b010e0607d5f 100644 --- a/drivers/remoteproc/omap_remoteproc.c +++ b/drivers/remoteproc/omap_remoteproc.c @@ -17,6 +17,7 @@ #include <linux/module.h> #include <linux/err.h> #include <linux/of_device.h> +#include <linux/of_reserved_mem.h> #include <linux/platform_device.h> #include <linux/dma-mapping.h> #include <linux/remoteproc.h> @@ -486,14 +487,23 @@ static int omap_rproc_probe(struct platform_device *pdev) if (ret) goto free_rproc; + ret = of_reserved_mem_device_init(&pdev->dev); + if (ret) { + dev_warn(&pdev->dev, "device does not have specific CMA pool.\n"); + dev_warn(&pdev->dev, "Typically this should be provided,\n"); + dev_warn(&pdev->dev, "only omit if you know what you are doing.\n"); + } + platform_set_drvdata(pdev, rproc); ret = rproc_add(rproc); if (ret) - goto free_rproc; + goto release_mem; return 0; +release_mem: + of_reserved_mem_device_release(&pdev->dev); free_rproc: rproc_free(rproc); return ret; @@ -505,6 +515,7 @@ static int omap_rproc_remove(struct platform_device *pdev) rproc_del(rproc); rproc_free(rproc); + of_reserved_mem_device_release(&pdev->dev); return 0; } -- 2.17.1 -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
WARNING: multiple messages have this Message-ID (diff)
From: Tero Kristo <t-kristo@ti.com> To: <bjorn.andersson@linaro.org>, <ohad@wizery.com>, <linux-remoteproc@vger.kernel.org> Cc: <linux-kernel@vger.kernel.org>, <mathieu.poirier@linaro.org>, <s-anna@ti.com>, <afd@ti.com>, Tero Kristo <t-kristo@ti.com> Subject: [PATCHv8 06/15] remoteproc/omap: Initialize and assign reserved memory node Date: Fri, 13 Mar 2020 10:17:09 +0200 [thread overview] Message-ID: <20200313081718.30612-7-t-kristo@ti.com> (raw) In-Reply-To: <20200313081718.30612-1-t-kristo@ti.com> From: Suman Anna <s-anna@ti.com> The reserved memory nodes are not assigned to platform devices by default in the driver core to avoid the lookup for every platform device and incur a penalty as the real users are expected to be only a few devices. OMAP remoteproc devices fall into the above category and the OMAP remoteproc driver _requires_ specific CMA pools to be assigned for each device at the moment to align on the location of the vrings and vring buffers in the RTOS-side firmware images. So, use the of_reserved_mem_device_init/release() API appropriately to assign the corresponding reserved memory region to the OMAP remoteproc device. Note that only one region per device is allowed by the framework. Signed-off-by: Suman Anna <s-anna@ti.com> Signed-off-by: Tero Kristo <t-kristo@ti.com> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Reviewed-by: Andrew F. Davis <afd@ti.com> Acked-by: Mathieu Poirier <mathieu.poirier@linaro.org> --- drivers/remoteproc/omap_remoteproc.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c index 9a82d5c4a06b..b010e0607d5f 100644 --- a/drivers/remoteproc/omap_remoteproc.c +++ b/drivers/remoteproc/omap_remoteproc.c @@ -17,6 +17,7 @@ #include <linux/module.h> #include <linux/err.h> #include <linux/of_device.h> +#include <linux/of_reserved_mem.h> #include <linux/platform_device.h> #include <linux/dma-mapping.h> #include <linux/remoteproc.h> @@ -486,14 +487,23 @@ static int omap_rproc_probe(struct platform_device *pdev) if (ret) goto free_rproc; + ret = of_reserved_mem_device_init(&pdev->dev); + if (ret) { + dev_warn(&pdev->dev, "device does not have specific CMA pool.\n"); + dev_warn(&pdev->dev, "Typically this should be provided,\n"); + dev_warn(&pdev->dev, "only omit if you know what you are doing.\n"); + } + platform_set_drvdata(pdev, rproc); ret = rproc_add(rproc); if (ret) - goto free_rproc; + goto release_mem; return 0; +release_mem: + of_reserved_mem_device_release(&pdev->dev); free_rproc: rproc_free(rproc); return ret; @@ -505,6 +515,7 @@ static int omap_rproc_remove(struct platform_device *pdev) rproc_del(rproc); rproc_free(rproc); + of_reserved_mem_device_release(&pdev->dev); return 0; } -- 2.17.1 -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-03-13 8:17 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-13 8:17 [PATCHv8 00/15] remoteproc: updates for omap remoteproc support Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-13 8:17 ` [PATCHv8 01/15] dt-bindings: remoteproc: Add OMAP remoteproc bindings Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-13 8:17 ` [PATCHv8 02/15] remoteproc/omap: Add device tree support Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-13 8:17 ` [PATCHv8 03/15] remoteproc/omap: Add a sanity check for DSP boot address alignment Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-14 0:43 ` [PATCHv8 RESEND " Suman Anna 2020-03-14 0:43 ` Suman Anna 2020-03-20 20:34 ` Mathieu Poirier 2020-03-20 21:38 ` Suman Anna 2020-03-20 21:38 ` Suman Anna 2020-03-13 8:17 ` [PATCHv8 04/15] remoteproc/omap: Add support to parse internal memories from DT Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-13 8:17 ` [PATCHv8 05/15] remoteproc/omap: Add the rproc ops .da_to_va() implementation Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-14 0:43 ` [PATCHv8 RESEND " Suman Anna 2020-03-14 0:43 ` Suman Anna 2020-03-13 8:17 ` Tero Kristo [this message] 2020-03-13 8:17 ` [PATCHv8 06/15] remoteproc/omap: Initialize and assign reserved memory node Tero Kristo 2020-03-13 8:17 ` [PATCHv8 07/15] remoteproc/omap: Add support for DRA7xx remote processors Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-13 8:17 ` [PATCHv8 08/15] remoteproc/omap: Remove the platform_data header Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-13 8:17 ` [PATCHv8 09/15] remoteproc/omap: Check for undefined mailbox messages Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-13 8:17 ` [PATCHv8 10/15] remoteproc/omap: Request a timer(s) for remoteproc usage Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-13 8:17 ` [PATCHv8 11/15] remoteproc/omap: Add support for system suspend/resume Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-13 8:17 ` [PATCHv8 12/15] remoteproc/omap: Add support for runtime auto-suspend/resume Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-20 20:23 ` Mathieu Poirier 2020-03-13 8:17 ` [PATCHv8 13/15] remoteproc/omap: Report device exceptions and trigger recovery Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-13 8:17 ` [PATCHv8 14/15] remoteproc/omap: Add watchdog functionality for remote processors Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-20 20:32 ` Mathieu Poirier 2020-03-20 21:48 ` Suman Anna 2020-03-20 21:48 ` Suman Anna 2020-03-23 15:14 ` Mathieu Poirier 2020-03-13 8:17 ` [PATCHv8 15/15] remoteproc/omap: Switch to SPDX license identifiers Tero Kristo 2020-03-13 8:17 ` Tero Kristo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200313081718.30612-7-t-kristo@ti.com \ --to=t-kristo@ti.com \ --cc=afd@ti.com \ --cc=bjorn.andersson@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=mathieu.poirier@linaro.org \ --cc=ohad@wizery.com \ --cc=s-anna@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.