All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Rodriguez <danielcrodriguez2012@gmail.com>
To: eric@anholt.net, airlied@linux.ie, daniel@ffwll.ch,
	dri-devel@lists.freedesktop.org
Cc: Daniel Rodriguez <danielcrodriguez2012@gmail.com>
Subject: [PATCH] drm/v3d: fix Kconfig ARCH_BCMSTB typo preventing compile
Date: Sun, 15 Mar 2020 21:42:33 +0000	[thread overview]
Message-ID: <20200315214233.14211-1-danielcrodriguez2012@gmail.com> (raw)

The Kconfig for v3d includes a depend on ARCH_BRCMSTB. It is misspelled;
as ARCH_BCMSTB. This misspelling makes CONFIG_DRM_V3D not show up at all
on Linux menuconfig and breaks manual kernel compilation with
it manually set in .config (during compile CONFIG_DRM_V3D is transparently
removed as the non-existent depend is not satisfied)

Thus, v3d will (transparently) never compile into a kernel, even if
forcibly enabled in .config.

This patch corrects the typo, thus fixing menuconfig and kernel
compilation with v3d.

Signed-off-by: Daniel Rodriguez <danielcrodriguez2012@gmail.com>
---
 drivers/gpu/drm/v3d/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/v3d/Kconfig b/drivers/gpu/drm/v3d/Kconfig
index 9a5c44606337..e973ec487484 100644
--- a/drivers/gpu/drm/v3d/Kconfig
+++ b/drivers/gpu/drm/v3d/Kconfig
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config DRM_V3D
 	tristate "Broadcom V3D 3.x and newer"
-	depends on ARCH_BCM || ARCH_BCMSTB || COMPILE_TEST
+	depends on ARCH_BCM || ARCH_BRCMSTB || COMPILE_TEST
 	depends on DRM
 	depends on COMMON_CLK
 	depends on MMU
-- 
2.25.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2020-03-15 23:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-15 21:42 Daniel Rodriguez [this message]
2020-03-15 22:54 [PATCH] drm/v3d: fix Kconfig ARCH_BCMSTB typo preventing compile Daniel Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200315214233.14211-1-danielcrodriguez2012@gmail.com \
    --to=danielcrodriguez2012@gmail.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.