All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: marcandre.lureau@gmail.com, mdroth@linux.vnet.ibm.com,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PATCH v4 18/34] qapi/schema: Rename QAPISchemaObjectType{Variant, Variants}
Date: Tue, 17 Mar 2020 12:54:43 +0100	[thread overview]
Message-ID: <20200317115459.31821-19-armbru@redhat.com> (raw)
In-Reply-To: <20200317115459.31821-1-armbru@redhat.com>

QAPISchemaObjectTypeVariants represents both object type and alternate
type variants.  Rename to QAPISchemaVariants.

Rename QAPISchemaObjectTypeVariant the same way.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 scripts/qapi/schema.py | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py
index 0acf8b466f..033c84c4a0 100644
--- a/scripts/qapi/schema.py
+++ b/scripts/qapi/schema.py
@@ -338,7 +338,7 @@ class QAPISchemaObjectType(QAPISchemaType):
             assert isinstance(m, QAPISchemaObjectTypeMember)
             m.set_defined_in(name)
         if variants is not None:
-            assert isinstance(variants, QAPISchemaObjectTypeVariants)
+            assert isinstance(variants, QAPISchemaVariants)
             variants.set_defined_in(name)
         self._base_name = base
         self.base = None
@@ -449,7 +449,7 @@ class QAPISchemaAlternateType(QAPISchemaType):
 
     def __init__(self, name, info, doc, ifcond, features, variants):
         super().__init__(name, info, doc, ifcond, features)
-        assert isinstance(variants, QAPISchemaObjectTypeVariants)
+        assert isinstance(variants, QAPISchemaVariants)
         assert variants.tag_member
         variants.set_defined_in(name)
         variants.tag_member.set_defined_in(self.name)
@@ -512,7 +512,7 @@ class QAPISchemaAlternateType(QAPISchemaType):
             self.name, self.info, self.ifcond, self.features, self.variants)
 
 
-class QAPISchemaObjectTypeVariants:
+class QAPISchemaVariants:
     def __init__(self, tag_name, info, tag_member, variants):
         # Flat unions pass tag_name but not tag_member.
         # Simple unions and alternates pass tag_member but not tag_name.
@@ -522,7 +522,7 @@ class QAPISchemaObjectTypeVariants:
         assert (isinstance(tag_name, str) or
                 isinstance(tag_member, QAPISchemaObjectTypeMember))
         for v in variants:
-            assert isinstance(v, QAPISchemaObjectTypeVariant)
+            assert isinstance(v, QAPISchemaVariant)
         self._tag_name = tag_name
         self.info = info
         self.tag_member = tag_member
@@ -572,8 +572,8 @@ class QAPISchemaObjectTypeVariants:
             cases = {v.name for v in self.variants}
             for m in self.tag_member.type.members:
                 if m.name not in cases:
-                    v = QAPISchemaObjectTypeVariant(m.name, self.info,
-                                                    'q_empty', m.ifcond)
+                    v = QAPISchemaVariant(m.name, self.info,
+                                          'q_empty', m.ifcond)
                     v.set_defined_in(self.tag_member.defined_in)
                     self.variants.append(v)
         if not self.variants:
@@ -681,7 +681,7 @@ class QAPISchemaObjectTypeMember(QAPISchemaMember):
                                         self.describe)
 
 
-class QAPISchemaObjectTypeVariant(QAPISchemaObjectTypeMember):
+class QAPISchemaVariant(QAPISchemaObjectTypeMember):
     role = 'branch'
 
     def __init__(self, name, info, typ, ifcond=None):
@@ -987,7 +987,7 @@ class QAPISchema:
             None))
 
     def _make_variant(self, case, typ, ifcond, info):
-        return QAPISchemaObjectTypeVariant(case, info, typ, ifcond)
+        return QAPISchemaVariant(case, info, typ, ifcond)
 
     def _make_simple_variant(self, case, typ, ifcond, info):
         if isinstance(typ, list):
@@ -996,7 +996,7 @@ class QAPISchema:
         typ = self._make_implicit_object_type(
             typ, info, self.lookup_type(typ),
             'wrapper', [self._make_member('data', typ, None, info)])
-        return QAPISchemaObjectTypeVariant(case, info, typ, ifcond)
+        return QAPISchemaVariant(case, info, typ, ifcond)
 
     def _def_union_type(self, expr, info, doc):
         name = expr['union']
@@ -1026,7 +1026,7 @@ class QAPISchema:
         self._def_entity(
             QAPISchemaObjectType(name, info, doc, ifcond, features,
                                  base, members,
-                                 QAPISchemaObjectTypeVariants(
+                                 QAPISchemaVariants(
                                      tag_name, info, tag_member, variants)))
 
     def _def_alternate_type(self, expr, info, doc):
@@ -1040,7 +1040,7 @@ class QAPISchema:
         tag_member = QAPISchemaObjectTypeMember('type', info, 'QType', False)
         self._def_entity(
             QAPISchemaAlternateType(name, info, doc, ifcond, features,
-                                    QAPISchemaObjectTypeVariants(
+                                    QAPISchemaVariants(
                                         None, info, tag_member, variants)))
 
     def _def_command(self, expr, info, doc):
-- 
2.21.1



  parent reply	other threads:[~2020-03-17 12:05 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-17 11:54 [PATCH v4 00/34] Configurable policy for handling deprecated interfaces Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 01/34] qemu-doc: Belatedly document QMP command arg & result deprecation Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 02/34] qapi: Belatedly update doc comment for @wait deprecation Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 03/34] docs/devel/qapi-code-gen: Clarify allow-oob introspection Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 04/34] docs/devel/qapi-code-gen: Document 'features' introspection Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 05/34] tests/test-qmp-cmds: Factor out qmp_dispatch() test helpers Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 06/34] tests/test-qmp-cmds: Check responses more thoroughly Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 07/34] tests/test-qmp-cmds: Simplify test data setup Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 08/34] tests/test-qmp-event: " Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 09/34] tests/test-qmp-event: Use qobject_is_equal() Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 10/34] tests/test-qmp-event: Check event is actually emitted Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 11/34] qapi/schema: Clean up around QAPISchemaEntity.connect_doc() Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 12/34] qapi: Add feature flags to remaining definitions Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 13/34] qapi: Consistently put @features parameter right after @ifcond Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 14/34] qapi/introspect: Rename *qlit* to reduce confusion Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 15/34] qapi/introspect: Factor out _make_tree() Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 16/34] qapi/schema: Change _make_features() to a take feature list Markus Armbruster
2020-03-17 20:22   ` Eric Blake
2020-03-17 11:54 ` [PATCH v4 17/34] qapi/schema: Reorder classes so related ones are together Markus Armbruster
2020-03-17 11:54 ` Markus Armbruster [this message]
2020-03-17 11:54 ` [PATCH v4 19/34] qapi/schema: Call QAPIDoc.connect_member() in just one place Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 20/34] qapi: Add feature flags to struct members Markus Armbruster
2020-03-17 20:27   ` Eric Blake
2020-03-17 11:54 ` [PATCH v4 21/34] qapi: Inline do_qmp_dispatch() into qmp_dispatch() Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 22/34] qapi: Simplify how qmp_dispatch() deals with QCO_NO_SUCCESS_RESP Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 23/34] qapi: Simplify how qmp_dispatch() gets the request ID Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 24/34] qapi: Replace qmp_dispatch()'s TODO comment by an explanation Markus Armbruster
2020-03-17 20:29   ` Eric Blake
2020-03-17 11:54 ` [PATCH v4 25/34] qapi: New special feature flag "deprecated" Markus Armbruster
2020-03-17 20:32   ` Eric Blake
2020-03-17 20:40     ` Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 26/34] qapi: Mark deprecated QMP parts with feature 'deprecated' Markus Armbruster
2020-03-17 20:40   ` Eric Blake
2020-03-17 11:54 ` [PATCH v4 27/34] qemu-options: New -compat to set policy for deprecated interfaces Markus Armbruster
2020-03-17 21:05   ` Eric Blake
2020-03-18  6:59     ` Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 28/34] qapi: Implement deprecated-output=hide for QMP command results Markus Armbruster
2020-03-18 10:40   ` Eric Blake
2020-03-18 16:47     ` Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 29/34] qapi: Implement deprecated-output=hide for QMP events Markus Armbruster
2020-03-18 12:29   ` Eric Blake
2020-03-18 16:59     ` Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 30/34] qapi: Implement deprecated-output=hide for QMP event data Markus Armbruster
2020-03-18 15:20   ` Eric Blake
2020-03-18 17:01     ` Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 31/34] qapi: Implement deprecated-output=hide for QMP introspection Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 32/34] qapi: Implement deprecated-input=reject for QMP commands Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 33/34] qapi: Implement deprecated-input=reject for QMP command arguments Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 34/34] qapi: New -compat deprecated-input=crash Markus Armbruster
2020-03-17 13:10 ` [PATCH v4 00/34] Configurable policy for handling deprecated interfaces Marc-André Lureau
2020-03-17 15:32   ` Markus Armbruster
2020-03-17 20:58 ` Markus Armbruster
2020-05-04  8:24 ` Peter Krempa
2020-05-08 13:01   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200317115459.31821-19-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.