All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: marcandre.lureau@gmail.com, mdroth@linux.vnet.ibm.com
Subject: [PATCH v4 01/34] qemu-doc: Belatedly document QMP command arg & result deprecation
Date: Tue, 17 Mar 2020 12:54:26 +0100	[thread overview]
Message-ID: <20200317115459.31821-2-armbru@redhat.com> (raw)
In-Reply-To: <20200317115459.31821-1-armbru@redhat.com>

A number of deprecated QMP arguments and results were missed in commit
eb22aeca65 "docs: document deprecation policy & deprecated features in
appendix" (v2.10.0):

* Commit b33945cfff "block: Accept device model name for
  blockdev-open/close-tray" (v2.8.0) deprecated blockdev-open-tray,
  blockdev-close-tray argument @device.

* Commit fbe2d8163e "block: Accept device model name for eject"
  (v2.8.0) deprecated eject argument @device.

* Commit 70e2cb3bd7 "block: Accept device model name for
  blockdev-change-medium" (v2.8.0) deprecated blockdev-change-medium
  argument @device.

* Commit 7a9877a026 "block: Accept device model name for
  block_set_io_throttle" (v2.8.0) deprecated block_set_io_throttle
  argument @device.

* Commit c01c214b69 "block: remove all encryption handling APIs"
  (v2.10.0) deprecated query-named-block-nodes result
  @encryption_key_missing and query-block result @inserted member
  @encryption_key_missing.

* Commit c42e8742f5 "block: Use JSON null instead of "" to disable
  backing file" (v2.10.0) deprecated blockdev-add empty string
  argument @backing.

Since then, we missed a few more:

* Commit 3c605f4074 "commit: Add top-node/base-node options" (v3.1.0)
  deprecated block-commit arguments @base and @top.

* Commit 4db6ceb0b5 "block/dirty-bitmap: add recording and busy
  properties" (v4.0.0) deprecated query-named-block-nodes result
  @dirty-bitmaps member @status, not just query-block.

Make up for all that.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 docs/system/deprecated.rst | 48 ++++++++++++++++++++++++++++++++++----
 1 file changed, 44 insertions(+), 4 deletions(-)

diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
index 0838338d8f..bfc693e8e0 100644
--- a/docs/system/deprecated.rst
+++ b/docs/system/deprecated.rst
@@ -180,27 +180,67 @@ QEMU Machine Protocol (QMP) commands
 
 Use ``blockdev-change-medium`` or ``change-vnc-password`` instead.
 
+``blockdev-open-tray``, ``blockdev-close-tray`` argument ``device`` (since 2.8.0)
+'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
+
+Use argument ``id`` instead.
+
+``eject`` argument ``device`` (since 2.8.0)
+'''''''''''''''''''''''''''''''''''''''''''
+
+Use argument ``id`` instead.
+
+``blockdev-change-medium`` argument ``device`` (since 2.8.0)
+''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
+
+Use argument ``id`` instead.
+
+``block_set_io_throttle`` argument ``device`` (since 2.8.0)
+'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
+
+Use argument ``id`` instead.
+
 ``migrate_set_downtime`` and ``migrate_set_speed`` (since 2.8.0)
 ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
 
 Use ``migrate-set-parameters`` instead.
 
+``query-named-block-nodes`` result ``encryption_key_missing`` (since 2.10.0)
+''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
+
+Always false.
+
+``query-block`` result ``inserted.encryption_key_missing`` (since 2.10.0)
+'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
+
+Always false.
+
+``blockdev-add`` empty string argument ``backing`` (since 2.10.0)
+'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
+
+Use argument value ``null`` instead.
+
 ``migrate-set-cache-size`` and ``query-migrate-cache-size`` (since 2.11.0)
 ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
 
 Use ``migrate-set-parameters`` and ``query-migrate-parameters`` instead.
 
+``block-commit`` arguments ``base`` and ``top`` (since 3.1.0)
+'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
+
+Use arguments ``base-node`` and ``top-node`` instead.
+
 ``object-add`` option ``props`` (since 5.0)
 '''''''''''''''''''''''''''''''''''''''''''
 
 Specify the properties for the object as top-level arguments instead.
 
-``query-block`` result field ``dirty-bitmaps[i].status`` (since 4.0)
-''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
+``query-named-block-nodes`` and ``query-block`` result dirty-bitmaps[i].status (since 4.0)
+''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
 
 The ``status`` field of the ``BlockDirtyInfo`` structure, returned by
-the query-block command is deprecated. Two new boolean fields,
-``recording`` and ``busy`` effectively replace it.
+these commands is deprecated. Two new boolean fields, ``recording`` and
+``busy`` effectively replace it.
 
 ``query-block`` result field ``dirty-bitmaps`` (Since 4.2)
 ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
-- 
2.21.1



  reply	other threads:[~2020-03-17 11:56 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-17 11:54 [PATCH v4 00/34] Configurable policy for handling deprecated interfaces Markus Armbruster
2020-03-17 11:54 ` Markus Armbruster [this message]
2020-03-17 11:54 ` [PATCH v4 02/34] qapi: Belatedly update doc comment for @wait deprecation Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 03/34] docs/devel/qapi-code-gen: Clarify allow-oob introspection Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 04/34] docs/devel/qapi-code-gen: Document 'features' introspection Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 05/34] tests/test-qmp-cmds: Factor out qmp_dispatch() test helpers Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 06/34] tests/test-qmp-cmds: Check responses more thoroughly Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 07/34] tests/test-qmp-cmds: Simplify test data setup Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 08/34] tests/test-qmp-event: " Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 09/34] tests/test-qmp-event: Use qobject_is_equal() Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 10/34] tests/test-qmp-event: Check event is actually emitted Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 11/34] qapi/schema: Clean up around QAPISchemaEntity.connect_doc() Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 12/34] qapi: Add feature flags to remaining definitions Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 13/34] qapi: Consistently put @features parameter right after @ifcond Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 14/34] qapi/introspect: Rename *qlit* to reduce confusion Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 15/34] qapi/introspect: Factor out _make_tree() Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 16/34] qapi/schema: Change _make_features() to a take feature list Markus Armbruster
2020-03-17 20:22   ` Eric Blake
2020-03-17 11:54 ` [PATCH v4 17/34] qapi/schema: Reorder classes so related ones are together Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 18/34] qapi/schema: Rename QAPISchemaObjectType{Variant, Variants} Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 19/34] qapi/schema: Call QAPIDoc.connect_member() in just one place Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 20/34] qapi: Add feature flags to struct members Markus Armbruster
2020-03-17 20:27   ` Eric Blake
2020-03-17 11:54 ` [PATCH v4 21/34] qapi: Inline do_qmp_dispatch() into qmp_dispatch() Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 22/34] qapi: Simplify how qmp_dispatch() deals with QCO_NO_SUCCESS_RESP Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 23/34] qapi: Simplify how qmp_dispatch() gets the request ID Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 24/34] qapi: Replace qmp_dispatch()'s TODO comment by an explanation Markus Armbruster
2020-03-17 20:29   ` Eric Blake
2020-03-17 11:54 ` [PATCH v4 25/34] qapi: New special feature flag "deprecated" Markus Armbruster
2020-03-17 20:32   ` Eric Blake
2020-03-17 20:40     ` Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 26/34] qapi: Mark deprecated QMP parts with feature 'deprecated' Markus Armbruster
2020-03-17 20:40   ` Eric Blake
2020-03-17 11:54 ` [PATCH v4 27/34] qemu-options: New -compat to set policy for deprecated interfaces Markus Armbruster
2020-03-17 21:05   ` Eric Blake
2020-03-18  6:59     ` Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 28/34] qapi: Implement deprecated-output=hide for QMP command results Markus Armbruster
2020-03-18 10:40   ` Eric Blake
2020-03-18 16:47     ` Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 29/34] qapi: Implement deprecated-output=hide for QMP events Markus Armbruster
2020-03-18 12:29   ` Eric Blake
2020-03-18 16:59     ` Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 30/34] qapi: Implement deprecated-output=hide for QMP event data Markus Armbruster
2020-03-18 15:20   ` Eric Blake
2020-03-18 17:01     ` Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 31/34] qapi: Implement deprecated-output=hide for QMP introspection Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 32/34] qapi: Implement deprecated-input=reject for QMP commands Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 33/34] qapi: Implement deprecated-input=reject for QMP command arguments Markus Armbruster
2020-03-17 11:54 ` [PATCH v4 34/34] qapi: New -compat deprecated-input=crash Markus Armbruster
2020-03-17 13:10 ` [PATCH v4 00/34] Configurable policy for handling deprecated interfaces Marc-André Lureau
2020-03-17 15:32   ` Markus Armbruster
2020-03-17 20:58 ` Markus Armbruster
2020-05-04  8:24 ` Peter Krempa
2020-05-08 13:01   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200317115459.31821-2-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.