From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> To: qemu-devel@nongnu.org Cc: "Kevin Wolf" <kwolf@redhat.com>, vsementsov@virtuozzo.com, "Laszlo Ersek" <lersek@redhat.com>, qemu-block@nongnu.org, "Paul Durrant" <paul@xen.org>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, "Christian Schoenebeck" <qemu_oss@crudebyte.com>, "Greg Kurz" <groug@kaod.org>, armbru@redhat.com, "Stefano Stabellini" <sstabellini@kernel.org>, "Gerd Hoffmann" <kraxel@redhat.com>, "Stefan Hajnoczi" <stefanha@redhat.com>, "Anthony Perard" <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org, "Max Reitz" <mreitz@redhat.com>, "Michael Roth" <mdroth@linux.vnet.ibm.com>, "Stefan Berger" <stefanb@linux.ibm.com> Subject: [PATCH v10 0/9] error: auto propagated local_err part I Date: Tue, 17 Mar 2020 18:16:16 +0300 [thread overview] Message-ID: <20200317151625.20797-1-vsementsov@virtuozzo.com> (raw) v10: (based-on "[PATCH 0/3] Minor error handling cleanups" including my 4/3 in it) 02: Change some comments. Do not chain check1 and check2 rules to rule1 to cover move unusual cases to warn about. Add positions to check1 rule. Move check1 and check2 above rule1, otherwise our ___ hack will break check2 rule. 03: add hunk, due to rebasing and 09: rebased. Change is trivial, I keep r-b. v10 is available at https://src.openvz.org/scm/~vsementsov/qemu.git #tag up-auto-local-err-partI-v10 v9 is available at https://src.openvz.org/scm/~vsementsov/qemu.git #tag up-auto-local-err-partI-v9 In these series, there is no commit-per-subsystem script, each generated commit is generated in separate. Still, generating commands are very similar, and looks like sed -n '/^<Subsystem name>$/,/^$/{s/^F: //p}' MAINTAINERS | \ xargs git ls-files | grep '\.[hc]$' | \ xargs spatch \ --sp-file scripts/coccinelle/auto-propagated-errp.cocci \ --macro-file scripts/cocci-macro-file.h \ --in-place --no-show-diff --max-width 80 Note, that in each generated commit, generation command is the only text, indented by 8 spaces in 'git log -1' output, so, to regenerate all commits (for example, after rebase, or change in coccinelle script), you may use the following command: git rebase -x "sh -c \"git show --pretty= --name-only | xargs git checkout HEAD^ -- ; git reset; git log -1 | grep '^ ' | sh\"" HEAD~7 Which will start automated interactive rebase for generated patches, which will stop if generated patch changed (you may do git commit --amend to apply updated generated changes). Note: git show --pretty= --name-only - lists files, changed in HEAD git log -1 | grep '^ ' | sh - rerun generation command of HEAD Check for compilation of changed .c files git rebase -x "sh -c \"git show --pretty= --name-only | sed -n 's/\.c$/.o/p' | xargs make -j9\"" HEAD~7 Vladimir Sementsov-Ogievskiy (9): error: auto propagated local_err scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE() SD (Secure Card): introduce ERRP_AUTO_PROPAGATE pflash: introduce ERRP_AUTO_PROPAGATE fw_cfg: introduce ERRP_AUTO_PROPAGATE virtio-9p: introduce ERRP_AUTO_PROPAGATE TPM: introduce ERRP_AUTO_PROPAGATE nbd: introduce ERRP_AUTO_PROPAGATE xen: introduce ERRP_AUTO_PROPAGATE scripts/coccinelle/auto-propagated-errp.cocci | 336 ++++++++++++++++++ include/block/nbd.h | 1 + include/qapi/error.h | 208 +++++++++-- block/nbd.c | 21 +- hw/9pfs/9p-local.c | 12 +- hw/9pfs/9p.c | 1 + hw/block/dataplane/xen-block.c | 17 +- hw/block/pflash_cfi01.c | 7 +- hw/block/pflash_cfi02.c | 7 +- hw/block/xen-block.c | 122 +++---- hw/nvram/fw_cfg.c | 14 +- hw/pci-host/xen_igd_pt.c | 7 +- hw/sd/sdhci-pci.c | 7 +- hw/sd/sdhci.c | 21 +- hw/sd/ssi-sd.c | 16 +- hw/tpm/tpm_util.c | 7 +- hw/xen/xen-backend.c | 7 +- hw/xen/xen-bus.c | 92 ++--- hw/xen/xen-host-pci-device.c | 27 +- hw/xen/xen_pt.c | 25 +- hw/xen/xen_pt_config_init.c | 20 +- nbd/client.c | 5 + nbd/server.c | 5 + tpm.c | 7 +- MAINTAINERS | 1 + 25 files changed, 715 insertions(+), 278 deletions(-) create mode 100644 scripts/coccinelle/auto-propagated-errp.cocci Cc: Eric Blake <eblake@redhat.com> Cc: Kevin Wolf <kwolf@redhat.com> Cc: Max Reitz <mreitz@redhat.com> Cc: Greg Kurz <groug@kaod.org> Cc: Christian Schoenebeck <qemu_oss@crudebyte.com> Cc: Stefan Hajnoczi <stefanha@redhat.com> Cc: Stefano Stabellini <sstabellini@kernel.org> Cc: Anthony Perard <anthony.perard@citrix.com> Cc: Paul Durrant <paul@xen.org> Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com> Cc: Laszlo Ersek <lersek@redhat.com> Cc: Gerd Hoffmann <kraxel@redhat.com> Cc: Stefan Berger <stefanb@linux.ibm.com> Cc: Markus Armbruster <armbru@redhat.com> Cc: Michael Roth <mdroth@linux.vnet.ibm.com> Cc: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org Cc: xen-devel@lists.xenproject.org -- 2.21.0
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> To: qemu-devel@nongnu.org Cc: "Kevin Wolf" <kwolf@redhat.com>, vsementsov@virtuozzo.com, "Laszlo Ersek" <lersek@redhat.com>, qemu-block@nongnu.org, "Paul Durrant" <paul@xen.org>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, "Christian Schoenebeck" <qemu_oss@crudebyte.com>, "Greg Kurz" <groug@kaod.org>, armbru@redhat.com, "Stefano Stabellini" <sstabellini@kernel.org>, "Gerd Hoffmann" <kraxel@redhat.com>, "Stefan Hajnoczi" <stefanha@redhat.com>, "Anthony Perard" <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org, "Max Reitz" <mreitz@redhat.com>, "Eric Blake" <eblake@redhat.com>, "Michael Roth" <mdroth@linux.vnet.ibm.com>, "Stefan Berger" <stefanb@linux.ibm.com> Subject: [Xen-devel] [PATCH v10 0/9] error: auto propagated local_err part I Date: Tue, 17 Mar 2020 18:16:16 +0300 [thread overview] Message-ID: <20200317151625.20797-1-vsementsov@virtuozzo.com> (raw) v10: (based-on "[PATCH 0/3] Minor error handling cleanups" including my 4/3 in it) 02: Change some comments. Do not chain check1 and check2 rules to rule1 to cover move unusual cases to warn about. Add positions to check1 rule. Move check1 and check2 above rule1, otherwise our ___ hack will break check2 rule. 03: add hunk, due to rebasing and 09: rebased. Change is trivial, I keep r-b. v10 is available at https://src.openvz.org/scm/~vsementsov/qemu.git #tag up-auto-local-err-partI-v10 v9 is available at https://src.openvz.org/scm/~vsementsov/qemu.git #tag up-auto-local-err-partI-v9 In these series, there is no commit-per-subsystem script, each generated commit is generated in separate. Still, generating commands are very similar, and looks like sed -n '/^<Subsystem name>$/,/^$/{s/^F: //p}' MAINTAINERS | \ xargs git ls-files | grep '\.[hc]$' | \ xargs spatch \ --sp-file scripts/coccinelle/auto-propagated-errp.cocci \ --macro-file scripts/cocci-macro-file.h \ --in-place --no-show-diff --max-width 80 Note, that in each generated commit, generation command is the only text, indented by 8 spaces in 'git log -1' output, so, to regenerate all commits (for example, after rebase, or change in coccinelle script), you may use the following command: git rebase -x "sh -c \"git show --pretty= --name-only | xargs git checkout HEAD^ -- ; git reset; git log -1 | grep '^ ' | sh\"" HEAD~7 Which will start automated interactive rebase for generated patches, which will stop if generated patch changed (you may do git commit --amend to apply updated generated changes). Note: git show --pretty= --name-only - lists files, changed in HEAD git log -1 | grep '^ ' | sh - rerun generation command of HEAD Check for compilation of changed .c files git rebase -x "sh -c \"git show --pretty= --name-only | sed -n 's/\.c$/.o/p' | xargs make -j9\"" HEAD~7 Vladimir Sementsov-Ogievskiy (9): error: auto propagated local_err scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE() SD (Secure Card): introduce ERRP_AUTO_PROPAGATE pflash: introduce ERRP_AUTO_PROPAGATE fw_cfg: introduce ERRP_AUTO_PROPAGATE virtio-9p: introduce ERRP_AUTO_PROPAGATE TPM: introduce ERRP_AUTO_PROPAGATE nbd: introduce ERRP_AUTO_PROPAGATE xen: introduce ERRP_AUTO_PROPAGATE scripts/coccinelle/auto-propagated-errp.cocci | 336 ++++++++++++++++++ include/block/nbd.h | 1 + include/qapi/error.h | 208 +++++++++-- block/nbd.c | 21 +- hw/9pfs/9p-local.c | 12 +- hw/9pfs/9p.c | 1 + hw/block/dataplane/xen-block.c | 17 +- hw/block/pflash_cfi01.c | 7 +- hw/block/pflash_cfi02.c | 7 +- hw/block/xen-block.c | 122 +++---- hw/nvram/fw_cfg.c | 14 +- hw/pci-host/xen_igd_pt.c | 7 +- hw/sd/sdhci-pci.c | 7 +- hw/sd/sdhci.c | 21 +- hw/sd/ssi-sd.c | 16 +- hw/tpm/tpm_util.c | 7 +- hw/xen/xen-backend.c | 7 +- hw/xen/xen-bus.c | 92 ++--- hw/xen/xen-host-pci-device.c | 27 +- hw/xen/xen_pt.c | 25 +- hw/xen/xen_pt_config_init.c | 20 +- nbd/client.c | 5 + nbd/server.c | 5 + tpm.c | 7 +- MAINTAINERS | 1 + 25 files changed, 715 insertions(+), 278 deletions(-) create mode 100644 scripts/coccinelle/auto-propagated-errp.cocci Cc: Eric Blake <eblake@redhat.com> Cc: Kevin Wolf <kwolf@redhat.com> Cc: Max Reitz <mreitz@redhat.com> Cc: Greg Kurz <groug@kaod.org> Cc: Christian Schoenebeck <qemu_oss@crudebyte.com> Cc: Stefan Hajnoczi <stefanha@redhat.com> Cc: Stefano Stabellini <sstabellini@kernel.org> Cc: Anthony Perard <anthony.perard@citrix.com> Cc: Paul Durrant <paul@xen.org> Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com> Cc: Laszlo Ersek <lersek@redhat.com> Cc: Gerd Hoffmann <kraxel@redhat.com> Cc: Stefan Berger <stefanb@linux.ibm.com> Cc: Markus Armbruster <armbru@redhat.com> Cc: Michael Roth <mdroth@linux.vnet.ibm.com> Cc: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org Cc: xen-devel@lists.xenproject.org -- 2.21.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next reply other threads:[~2020-03-17 15:23 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-17 15:16 Vladimir Sementsov-Ogievskiy [this message] 2020-03-17 15:16 ` [Xen-devel] [PATCH v10 0/9] error: auto propagated local_err part I Vladimir Sementsov-Ogievskiy 2020-03-17 15:16 ` [PATCH v10 1/9] error: auto propagated local_err Vladimir Sementsov-Ogievskiy 2020-03-17 15:16 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy 2020-06-10 14:39 ` Greg Kurz 2020-06-10 14:39 ` Greg Kurz 2020-06-15 5:21 ` Markus Armbruster 2020-06-15 6:38 ` Greg Kurz 2020-06-24 16:53 ` Markus Armbruster 2020-06-24 19:48 ` Greg Kurz 2020-03-17 15:16 ` [PATCH v10 2/9] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE() Vladimir Sementsov-Ogievskiy 2020-03-17 15:16 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy 2020-03-20 16:18 ` Markus Armbruster 2020-03-20 16:18 ` [Xen-devel] " Markus Armbruster 2020-03-17 15:16 ` [PATCH v10 3/9] SD (Secure Card): introduce ERRP_AUTO_PROPAGATE Vladimir Sementsov-Ogievskiy 2020-03-17 15:16 ` [PATCH v10 4/9] pflash: " Vladimir Sementsov-Ogievskiy 2020-03-17 15:16 ` [PATCH v10 5/9] fw_cfg: " Vladimir Sementsov-Ogievskiy 2020-03-17 15:16 ` [PATCH v10 6/9] virtio-9p: " Vladimir Sementsov-Ogievskiy 2020-03-17 15:16 ` [PATCH v10 7/9] TPM: " Vladimir Sementsov-Ogievskiy 2020-03-17 15:16 ` [PATCH v10 8/9] nbd: " Vladimir Sementsov-Ogievskiy 2020-03-17 15:16 ` [PATCH v10 9/9] xen: " Vladimir Sementsov-Ogievskiy 2020-03-17 15:16 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200317151625.20797-1-vsementsov@virtuozzo.com \ --to=vsementsov@virtuozzo.com \ --cc=anthony.perard@citrix.com \ --cc=armbru@redhat.com \ --cc=groug@kaod.org \ --cc=kraxel@redhat.com \ --cc=kwolf@redhat.com \ --cc=lersek@redhat.com \ --cc=mdroth@linux.vnet.ibm.com \ --cc=mreitz@redhat.com \ --cc=paul@xen.org \ --cc=philmd@redhat.com \ --cc=qemu-block@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=qemu_oss@crudebyte.com \ --cc=sstabellini@kernel.org \ --cc=stefanb@linux.ibm.com \ --cc=stefanha@redhat.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.