All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cezary Rojewski <cezary.rojewski@intel.com>
To: alsa-devel@alsa-project.org
Cc: pierre-louis.bossart@linux.intel.com,
	Cezary Rojewski <cezary.rojewski@intel.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	lgirdwood@gmail.com, tiwai@suse.com, vkoul@kernel.org,
	broonie@kernel.org
Subject: [PATCH 1/4] ASoC: Intel: broadwell: Remove ignore_suspend flag from SSP0 dai link
Date: Thu, 19 Mar 2020 21:49:44 +0100	[thread overview]
Message-ID: <20200319204947.18963-2-cezary.rojewski@intel.com> (raw)
In-Reply-To: <20200319204947.18963-1-cezary.rojewski@intel.com>

As of commit:
ASoC: soc-core: care .ignore_suspend for Component suspend

function soc-core::snd_soc_suspend no longer ignores 'ignore_suspend'
flag for dai links. While BE dai link for System Pin is
supposed to follow standard suspend-resume flow, appended
'ignore_suspend' flag disturbs that flow and causes audio to break
right after resume. Remove the flag to address this.

Link to first message in conversation:
https://lkml.org/lkml/2020/3/18/54

Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reported-by: Dominik Brodowski <linux@dominikbrodowski.net>
Suggested-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
---
 sound/soc/intel/boards/broadwell.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/intel/boards/broadwell.c b/sound/soc/intel/boards/broadwell.c
index 25178000c6a5..0776ea2d4f36 100644
--- a/sound/soc/intel/boards/broadwell.c
+++ b/sound/soc/intel/boards/broadwell.c
@@ -220,7 +220,6 @@ static struct snd_soc_dai_link broadwell_rt286_dais[] = {
 		.init = broadwell_rt286_codec_init,
 		.dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
 			SND_SOC_DAIFMT_CBS_CFS,
-		.ignore_suspend = 1,
 		.ignore_pmdown_time = 1,
 		.be_hw_params_fixup = broadwell_ssp0_fixup,
 		.ops = &broadwell_rt286_ops,
-- 
2.17.1


  reply	other threads:[~2020-03-19 20:53 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-19 20:49 [PATCH 0/4] ASoC: Intel: boards: Remove ignore_suspend flag from SSP0 dai link Cezary Rojewski
2020-03-19 20:49 ` Cezary Rojewski [this message]
2020-03-30 17:23   ` Applied "ASoC: Intel: broadwell: Remove ignore_suspend flag from SSP0 dai link" to the asoc tree Mark Brown
2020-03-19 20:49 ` [PATCH 2/4] ASoC: Intel: haswell: Remove ignore_suspend flag from SSP0 dai link Cezary Rojewski
2020-03-30 17:23   ` Applied "ASoC: Intel: haswell: Remove ignore_suspend flag from SSP0 dai link" to the asoc tree Mark Brown
2020-03-19 20:49 ` [PATCH 3/4] ASoC: Intel: bdw-rt5677: Remove ignore_suspend flag from SSP0 dai link Cezary Rojewski
2020-03-19 22:14   ` Pierre-Louis Bossart
2020-03-19 22:43     ` Curtis Malainey
2020-03-25 13:28       ` Cezary Rojewski
2020-03-25 14:42         ` Pierre-Louis Bossart
2020-03-30 21:39     ` Hans de Goede
2020-03-30 23:49       ` Pierre-Louis Bossart
2020-03-31 12:15         ` Hans de Goede
2020-03-31 10:28       ` Cezary Rojewski
2020-03-31 10:54         ` Pierre-Louis Bossart
2020-03-31 12:12           ` Hans de Goede
2020-03-31 12:15             ` Pierre-Louis Bossart
2020-04-05 18:10       ` Hans de Goede
2020-04-05 23:11         ` Pierre-Louis Bossart
2020-03-30 17:23   ` Applied "ASoC: Intel: bdw-rt5677: Remove ignore_suspend flag from SSP0 dai link" to the asoc tree Mark Brown
2020-03-19 20:49 ` [PATCH 4/4] ASoC: Intel: bdw-rt5650: Remove ignore_suspend flag from SSP0 dai link Cezary Rojewski
2020-03-30 17:23   ` Applied "ASoC: Intel: bdw-rt5650: Remove ignore_suspend flag from SSP0 dai link" to the asoc tree Mark Brown
2020-03-30 15:40 ` [PATCH 0/4] ASoC: Intel: boards: Remove ignore_suspend flag from SSP0 dai link Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200319204947.18963-2-cezary.rojewski@intel.com \
    --to=cezary.rojewski@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.