All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: sound-open-firmware@alsa-project.org
Subject: [PATCH 05/12] ASoC: SOF: support IPC with immediate response
Date: Fri, 20 Mar 2020 16:40:14 +0100	[thread overview]
Message-ID: <20200320154021.5964-6-guennadi.liakhovetski@linux.intel.com> (raw)
In-Reply-To: <20200320154021.5964-1-guennadi.liakhovetski@linux.intel.com>

Usually when an IPC message is sent, we have to wait for a reply from
the DSP or from the host in the VirtIO case. However, sometimes in
the VirtIO case a response is available immediately. Skip sleeping in
such cases.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
---
 sound/soc/sof/ipc.c |  9 +++++----
 sound/soc/sof/ops.h | 10 +++++++++-
 2 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/sound/soc/sof/ipc.c b/sound/soc/sof/ipc.c
index cf57085..6fa501c1 100644
--- a/sound/soc/sof/ipc.c
+++ b/sound/soc/sof/ipc.c
@@ -262,6 +262,10 @@ int sof_ipc_tx_message_unlocked(struct snd_sof_ipc *ipc, u32 header,
 
 	sdev->msg = msg;
 
+	/*
+	 * If snd_sof_dsp_send_msg() returns a positive number it means, that a
+	 * response is already available, no need to sleep waiting for it
+	 */
 	ret = snd_sof_dsp_send_msg(sdev, msg);
 	/* Next reply that we receive will be related to this message */
 	if (!ret)
@@ -279,10 +283,7 @@ int sof_ipc_tx_message_unlocked(struct snd_sof_ipc *ipc, u32 header,
 	ipc_log_header(sdev->dev, "ipc tx", msg->header);
 
 	/* now wait for completion */
-	if (!ret)
-		ret = tx_wait_done(ipc, msg, reply_data);
-
-	return ret;
+	return tx_wait_done(ipc, msg, reply_data);
 }
 EXPORT_SYMBOL(sof_ipc_tx_message_unlocked);
 
diff --git a/sound/soc/sof/ops.h b/sound/soc/sof/ops.h
index a771500..43bcfbf 100644
--- a/sound/soc/sof/ops.h
+++ b/sound/soc/sof/ops.h
@@ -274,7 +274,15 @@ static inline void snd_sof_dsp_block_write(struct snd_sof_dev *sdev, u32 bar,
 	sof_ops(sdev)->block_write(sdev, bar, offset, src, bytes);
 }
 
-/* ipc */
+/**
+ * snd_sof_dsp_send_msg - call sdev ops to send a message
+ * @sdev:	sdev context
+ * @msg:	message to send
+ *
+ * Returns	< 0 - an error code
+ *		  0 - the message has been sent, wait for a reply
+ *		> 0 - the message has been sent, a reply is already available
+ */
 static inline int snd_sof_dsp_send_msg(struct snd_sof_dev *sdev,
 				       struct snd_sof_ipc_msg *msg)
 {
-- 
1.9.3


  parent reply	other threads:[~2020-03-20 15:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20 15:40 [PATCH 00/12] ASoC: SOF DSP virtualisation Guennadi Liakhovetski
2020-03-20 15:40 ` [PATCH 01/12] ASoC: add function parameters to enable forced path pruning Guennadi Liakhovetski
2020-03-20 15:40 ` [PATCH 02/12] ASoC: SOF: extract firmware-related operation into a function Guennadi Liakhovetski
2020-03-20 15:40 ` [PATCH 03/12] ASoC: SOF: VirtIO: make a function global Guennadi Liakhovetski
2020-03-20 15:40 ` [PATCH 04/12] vhost: convert VHOST_VSOCK_SET_RUNNING to a generic ioctl Guennadi Liakhovetski
2020-03-20 15:40 ` Guennadi Liakhovetski [this message]
2020-03-20 15:40 ` [PATCH 06/12] ASoC: SOF: add a power status IPC Guennadi Liakhovetski
2020-03-20 15:40 ` [PATCH 07/12] ASoC: SOF: add two helper lookup functions Guennadi Liakhovetski
2020-03-20 15:40 ` [PATCH 08/12] ASoC: SOF: add a VirtIO DSP driver Guennadi Liakhovetski
2020-03-20 15:40 ` [PATCH 09/12] ASoC: SOF: add a vhost driver: sound part Guennadi Liakhovetski
2020-03-20 15:40 ` [PATCH 10/12] vhost: add an SOF DSP driver Guennadi Liakhovetski
2020-03-20 15:40 ` [PATCH 11/12] ASoC: SOF: VirtIO: free guest pipelines upon termination Guennadi Liakhovetski
2020-03-20 15:40 ` [PATCH 12/12] ASoC: SOF: VirtIO: enable simultaneous playback and capture Guennadi Liakhovetski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200320154021.5964-6-guennadi.liakhovetski@linux.intel.com \
    --to=guennadi.liakhovetski@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=sound-open-firmware@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.