From: Jeff Layton <jlayton@kernel.org>
To: ceph-devel@vger.kernel.org
Cc: ukernel@gmail.com, idryomov@gmail.com, sage@redhat.com
Subject: [PATCH 0/8] ceph: cap handling code fixes, cleanups and comments
Date: Mon, 23 Mar 2020 12:07:00 -0400 [thread overview]
Message-ID: <20200323160708.104152-1-jlayton@kernel.org> (raw)
I've been going over the cap handling code with an aim toward
simplifying the locking. There's one fix for a potential use-after-free
race in here. This also eliminates a number of __acquires and __releases
annotations by reorganizing the code, and adds some (hopefully helpful)
comments.
There should be no behavioral changes with this set.
Jeff Layton (8):
ceph: reorganize __send_cap for less spinlock abuse
ceph: split up __finish_cap_flush
ceph: add comments for handle_cap_flush_ack logic
ceph: don't release i_ceph_lock in handle_cap_trunc
ceph: don't take i_ceph_lock in handle_cap_import
ceph: document what protects i_dirty_item and i_flushing_item
ceph: fix potential race in ceph_check_caps
ceph: throw a warning if we destroy session with mutex still locked
fs/ceph/caps.c | 292 ++++++++++++++++++++++++-------------------
fs/ceph/mds_client.c | 1 +
fs/ceph/super.h | 4 +-
3 files changed, 170 insertions(+), 127 deletions(-)
--
2.25.1
next reply other threads:[~2020-03-23 16:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 16:07 Jeff Layton [this message]
2020-03-23 16:07 ` [PATCH 1/8] ceph: reorganize __send_cap for less spinlock abuse Jeff Layton
2020-03-24 14:48 ` Yan, Zheng
2020-03-25 10:23 ` Jeff Layton
2020-03-25 13:57 ` [PATCH v2] " Jeff Layton
2020-03-23 16:07 ` [PATCH 2/8] ceph: split up __finish_cap_flush Jeff Layton
2020-03-23 16:07 ` [PATCH 3/8] ceph: add comments for handle_cap_flush_ack logic Jeff Layton
2020-03-23 16:07 ` [PATCH 4/8] ceph: don't release i_ceph_lock in handle_cap_trunc Jeff Layton
2020-03-23 16:07 ` [PATCH 5/8] ceph: don't take i_ceph_lock in handle_cap_import Jeff Layton
2020-03-23 16:07 ` [PATCH 6/8] ceph: document what protects i_dirty_item and i_flushing_item Jeff Layton
2020-03-23 16:07 ` [PATCH 7/8] ceph: fix potential race in ceph_check_caps Jeff Layton
2020-03-26 13:25 ` [PATCH v2] " Jeff Layton
2020-03-23 16:07 ` [PATCH 8/8] ceph: throw a warning if we destroy session with mutex still locked Jeff Layton
2020-03-24 15:05 ` [PATCH 0/8] ceph: cap handling code fixes, cleanups and comments Yan, Zheng
2020-03-31 12:24 ` Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323160708.104152-1-jlayton@kernel.org \
--to=jlayton@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=sage@redhat.com \
--cc=ukernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.