All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Disseldorp <ddiss@suse.de>
To: target-devel@vger.kernel.org
Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
	bvanassche@acm.org, David Disseldorp <ddiss@suse.de>
Subject: [RFC PATCH 1/5] scsi: target: use #def for xcopy descriptor len
Date: Mon, 23 Mar 2020 16:54:06 +0000	[thread overview]
Message-ID: <20200323165410.24423-2-ddiss@suse.de> (raw)
In-Reply-To: <20200323165410.24423-1-ddiss@suse.de>

Signed-off-by: David Disseldorp <ddiss@suse.de>
---
 drivers/target/target_core_xcopy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/target/target_core_xcopy.c b/drivers/target/target_core_xcopy.c
index 425c1070de08..7e5b13da0c20 100644
--- a/drivers/target/target_core_xcopy.c
+++ b/drivers/target/target_core_xcopy.c
@@ -134,7 +134,7 @@ static int target_xcopy_parse_tiddesc_e4(struct se_cmd *se_cmd, struct xcopy_op
 	 * Assigned designator
 	 */
 	desig_len = desc[7];
-	if (desig_len != 16) {
+	if (desig_len != XCOPY_NAA_IEEE_REGEX_LEN) {
 		pr_err("XCOPY 0xe4: invalid desig_len: %d\n", (int)desig_len);
 		return -EINVAL;
 	}
-- 
2.16.4

WARNING: multiple messages have this Message-ID (diff)
From: David Disseldorp <ddiss@suse.de>
To: target-devel@vger.kernel.org
Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
	bvanassche@acm.org, David Disseldorp <ddiss@suse.de>
Subject: [RFC PATCH 1/5] scsi: target: use #def for xcopy descriptor len
Date: Mon, 23 Mar 2020 17:54:06 +0100	[thread overview]
Message-ID: <20200323165410.24423-2-ddiss@suse.de> (raw)
In-Reply-To: <20200323165410.24423-1-ddiss@suse.de>

Signed-off-by: David Disseldorp <ddiss@suse.de>
---
 drivers/target/target_core_xcopy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/target/target_core_xcopy.c b/drivers/target/target_core_xcopy.c
index 425c1070de08..7e5b13da0c20 100644
--- a/drivers/target/target_core_xcopy.c
+++ b/drivers/target/target_core_xcopy.c
@@ -134,7 +134,7 @@ static int target_xcopy_parse_tiddesc_e4(struct se_cmd *se_cmd, struct xcopy_op
 	 * Assigned designator
 	 */
 	desig_len = desc[7];
-	if (desig_len != 16) {
+	if (desig_len != XCOPY_NAA_IEEE_REGEX_LEN) {
 		pr_err("XCOPY 0xe4: invalid desig_len: %d\n", (int)desig_len);
 		return -EINVAL;
 	}
-- 
2.16.4


  reply	other threads:[~2020-03-23 16:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-23 16:54 [RFC PATCH 0/5] scsi: target: XCOPY performance David Disseldorp
2020-03-23 16:54 ` David Disseldorp
2020-03-23 16:54 ` David Disseldorp [this message]
2020-03-23 16:54   ` [RFC PATCH 1/5] scsi: target: use #def for xcopy descriptor len David Disseldorp
2020-03-24  9:06   ` Christoph Hellwig
2020-03-24  9:06     ` Christoph Hellwig
2020-03-23 16:54 ` [RFC PATCH 2/5] scsi: target: drop xcopy DISK BLOCK LENGTH debug David Disseldorp
2020-03-23 16:54   ` David Disseldorp
2020-03-24  9:07   ` Christoph Hellwig
2020-03-24  9:07     ` Christoph Hellwig
2020-03-23 16:54 ` [RFC PATCH 3/5] scsi: target: avoid per-loop XCOPY buffer allocations David Disseldorp
2020-03-23 16:54   ` David Disseldorp
2020-03-24  9:16   ` Christoph Hellwig
2020-03-24  9:16     ` Christoph Hellwig
2020-03-23 16:54 ` [RFC PATCH 4/5] scsi: target: increase XCOPY I/O size David Disseldorp
2020-03-23 16:54   ` David Disseldorp
2020-03-24  9:16   ` Christoph Hellwig
2020-03-24  9:16     ` Christoph Hellwig
2020-03-23 16:54 ` [RFC PATCH 5/5] scsi: target: avoid XCOPY per-loop read/write cmd allocations David Disseldorp
2020-03-23 16:54   ` David Disseldorp
2020-03-24  9:23   ` Christoph Hellwig
2020-03-24  9:23     ` Christoph Hellwig
2020-03-26 21:20     ` David Disseldorp
2020-03-26 21:20       ` David Disseldorp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200323165410.24423-2-ddiss@suse.de \
    --to=ddiss@suse.de \
    --cc=bvanassche@acm.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.