From: Slava Bacherikov <slava@bacher09.org>
To: keescook@chromium.org
Cc: andriin@fb.com, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, jannh@google.com,
alexei.starovoitov@gmail.com, daniel@iogearbox.net,
kernel-hardening@lists.openwall.com, liuyd.fnst@cn.fujitsu.com,
Slava Bacherikov <slava@bacher09.org>,
KP Singh <kpsingh@google.com>
Subject: [PATCH v3 bpf] kbuild: fix dependencies for DEBUG_INFO_BTF
Date: Wed, 1 Apr 2020 17:20:58 +0300 [thread overview]
Message-ID: <20200401142057.453892-1-slava@bacher09.org> (raw)
In-Reply-To: <202004010033.A1523890@keescook>
Currently turning on DEBUG_INFO_SPLIT when DEBUG_INFO_BTF is also
enabled will produce invalid btf file, since gen_btf function in
link-vmlinux.sh script doesn't handle *.dwo files.
Enabling DEBUG_INFO_REDUCED will also produce invalid btf file, and
using GCC_PLUGIN_RANDSTRUCT with BTF makes no sense.
Signed-off-by: Slava Bacherikov <slava@bacher09.org>
Reported-by: Jann Horn <jannh@google.com>
Reported-by: Liu Yiding <liuyd.fnst@cn.fujitsu.com>
Acked-by: KP Singh <kpsingh@google.com>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Fixes: e83b9f55448a ("kbuild: add ability to generate BTF type info for vmlinux")
---
lib/Kconfig.debug | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index f61d834e02fe..b94227be2d62 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -222,7 +222,9 @@ config DEBUG_INFO_DWARF4
config DEBUG_INFO_BTF
bool "Generate BTF typeinfo"
- depends on DEBUG_INFO
+ depends on DEBUG_INFO || COMPILE_TEST
+ depends on !DEBUG_INFO_SPLIT && !DEBUG_INFO_REDUCED
+ depends on !GCC_PLUGIN_RANDSTRUCT || COMPILE_TEST
help
Generate deduplicated BTF type information from DWARF debug info.
Turning this on expects presence of pahole tool, which will convert
next prev parent reply other threads:[~2020-04-01 14:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 21:55 [PATCH v2 bpf] kbuild: fix dependencies for DEBUG_INFO_BTF Slava Bacherikov
2020-03-31 22:40 ` KP Singh
2020-04-01 0:03 ` Andrii Nakryiko
2020-04-01 0:03 ` Andrii Nakryiko
2020-04-01 7:34 ` Kees Cook
2020-04-01 14:20 ` Slava Bacherikov [this message]
2020-04-01 14:37 ` [PATCH v3 " Slava Bacherikov
2020-04-01 17:46 ` Andrii Nakryiko
2020-04-01 17:46 ` Andrii Nakryiko
2020-04-01 18:24 ` Slava Bacherikov
2020-04-01 15:49 ` Kees Cook
2020-04-02 15:33 ` [PATCH v4 " Slava Bacherikov
2020-04-02 15:40 ` Slava Bacherikov
2020-04-02 19:31 ` Andrii Nakryiko
2020-04-02 19:31 ` Andrii Nakryiko
2020-04-02 20:34 ` Kees Cook
2020-04-02 20:38 ` Slava Bacherikov
2020-04-02 20:41 ` [PATCH v5 " Slava Bacherikov
2020-04-02 21:02 ` Andrii Nakryiko
2020-04-02 21:02 ` Andrii Nakryiko
2020-04-02 22:49 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401142057.453892-1-slava@bacher09.org \
--to=slava@bacher09.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andriin@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kpsingh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyd.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.