From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
To: linux-media@vger.kernel.org, dafna.hirschfeld@collabora.com,
helen.koike@collabora.com, ezequiel@collabora.com,
hverkuil@xs4all.nl, kernel@collabora.com, dafna3@gmail.com,
laurent.pinchart@ideasonboard.com,
linux-rockchip@lists.infradead.org
Subject: [PATCH v2 1/5] media: staging: rkisp1: cap: cleanup in mainpath config for uv swap format
Date: Thu, 2 Apr 2020 21:04:15 +0200 [thread overview]
Message-ID: <20200402190419.15155-2-dafna.hirschfeld@collabora.com> (raw)
In-Reply-To: <20200402190419.15155-1-dafna.hirschfeld@collabora.com>
The value RKISP1_CIF_MI_XTD_FMT_CTRL_MP_CB_CR_SWAP equals BIT(0),
Therefore when writing it to the register there is no need to mask
it first with ~BIT(0).
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
---
drivers/staging/media/rkisp1/rkisp1-capture.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/rkisp1/rkisp1-capture.c b/drivers/staging/media/rkisp1/rkisp1-capture.c
index 45d237a77ca4..5700d7be2819 100644
--- a/drivers/staging/media/rkisp1/rkisp1-capture.c
+++ b/drivers/staging/media/rkisp1/rkisp1-capture.c
@@ -432,8 +432,7 @@ static void rkisp1_mp_config(struct rkisp1_capture *cap)
if (cap->pix.cfg->uv_swap) {
reg = rkisp1_read(rkisp1, RKISP1_CIF_MI_XTD_FORMAT_CTRL);
- reg = (reg & ~BIT(0)) |
- RKISP1_CIF_MI_XTD_FMT_CTRL_MP_CB_CR_SWAP;
+ reg = reg | RKISP1_CIF_MI_XTD_FMT_CTRL_MP_CB_CR_SWAP;
rkisp1_write(rkisp1, reg, RKISP1_CIF_MI_XTD_FORMAT_CTRL);
}
--
2.17.1
next prev parent reply other threads:[~2020-04-02 19:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 19:04 [PATCH v2 0/5] media: staging: rkisp1: cap: various fixes for capture formats Dafna Hirschfeld
2020-04-02 19:04 ` Dafna Hirschfeld [this message]
2020-04-02 19:53 ` [PATCH v2 1/5] media: staging: rkisp1: cap: cleanup in mainpath config for uv swap format Helen Koike
2020-04-05 17:57 ` Laurent Pinchart
2020-04-02 19:04 ` [PATCH v2 2/5] media: staging: rkisp1: cap: fix value written to uv swap register in selfpath Dafna Hirschfeld
2020-04-02 19:53 ` Helen Koike
2020-04-05 18:10 ` Laurent Pinchart
2020-04-06 11:20 ` Dafna Hirschfeld
2020-04-02 19:04 ` [PATCH v2 3/5] media: staging: rkisp1: cap: support uv swap only for semiplanar formats Dafna Hirschfeld
2020-04-05 18:14 ` Laurent Pinchart
2020-04-02 19:04 ` [PATCH v2 4/5] media: staging: rkisp1: cap: support uv swapped plane formats Dafna Hirschfeld
2020-04-05 18:16 ` Laurent Pinchart
2020-04-06 11:56 ` Dafna Hirschfeld
2020-04-06 12:27 ` Helen Koike
2020-04-06 12:40 ` Dafna Hirschfeld
2020-04-02 19:04 ` [PATCH v2 5/5] media: staging: rkisp1: cap: remove unsupported formats Dafna Hirschfeld
2020-04-05 22:43 ` Laurent Pinchart
2020-04-06 12:42 ` Dafna Hirschfeld
2020-04-08 10:24 ` Dafna Hirschfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200402190419.15155-2-dafna.hirschfeld@collabora.com \
--to=dafna.hirschfeld@collabora.com \
--cc=dafna3@gmail.com \
--cc=ezequiel@collabora.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.