All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xia Jiang <xia.jiang@mediatek.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Rick Chang <rick.chang@mediatek.com>
Cc: <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Tomasz Figa <tfiga@chromium.org>, <srv_heupstream@mediatek.com>,
	<senozhatsky@chromium.org>, <mojahsu@chromium.org>,
	<drinkcat@chromium.org>, <maoguang.meng@mediatek.com>,
	<sj.huang@mediatek.com>, Xia Jiang <xia.jiang@mediatek.com>
Subject: [PATCH v8 01/14] media: platform: Improve subscribe event flow for bug fixing
Date: Fri, 3 Apr 2020 17:40:20 +0800	[thread overview]
Message-ID: <20200403094033.8288-2-xia.jiang@mediatek.com> (raw)
In-Reply-To: <20200403094033.8288-1-xia.jiang@mediatek.com>

Let v4l2_ctrl_subscribe_event() do the job for other types except
V4L2_EVENT_SOURCE_CHANGE.

Signed-off-by: Xia Jiang <xia.jiang@mediatek.com>
---
v8: no changes
---
 drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
index ee802fc3bcdf..cde59275d49c 100644
--- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
@@ -446,9 +446,9 @@ static int mtk_jpeg_subscribe_event(struct v4l2_fh *fh,
 	switch (sub->type) {
 	case V4L2_EVENT_SOURCE_CHANGE:
 		return v4l2_src_change_event_subscribe(fh, sub);
-	default:
-		return -EINVAL;
 	}
+
+	return v4l2_ctrl_subscribe_event(fh, sub);
 }
 
 static int mtk_jpeg_g_selection(struct file *file, void *priv,
-- 
2.18.0

WARNING: multiple messages have this Message-ID (diff)
From: Xia Jiang <xia.jiang@mediatek.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	Rick Chang <rick.chang@mediatek.com>
Cc: maoguang.meng@mediatek.com, devicetree@vger.kernel.org,
	mojahsu@chromium.org, srv_heupstream@mediatek.com,
	linux-kernel@vger.kernel.org, Tomasz Figa <tfiga@chromium.org>,
	senozhatsky@chromium.org, sj.huang@mediatek.com,
	drinkcat@chromium.org, linux-mediatek@lists.infradead.org,
	Xia Jiang <xia.jiang@mediatek.com>,
	linux-media@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: [PATCH v8 01/14] media: platform: Improve subscribe event flow for bug fixing
Date: Fri, 3 Apr 2020 17:40:20 +0800	[thread overview]
Message-ID: <20200403094033.8288-2-xia.jiang@mediatek.com> (raw)
In-Reply-To: <20200403094033.8288-1-xia.jiang@mediatek.com>

Let v4l2_ctrl_subscribe_event() do the job for other types except
V4L2_EVENT_SOURCE_CHANGE.

Signed-off-by: Xia Jiang <xia.jiang@mediatek.com>
---
v8: no changes
---
 drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
index ee802fc3bcdf..cde59275d49c 100644
--- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
@@ -446,9 +446,9 @@ static int mtk_jpeg_subscribe_event(struct v4l2_fh *fh,
 	switch (sub->type) {
 	case V4L2_EVENT_SOURCE_CHANGE:
 		return v4l2_src_change_event_subscribe(fh, sub);
-	default:
-		return -EINVAL;
 	}
+
+	return v4l2_ctrl_subscribe_event(fh, sub);
 }
 
 static int mtk_jpeg_g_selection(struct file *file, void *priv,
-- 
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Xia Jiang <xia.jiang@mediatek.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	Rick Chang <rick.chang@mediatek.com>
Cc: maoguang.meng@mediatek.com, devicetree@vger.kernel.org,
	mojahsu@chromium.org, srv_heupstream@mediatek.com,
	linux-kernel@vger.kernel.org, Tomasz Figa <tfiga@chromium.org>,
	senozhatsky@chromium.org, sj.huang@mediatek.com,
	drinkcat@chromium.org, linux-mediatek@lists.infradead.org,
	Xia Jiang <xia.jiang@mediatek.com>,
	linux-media@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: [PATCH v8 01/14] media: platform: Improve subscribe event flow for bug fixing
Date: Fri, 3 Apr 2020 17:40:20 +0800	[thread overview]
Message-ID: <20200403094033.8288-2-xia.jiang@mediatek.com> (raw)
In-Reply-To: <20200403094033.8288-1-xia.jiang@mediatek.com>

Let v4l2_ctrl_subscribe_event() do the job for other types except
V4L2_EVENT_SOURCE_CHANGE.

Signed-off-by: Xia Jiang <xia.jiang@mediatek.com>
---
v8: no changes
---
 drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
index ee802fc3bcdf..cde59275d49c 100644
--- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
@@ -446,9 +446,9 @@ static int mtk_jpeg_subscribe_event(struct v4l2_fh *fh,
 	switch (sub->type) {
 	case V4L2_EVENT_SOURCE_CHANGE:
 		return v4l2_src_change_event_subscribe(fh, sub);
-	default:
-		return -EINVAL;
 	}
+
+	return v4l2_ctrl_subscribe_event(fh, sub);
 }
 
 static int mtk_jpeg_g_selection(struct file *file, void *priv,
-- 
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-04-03  9:40 UTC|newest]

Thread overview: 122+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-03  9:40 [PATCH v8 00/14] Add support for mt2701 JPEG ENC support Xia Jiang
2020-04-03  9:40 ` Xia Jiang
2020-04-03  9:40 ` Xia Jiang
2020-04-03  9:40 ` Xia Jiang [this message]
2020-04-03  9:40   ` [PATCH v8 01/14] media: platform: Improve subscribe event flow for bug fixing Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-05-21 13:45   ` Tomasz Figa
2020-05-21 13:45     ` Tomasz Figa
2020-05-21 13:45     ` Tomasz Figa
2020-04-03  9:40 ` [PATCH v8 02/14] media: platform: Improve queue set up " Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-05-21 13:46   ` Tomasz Figa
2020-05-21 13:46     ` Tomasz Figa
2020-05-21 13:46     ` Tomasz Figa
2020-04-03  9:40 ` [PATCH v8 03/14] media: platform: Improve getting and requesting irq " Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-05-21 13:47   ` Tomasz Figa
2020-05-21 13:47     ` Tomasz Figa
2020-05-21 13:47     ` Tomasz Figa
2020-04-03  9:40 ` [PATCH v8 04/14] media: platform: Change the fixed device node number to unfixed value Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-05-11  8:39   ` Hans Verkuil
2020-05-11  8:39     ` Hans Verkuil
2020-05-11  8:39     ` Hans Verkuil
2020-05-21 13:59   ` Tomasz Figa
2020-05-21 13:59     ` Tomasz Figa
2020-05-21 13:59     ` Tomasz Figa
2020-06-05  6:02     ` Xia Jiang
2020-06-05  6:02       ` Xia Jiang
2020-06-05  6:02       ` Xia Jiang
2020-04-03  9:40 ` [PATCH v8 05/14] media: platform: Improve power on and power off flow Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-05-21 15:22   ` Tomasz Figa
2020-05-21 15:22     ` Tomasz Figa
2020-05-21 15:22     ` Tomasz Figa
2020-06-05  6:03     ` Xia Jiang
2020-06-05  6:03       ` Xia Jiang
2020-06-05  6:03       ` Xia Jiang
2020-04-03  9:40 ` [PATCH v8 06/14] media: platform: Improve the implementation of the system PM ops Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-05-21 15:32   ` Tomasz Figa
2020-05-21 15:32     ` Tomasz Figa
2020-05-21 15:32     ` Tomasz Figa
2020-05-27  1:52     ` Xia Jiang
2020-05-27  1:52       ` Xia Jiang
2020-05-27  1:52       ` Xia Jiang
2020-05-27 14:46       ` Tomasz Figa
2020-05-27 14:46         ` Tomasz Figa
2020-05-27 14:46         ` Tomasz Figa
2020-04-03  9:40 ` [PATCH v8 07/14] media: platform: Use kernel native functions for improving code quality Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-05-21 15:41   ` Tomasz Figa
2020-05-21 15:41     ` Tomasz Figa
2020-05-21 15:41     ` Tomasz Figa
2020-06-05  6:41     ` Xia Jiang
2020-06-05  6:41       ` Xia Jiang
2020-06-05  6:41       ` Xia Jiang
2020-04-03  9:40 ` [PATCH v8 08/14] media: platform: Change case " Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-05-11  8:37   ` Hans Verkuil
2020-05-11  8:37     ` Hans Verkuil
2020-05-11  8:37     ` Hans Verkuil
2020-06-05  8:04     ` Xia Jiang
2020-06-05  8:04       ` Xia Jiang
2020-06-05  8:04       ` Xia Jiang
2020-04-03  9:40 ` [PATCH v8 09/14] media: platform: Change MTK_JPEG_COMP_MAX macro definition location Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-05-21 15:44   ` Tomasz Figa
2020-05-21 15:44     ` Tomasz Figa
2020-05-21 15:44     ` Tomasz Figa
2020-04-03  9:40 ` [PATCH v8 10/14] media: platform: Delete redundant code for improving code quality Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-05-21 15:49   ` Tomasz Figa
2020-05-21 15:49     ` Tomasz Figa
2020-05-21 15:49     ` Tomasz Figa
2020-06-05  6:41     ` Xia Jiang
2020-06-05  6:41       ` Xia Jiang
2020-06-05  6:41       ` Xia Jiang
2020-04-03  9:40 ` [PATCH v8 11/14] media: dt-bindings: Add jpeg enc device tree node document Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-05-21 16:00   ` Tomasz Figa
2020-05-21 16:00     ` Tomasz Figa
2020-05-21 16:00     ` Tomasz Figa
2020-06-18  3:40     ` Xia Jiang
2020-06-18  3:40       ` Xia Jiang
2020-06-18  3:40       ` Xia Jiang
2020-06-18 12:34       ` Tomasz Figa
2020-06-18 12:34         ` Tomasz Figa
2020-06-18 12:34         ` Tomasz Figa
2020-04-03  9:40 ` [PATCH v8 12/14] arm: dts: Add jpeg enc device tree node Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-04-07  3:52   ` Yingjoe Chen
2020-04-07  3:52     ` Yingjoe Chen
2020-04-07  3:52     ` Yingjoe Chen
2020-04-03  9:40 ` [PATCH v8 13/14] media: platform: Rename jpeg dec file name Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-05-21 16:02   ` Tomasz Figa
2020-05-21 16:02     ` Tomasz Figa
2020-05-21 16:02     ` Tomasz Figa
2020-04-03  9:40 ` [PATCH v8 14/14] media: platform: Add jpeg dec/enc feature Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-04-03  9:40   ` Xia Jiang
2020-05-11  9:04   ` Hans Verkuil
2020-05-11  9:04     ` Hans Verkuil
2020-05-11  9:04     ` Hans Verkuil
2020-05-21 16:08     ` Tomasz Figa
2020-05-21 16:08       ` Tomasz Figa
2020-05-21 16:08       ` Tomasz Figa
2020-06-05  8:07     ` Xia Jiang
2020-06-05  8:07       ` Xia Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200403094033.8288-2-xia.jiang@mediatek.com \
    --to=xia.jiang@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=drinkcat@chromium.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=m.szyprowski@samsung.com \
    --cc=maoguang.meng@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab+samsung@kernel.org \
    --cc=mojahsu@chromium.org \
    --cc=rick.chang@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=senozhatsky@chromium.org \
    --cc=sj.huang@mediatek.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=tfiga@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.