From: Ville Syrjala <ville.syrjala@linux.intel.com> To: dri-devel@lists.freedesktop.org Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, Emil Velikov <emil.velikov@collabora.com> Subject: [PATCH v2 08/17] drm: Shrink drm_display_mode timings Date: Fri, 3 Apr 2020 23:39:59 +0300 [thread overview] Message-ID: <20200403204008.14864-9-ville.syrjala@linux.intel.com> (raw) In-Reply-To: <20200403204008.14864-1-ville.syrjala@linux.intel.com> From: Ville Syrjälä <ville.syrjala@linux.intel.com> Store the timings (apart from the clock) as u16. The uapi mode struct already uses u16 for everything so using something bigger internally doesn't really help us. Reviewed-by: Emil Velikov <emil.velikov@collabora.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> --- drivers/gpu/drm/drm_modes.c | 7 ------ include/drm/drm_modes.h | 46 ++++++++++++++++++------------------- 2 files changed, 23 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index e3d5f011f7bd..77d68120931a 100644 --- a/drivers/gpu/drm/drm_modes.c +++ b/drivers/gpu/drm/drm_modes.c @@ -1901,13 +1901,6 @@ EXPORT_SYMBOL(drm_mode_create_from_cmdline_mode); void drm_mode_convert_to_umode(struct drm_mode_modeinfo *out, const struct drm_display_mode *in) { - WARN(in->hdisplay > USHRT_MAX || in->hsync_start > USHRT_MAX || - in->hsync_end > USHRT_MAX || in->htotal > USHRT_MAX || - in->hskew > USHRT_MAX || in->vdisplay > USHRT_MAX || - in->vsync_start > USHRT_MAX || in->vsync_end > USHRT_MAX || - in->vtotal > USHRT_MAX || in->vscan > USHRT_MAX, - "timing values too large for mode info\n"); - out->clock = in->clock; out->hdisplay = in->hdisplay; out->hsync_start = in->hsync_start; diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h index da7db74a215e..917527eb8067 100644 --- a/include/drm/drm_modes.h +++ b/include/drm/drm_modes.h @@ -278,16 +278,16 @@ struct drm_display_mode { * Pixel clock in kHz. */ int clock; /* in kHz */ - int hdisplay; - int hsync_start; - int hsync_end; - int htotal; - int hskew; - int vdisplay; - int vsync_start; - int vsync_end; - int vtotal; - int vscan; + u16 hdisplay; + u16 hsync_start; + u16 hsync_end; + u16 htotal; + u16 hskew; + u16 vdisplay; + u16 vsync_start; + u16 vsync_end; + u16 vtotal; + u16 vscan; /** * @flags: * @@ -356,19 +356,19 @@ struct drm_display_mode { * difference is exactly a factor of 10. */ int crtc_clock; - int crtc_hdisplay; - int crtc_hblank_start; - int crtc_hblank_end; - int crtc_hsync_start; - int crtc_hsync_end; - int crtc_htotal; - int crtc_hskew; - int crtc_vdisplay; - int crtc_vblank_start; - int crtc_vblank_end; - int crtc_vsync_start; - int crtc_vsync_end; - int crtc_vtotal; + u16 crtc_hdisplay; + u16 crtc_hblank_start; + u16 crtc_hblank_end; + u16 crtc_hsync_start; + u16 crtc_hsync_end; + u16 crtc_htotal; + u16 crtc_hskew; + u16 crtc_vdisplay; + u16 crtc_vblank_start; + u16 crtc_vblank_end; + u16 crtc_vsync_start; + u16 crtc_vsync_end; + u16 crtc_vtotal; /** * @private_flags: -- 2.24.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Ville Syrjala <ville.syrjala@linux.intel.com> To: dri-devel@lists.freedesktop.org Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, Emil Velikov <emil.velikov@collabora.com> Subject: [Intel-gfx] [PATCH v2 08/17] drm: Shrink drm_display_mode timings Date: Fri, 3 Apr 2020 23:39:59 +0300 [thread overview] Message-ID: <20200403204008.14864-9-ville.syrjala@linux.intel.com> (raw) In-Reply-To: <20200403204008.14864-1-ville.syrjala@linux.intel.com> From: Ville Syrjälä <ville.syrjala@linux.intel.com> Store the timings (apart from the clock) as u16. The uapi mode struct already uses u16 for everything so using something bigger internally doesn't really help us. Reviewed-by: Emil Velikov <emil.velikov@collabora.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> --- drivers/gpu/drm/drm_modes.c | 7 ------ include/drm/drm_modes.h | 46 ++++++++++++++++++------------------- 2 files changed, 23 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index e3d5f011f7bd..77d68120931a 100644 --- a/drivers/gpu/drm/drm_modes.c +++ b/drivers/gpu/drm/drm_modes.c @@ -1901,13 +1901,6 @@ EXPORT_SYMBOL(drm_mode_create_from_cmdline_mode); void drm_mode_convert_to_umode(struct drm_mode_modeinfo *out, const struct drm_display_mode *in) { - WARN(in->hdisplay > USHRT_MAX || in->hsync_start > USHRT_MAX || - in->hsync_end > USHRT_MAX || in->htotal > USHRT_MAX || - in->hskew > USHRT_MAX || in->vdisplay > USHRT_MAX || - in->vsync_start > USHRT_MAX || in->vsync_end > USHRT_MAX || - in->vtotal > USHRT_MAX || in->vscan > USHRT_MAX, - "timing values too large for mode info\n"); - out->clock = in->clock; out->hdisplay = in->hdisplay; out->hsync_start = in->hsync_start; diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h index da7db74a215e..917527eb8067 100644 --- a/include/drm/drm_modes.h +++ b/include/drm/drm_modes.h @@ -278,16 +278,16 @@ struct drm_display_mode { * Pixel clock in kHz. */ int clock; /* in kHz */ - int hdisplay; - int hsync_start; - int hsync_end; - int htotal; - int hskew; - int vdisplay; - int vsync_start; - int vsync_end; - int vtotal; - int vscan; + u16 hdisplay; + u16 hsync_start; + u16 hsync_end; + u16 htotal; + u16 hskew; + u16 vdisplay; + u16 vsync_start; + u16 vsync_end; + u16 vtotal; + u16 vscan; /** * @flags: * @@ -356,19 +356,19 @@ struct drm_display_mode { * difference is exactly a factor of 10. */ int crtc_clock; - int crtc_hdisplay; - int crtc_hblank_start; - int crtc_hblank_end; - int crtc_hsync_start; - int crtc_hsync_end; - int crtc_htotal; - int crtc_hskew; - int crtc_vdisplay; - int crtc_vblank_start; - int crtc_vblank_end; - int crtc_vsync_start; - int crtc_vsync_end; - int crtc_vtotal; + u16 crtc_hdisplay; + u16 crtc_hblank_start; + u16 crtc_hblank_end; + u16 crtc_hsync_start; + u16 crtc_hsync_end; + u16 crtc_htotal; + u16 crtc_hskew; + u16 crtc_vdisplay; + u16 crtc_vblank_start; + u16 crtc_vblank_end; + u16 crtc_vsync_start; + u16 crtc_vsync_end; + u16 crtc_vtotal; /** * @private_flags: -- 2.24.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-04-03 20:40 UTC|newest] Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-03 20:39 [PATCH v2 00/17] drm: Put drm_display_mode on diet Ville Syrjala 2020-04-03 20:39 ` [Intel-gfx] " Ville Syrjala 2020-04-03 20:39 ` [PATCH v2 01/17] drm: Nuke mode->hsync Ville Syrjala 2020-04-03 20:39 ` [Intel-gfx] " Ville Syrjala 2020-04-07 18:30 ` Sam Ravnborg 2020-04-07 18:30 ` [Intel-gfx] " Sam Ravnborg 2020-04-03 20:39 ` [PATCH v2 02/17] drm/i915: Introduce some local intel_dp variables Ville Syrjala 2020-04-03 20:39 ` [Intel-gfx] " Ville Syrjala 2020-04-03 20:39 ` [PATCH v2 03/17] drm: Nuke mode->vrefresh Ville Syrjala 2020-04-03 20:39 ` Ville Syrjala 2020-04-03 20:39 ` [Intel-gfx] " Ville Syrjala 2020-04-03 20:39 ` Ville Syrjala 2020-04-03 20:58 ` Laurent Pinchart 2020-04-03 20:58 ` Laurent Pinchart 2020-04-03 20:58 ` [Intel-gfx] " Laurent Pinchart 2020-04-03 20:58 ` Laurent Pinchart 2020-04-04 2:01 ` abhinavk 2020-04-04 2:01 ` abhinavk 2020-04-04 2:01 ` [Intel-gfx] " abhinavk 2020-04-04 2:01 ` abhinavk 2020-04-06 8:32 ` Jani Nikula 2020-04-06 8:32 ` Jani Nikula 2020-04-06 8:32 ` [Intel-gfx] " Jani Nikula 2020-04-06 8:32 ` Jani Nikula 2020-04-07 1:23 ` abhinavk 2020-04-07 1:23 ` abhinavk 2020-04-07 1:23 ` [Intel-gfx] " abhinavk 2020-04-07 1:23 ` abhinavk 2020-04-03 20:39 ` [PATCH v2 04/17] drm/msm/dpu: Stop copying around mode->private_flags Ville Syrjala 2020-04-03 20:39 ` [Intel-gfx] " Ville Syrjala 2020-04-03 20:39 ` Ville Syrjala 2020-04-03 20:39 ` [PATCH v2 05/17] drm: Shrink {width,height}_mm to u16 Ville Syrjala 2020-04-03 20:39 ` [Intel-gfx] " Ville Syrjala 2020-04-07 18:37 ` Sam Ravnborg 2020-04-07 18:37 ` [Intel-gfx] [PATCH v2 05/17] drm: Shrink {width, height}_mm " Sam Ravnborg 2020-04-03 20:39 ` [PATCH v2 06/17] drm: Shrink mode->type to u8 Ville Syrjala 2020-04-03 20:39 ` [Intel-gfx] " Ville Syrjala 2020-04-07 18:38 ` Sam Ravnborg 2020-04-07 18:38 ` [Intel-gfx] " Sam Ravnborg 2020-04-03 20:39 ` [PATCH v2 07/17] drm: Make mode->flags u32 Ville Syrjala 2020-04-03 20:39 ` [Intel-gfx] " Ville Syrjala 2020-04-07 18:38 ` Sam Ravnborg 2020-04-07 18:38 ` [Intel-gfx] " Sam Ravnborg 2020-04-03 20:39 ` Ville Syrjala [this message] 2020-04-03 20:39 ` [Intel-gfx] [PATCH v2 08/17] drm: Shrink drm_display_mode timings Ville Syrjala 2020-04-07 18:43 ` Sam Ravnborg 2020-04-07 18:43 ` [Intel-gfx] " Sam Ravnborg 2020-04-03 20:40 ` [PATCH v2 09/17] drm: Flatten drm_mode_vrefresh() Ville Syrjala 2020-04-03 20:40 ` [Intel-gfx] " Ville Syrjala 2020-04-07 18:46 ` Sam Ravnborg 2020-04-07 18:46 ` [Intel-gfx] " Sam Ravnborg 2020-04-03 20:40 ` [PATCH v2 10/17] drm: Shrink mode->private_flags Ville Syrjala 2020-04-03 20:40 ` [Intel-gfx] " Ville Syrjala 2020-04-07 18:52 ` Sam Ravnborg 2020-04-07 18:52 ` [Intel-gfx] " Sam Ravnborg 2020-04-07 19:10 ` Ville Syrjälä 2020-04-07 19:10 ` [Intel-gfx] " Ville Syrjälä 2020-04-03 20:40 ` [PATCH v2 11/17] drm: pahole struct drm_display_mode Ville Syrjala 2020-04-03 20:40 ` [Intel-gfx] " Ville Syrjala 2020-04-06 0:24 ` kbuild test robot 2020-04-03 20:40 ` [PATCH v2 12/17] drm/mcde: Use mode->clock instead of reverse calculating it from the vrefresh Ville Syrjala 2020-04-03 20:40 ` [Intel-gfx] " Ville Syrjala 2020-04-07 7:27 ` Daniel Vetter 2020-04-07 7:27 ` [Intel-gfx] " Daniel Vetter 2020-04-07 18:53 ` Sam Ravnborg 2020-04-07 18:53 ` [Intel-gfx] " Sam Ravnborg 2020-04-12 0:42 ` Linus Walleij 2020-04-12 0:42 ` [Intel-gfx] " Linus Walleij 2020-04-03 20:40 ` [PATCH v2 13/17] drm/i915: Stop using mode->private_flags Ville Syrjala 2020-04-03 20:40 ` [Intel-gfx] " Ville Syrjala 2020-04-07 7:38 ` Daniel Vetter 2020-04-07 7:38 ` [Intel-gfx] " Daniel Vetter 2020-04-07 15:20 ` Ville Syrjälä 2020-04-07 15:20 ` [Intel-gfx] " Ville Syrjälä 2020-04-08 9:34 ` Jani Nikula 2020-04-08 9:34 ` Jani Nikula 2020-04-03 20:40 ` [PATCH v2 14/17] drm/i915: Replace I915_MODE_FLAG_INHERITED with a boolean Ville Syrjala 2020-04-03 20:40 ` [Intel-gfx] " Ville Syrjala 2020-04-07 7:42 ` Daniel Vetter 2020-04-07 7:42 ` [Intel-gfx] " Daniel Vetter 2020-04-03 20:40 ` [PATCH v2 15/17] drm/gma500: Stop using mode->private_flags Ville Syrjala 2020-04-03 20:40 ` [Intel-gfx] " Ville Syrjala 2020-04-07 7:46 ` Daniel Vetter 2020-04-07 7:46 ` [Intel-gfx] " Daniel Vetter 2020-04-07 18:56 ` Sam Ravnborg 2020-04-07 18:56 ` [Intel-gfx] " Sam Ravnborg 2020-04-07 19:08 ` Ville Syrjälä 2020-04-07 19:08 ` [Intel-gfx] " Ville Syrjälä 2020-04-07 19:35 ` Sam Ravnborg 2020-04-07 19:35 ` [Intel-gfx] " Sam Ravnborg 2020-04-09 19:49 ` Ville Syrjälä 2020-04-09 19:49 ` [Intel-gfx] " Ville Syrjälä 2020-04-09 19:54 ` Ville Syrjälä 2020-04-09 19:54 ` [Intel-gfx] " Ville Syrjälä 2020-04-09 20:47 ` Sam Ravnborg 2020-04-09 20:47 ` [Intel-gfx] " Sam Ravnborg 2020-04-14 15:11 ` Ville Syrjälä 2020-04-14 15:11 ` [Intel-gfx] " Ville Syrjälä 2020-04-03 20:40 ` [PATCH v2 16/17] drm: Nuke mode->private_flags Ville Syrjala 2020-04-03 20:40 ` [Intel-gfx] " Ville Syrjala 2020-04-04 1:40 ` abhinavk 2020-04-04 1:40 ` [Intel-gfx] " abhinavk 2020-04-06 9:11 ` Jani Nikula 2020-04-06 9:11 ` [Intel-gfx] " Jani Nikula 2020-04-07 1:26 ` abhinavk 2020-04-07 1:26 ` [Intel-gfx] " abhinavk 2020-04-07 18:58 ` Sam Ravnborg 2020-04-07 18:58 ` [Intel-gfx] " Sam Ravnborg 2020-04-03 20:40 ` [PATCH v2 17/17] drm: Replace mode->export_head with a boolean Ville Syrjala 2020-04-03 20:40 ` [Intel-gfx] " Ville Syrjala 2020-04-03 22:04 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Put drm_display_mode on diet (rev2) Patchwork 2020-04-03 22:29 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork 2020-04-24 17:32 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm: Put drm_display_mode on diet (rev3) Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200403204008.14864-9-ville.syrjala@linux.intel.com \ --to=ville.syrjala@linux.intel.com \ --cc=daniel.vetter@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=emil.velikov@collabora.com \ --cc=intel-gfx@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.