From: Tang Bin <tangbin@cmss.chinamobile.com>
To: narmstrong@baylibre.com, clabbe@baylibre.com,
herbert@gondor.apana.org.au, davem@davemloft.net
Cc: linux-crypto@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-kernel@vger.kernel.org,
Tang Bin <tangbin@cmss.chinamobile.com>
Subject: [PATCH v6]crypto: amlogic - Delete duplicate dev_err in meson_crypto_probe()
Date: Sat, 4 Apr 2020 06:07:54 +0800 [thread overview]
Message-ID: <20200403220754.7856-1-tangbin@cmss.chinamobile.com> (raw)
When something goes wrong, platform_get_irq() will print an error message,
so in order to avoid the situation of repeat output，we should remove
dev_err here.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
Changes from v5
- modify the commit message.
Changes from v4:
- rewrite the code, because the code in v4 is wrong, sorry.
Changes form v3:
- fix the theme writing error.
Changes from v2:
- modify the theme format and content description.
- reformat the patch, it's the wrong way to resubmit a new patch that
should be modified on top of the original. The original piece is:
https://lore.kernel.org/patchwork/patch/1219611/
Changes from v1:
- the title has changed, because the description is not very detailed.
- the code has been modified, because it needs to match the theme.
drivers/crypto/amlogic/amlogic-gxl-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c
index 9d4ead2f7..411857fad 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-core.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-core.c
@@ -253,10 +253,8 @@ static int meson_crypto_probe(struct platform_device *pdev)
mc->irqs = devm_kcalloc(mc->dev, MAXFLOW, sizeof(int), GFP_KERNEL);
for (i = 0; i < MAXFLOW; i++) {
mc->irqs[i] = platform_get_irq(pdev, i);
- if (mc->irqs[i] < 0) {
- dev_err(mc->dev, "Cannot get IRQ for flow %d\n", i);
+ if (mc->irqs[i] < 0)
return mc->irqs[i];
- }
err = devm_request_irq(&pdev->dev, mc->irqs[i], meson_irq_handler, 0,
"gxl-crypto", mc);
--
2.20.1.windows.1
WARNING: multiple messages have this Message-ID (diff)
From: Tang Bin <tangbin@cmss.chinamobile.com>
To: narmstrong@baylibre.com, clabbe@baylibre.com,
herbert@gondor.apana.org.au, davem@davemloft.net
Cc: linux-amlogic@lists.infradead.org,
Tang Bin <tangbin@cmss.chinamobile.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v6]crypto: amlogic - Delete duplicate dev_err in meson_crypto_probe()
Date: Sat, 4 Apr 2020 06:07:54 +0800 [thread overview]
Message-ID: <20200403220754.7856-1-tangbin@cmss.chinamobile.com> (raw)
When something goes wrong, platform_get_irq() will print an error message,
so in order to avoid the situation of repeat output，we should remove
dev_err here.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
Changes from v5
- modify the commit message.
Changes from v4:
- rewrite the code, because the code in v4 is wrong, sorry.
Changes form v3:
- fix the theme writing error.
Changes from v2:
- modify the theme format and content description.
- reformat the patch, it's the wrong way to resubmit a new patch that
should be modified on top of the original. The original piece is:
https://lore.kernel.org/patchwork/patch/1219611/
Changes from v1:
- the title has changed, because the description is not very detailed.
- the code has been modified, because it needs to match the theme.
drivers/crypto/amlogic/amlogic-gxl-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c
index 9d4ead2f7..411857fad 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-core.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-core.c
@@ -253,10 +253,8 @@ static int meson_crypto_probe(struct platform_device *pdev)
mc->irqs = devm_kcalloc(mc->dev, MAXFLOW, sizeof(int), GFP_KERNEL);
for (i = 0; i < MAXFLOW; i++) {
mc->irqs[i] = platform_get_irq(pdev, i);
- if (mc->irqs[i] < 0) {
- dev_err(mc->dev, "Cannot get IRQ for flow %d\n", i);
+ if (mc->irqs[i] < 0)
return mc->irqs[i];
- }
err = devm_request_irq(&pdev->dev, mc->irqs[i], meson_irq_handler, 0,
"gxl-crypto", mc);
--
2.20.1.windows.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next reply other threads:[~2020-04-03 22:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 22:07 Tang Bin [this message]
2020-04-03 22:07 ` [PATCH v6]crypto: amlogic - Delete duplicate dev_err in meson_crypto_probe() Tang Bin
2020-04-16 6:51 ` Herbert Xu
2020-04-16 6:51 ` Herbert Xu
2020-04-04 12:00 [PATCH v6] crypto: amlogic - Delete duplicate dev_err() " Markus Elfring
2020-04-04 12:00 ` Markus Elfring
2020-04-04 12:00 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403220754.7856-1-tangbin@cmss.chinamobile.com \
--to=tangbin@cmss.chinamobile.com \
--cc=clabbe@baylibre.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.