From: Daniel Baluta <daniel.baluta@oss.nxp.com> To: broonie@kernel.org Cc: pierre-louis.bossart@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, linux-imx@nxp.com, festevam@gmail.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, robh+dt@kernel.org, shengjiu.wang@nxp.com, Daniel Baluta <daniel.baluta@nxp.com> Subject: [PATCH v2 2/5] ASoC: SOF: imx: fix undefined reference issue Date: Thu, 9 Apr 2020 10:18:29 +0300 [thread overview] Message-ID: <20200409071832.2039-3-daniel.baluta@oss.nxp.com> (raw) In-Reply-To: <20200409071832.2039-1-daniel.baluta@oss.nxp.com> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> make.cross ARCH=mips allyesconfig fails with the following error: sound/soc/sof/sof-of-dev.o:(.data.sof_of_imx8qxp_desc+0x40): undefined reference to `sof_imx8x_ops'. This seems to be a Makefile order issue, solve by using the same structure as for Intel platforms. Fixes: f9ad75468453 ("ASoC: SOF: imx: fix reverse CONFIG_SND_SOC_SOF_OF dependency") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com> --- sound/soc/sof/imx/Kconfig | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/sound/soc/sof/imx/Kconfig b/sound/soc/sof/imx/Kconfig index 812749064ca8..9586635cf8ab 100644 --- a/sound/soc/sof/imx/Kconfig +++ b/sound/soc/sof/imx/Kconfig @@ -11,17 +11,26 @@ config SND_SOC_SOF_IMX_TOPLEVEL if SND_SOC_SOF_IMX_TOPLEVEL +config SND_SOC_SOF_IMX_OF + def_tristate SND_SOC_SOF_OF + select SND_SOC_SOF_IMX8 if SND_SOC_SOF_IMX8_SUPPORT + help + This option is not user-selectable but automagically handled by + 'select' statements at a higher level + config SND_SOC_SOF_IMX8_SUPPORT bool "SOF support for i.MX8" - depends on IMX_SCU - select IMX_DSP help This adds support for Sound Open Firmware for NXP i.MX8 platforms Say Y if you have such a device. If unsure select "N". config SND_SOC_SOF_IMX8 - def_tristate SND_SOC_SOF_OF - depends on SND_SOC_SOF_IMX8_SUPPORT + tristate + depends on IMX_SCU + select IMX_DSP + help + This option is not user-selectable but automagically handled by + 'select' statements at a higher level endif ## SND_SOC_SOF_IMX_IMX_TOPLEVEL -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Baluta <daniel.baluta@oss.nxp.com> To: broonie@kernel.org Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, kai.vehmanen@linux.intel.com, Daniel Baluta <daniel.baluta@nxp.com>, shengjiu.wang@nxp.com, ranjani.sridharan@linux.intel.com, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, robh+dt@kernel.org, linux-imx@nxp.com, festevam@gmail.com Subject: [PATCH v2 2/5] ASoC: SOF: imx: fix undefined reference issue Date: Thu, 9 Apr 2020 10:18:29 +0300 [thread overview] Message-ID: <20200409071832.2039-3-daniel.baluta@oss.nxp.com> (raw) In-Reply-To: <20200409071832.2039-1-daniel.baluta@oss.nxp.com> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> make.cross ARCH=mips allyesconfig fails with the following error: sound/soc/sof/sof-of-dev.o:(.data.sof_of_imx8qxp_desc+0x40): undefined reference to `sof_imx8x_ops'. This seems to be a Makefile order issue, solve by using the same structure as for Intel platforms. Fixes: f9ad75468453 ("ASoC: SOF: imx: fix reverse CONFIG_SND_SOC_SOF_OF dependency") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com> --- sound/soc/sof/imx/Kconfig | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/sound/soc/sof/imx/Kconfig b/sound/soc/sof/imx/Kconfig index 812749064ca8..9586635cf8ab 100644 --- a/sound/soc/sof/imx/Kconfig +++ b/sound/soc/sof/imx/Kconfig @@ -11,17 +11,26 @@ config SND_SOC_SOF_IMX_TOPLEVEL if SND_SOC_SOF_IMX_TOPLEVEL +config SND_SOC_SOF_IMX_OF + def_tristate SND_SOC_SOF_OF + select SND_SOC_SOF_IMX8 if SND_SOC_SOF_IMX8_SUPPORT + help + This option is not user-selectable but automagically handled by + 'select' statements at a higher level + config SND_SOC_SOF_IMX8_SUPPORT bool "SOF support for i.MX8" - depends on IMX_SCU - select IMX_DSP help This adds support for Sound Open Firmware for NXP i.MX8 platforms Say Y if you have such a device. If unsure select "N". config SND_SOC_SOF_IMX8 - def_tristate SND_SOC_SOF_OF - depends on SND_SOC_SOF_IMX8_SUPPORT + tristate + depends on IMX_SCU + select IMX_DSP + help + This option is not user-selectable but automagically handled by + 'select' statements at a higher level endif ## SND_SOC_SOF_IMX_IMX_TOPLEVEL -- 2.17.1
next prev parent reply other threads:[~2020-04-09 7:19 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-09 7:18 [PATCH v2 0/5] Add support for SOF on i.MX8M Daniel Baluta 2020-04-09 7:18 ` Daniel Baluta 2020-04-09 7:18 ` [PATCH v2 1/5] ASoC: SOF: imx8: Fix randbuild error Daniel Baluta 2020-04-09 7:18 ` Daniel Baluta 2020-04-09 7:18 ` Daniel Baluta [this message] 2020-04-09 7:18 ` [PATCH v2 2/5] ASoC: SOF: imx: fix undefined reference issue Daniel Baluta 2020-04-09 7:18 ` [PATCH v2 3/5] ASoC: SOF: imx: Add i.MX8M HW support Daniel Baluta 2020-04-09 7:18 ` Daniel Baluta 2020-04-09 7:18 ` [PATCH v2 4/5] ASoC: SOF: Add i.MX8MP device descriptor Daniel Baluta 2020-04-09 7:18 ` Daniel Baluta 2020-04-09 7:18 ` [PATCH v2 5/5] dt-bindings: dsp: fsl: Add fsl,imx8mp-dsp entry Daniel Baluta 2020-04-09 7:18 ` Daniel Baluta 2020-04-15 23:36 ` [PATCH v2 0/5] Add support for SOF on i.MX8M Mark Brown 2020-04-15 23:36 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200409071832.2039-3-daniel.baluta@oss.nxp.com \ --to=daniel.baluta@oss.nxp.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=daniel.baluta@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kai.vehmanen@linux.intel.com \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=ranjani.sridharan@linux.intel.com \ --cc=robh+dt@kernel.org \ --cc=shengjiu.wang@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.