All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bodo Stroesser <bstroesser@ts.fujitsu.com>
To: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Cc: mchristi@redhat.com, martin.petersen@oracle.com,
	Bodo Stroesser <bstroesser@ts.fujitsu.com>
Subject: [PATCH] target: tcmu: reset_ring should reset TCMU_DEV_BIT_BROKEN
Date: Thu, 09 Apr 2020 10:10:26 +0000	[thread overview]
Message-ID: <20200409101026.17872-1-bstroesser@ts.fujitsu.com> (raw)

In case command ring buffer becomes inconsistent, tcmu
sets device flag TCMU_DEV_BIT_BROKEN.
If the bit is set, tcmu rejects new commands from lio core
with TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE, and no longer
processes completions from the ring.
The reset_ring attribute can be used to completely clean up
the command ring, so after reset_ring the ring no longer is
inconsistent.

Therefore reset_ring also should reset bit TCMU_DEV_BIT_BROKEN
to allow normal processing.

Signed-off-by: Bodo Stroesser <bstroesser@ts.fujitsu.com>
---
 drivers/target/target_core_user.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
index 0b9dfa6b17bc..f769bb1e3735 100644
--- a/drivers/target/target_core_user.c
+++ b/drivers/target/target_core_user.c
@@ -2073,6 +2073,7 @@ static void tcmu_reset_ring(struct tcmu_dev *udev, u8 err_level)
 	mb->cmd_tail = 0;
 	mb->cmd_head = 0;
 	tcmu_flush_dcache_range(mb, sizeof(*mb));
+	clear_bit(TCMU_DEV_BIT_BROKEN, &udev->flags);
 
 	del_timer(&udev->cmd_timer);
 
-- 
2.12.3

WARNING: multiple messages have this Message-ID (diff)
From: Bodo Stroesser <bstroesser@ts.fujitsu.com>
To: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Cc: mchristi@redhat.com, martin.petersen@oracle.com,
	Bodo Stroesser <bstroesser@ts.fujitsu.com>
Subject: [PATCH] target: tcmu: reset_ring should reset TCMU_DEV_BIT_BROKEN
Date: Thu,  9 Apr 2020 12:10:26 +0200	[thread overview]
Message-ID: <20200409101026.17872-1-bstroesser@ts.fujitsu.com> (raw)

In case command ring buffer becomes inconsistent, tcmu
sets device flag TCMU_DEV_BIT_BROKEN.
If the bit is set, tcmu rejects new commands from lio core
with TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE, and no longer
processes completions from the ring.
The reset_ring attribute can be used to completely clean up
the command ring, so after reset_ring the ring no longer is
inconsistent.

Therefore reset_ring also should reset bit TCMU_DEV_BIT_BROKEN
to allow normal processing.

Signed-off-by: Bodo Stroesser <bstroesser@ts.fujitsu.com>
---
 drivers/target/target_core_user.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
index 0b9dfa6b17bc..f769bb1e3735 100644
--- a/drivers/target/target_core_user.c
+++ b/drivers/target/target_core_user.c
@@ -2073,6 +2073,7 @@ static void tcmu_reset_ring(struct tcmu_dev *udev, u8 err_level)
 	mb->cmd_tail = 0;
 	mb->cmd_head = 0;
 	tcmu_flush_dcache_range(mb, sizeof(*mb));
+	clear_bit(TCMU_DEV_BIT_BROKEN, &udev->flags);
 
 	del_timer(&udev->cmd_timer);
 
-- 
2.12.3


             reply	other threads:[~2020-04-09 10:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-09 10:10 Bodo Stroesser [this message]
2020-04-09 10:10 ` [PATCH] target: tcmu: reset_ring should reset TCMU_DEV_BIT_BROKEN Bodo Stroesser
2020-04-09 15:29 ` Mike Christie
2020-04-09 15:29   ` Mike Christie
2020-04-13 18:03 ` Martin K. Petersen
2020-04-13 18:03   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200409101026.17872-1-bstroesser@ts.fujitsu.com \
    --to=bstroesser@ts.fujitsu.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mchristi@redhat.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.