From: bill.c.roberts@gmail.com
To: bill.c.roberts@gmail.com
Cc: nicolas.iooss@m4x.org, selinux@vger.kernel.org,
william.c.roberts@intel.com
Subject: [PATCH 1/2] libsemanage: fix linker script symbol versions
Date: Mon, 13 Apr 2020 08:02:47 -0500 [thread overview]
Message-ID: <20200413130248.25296-1-william.c.roberts@intel.com> (raw)
In-Reply-To: <CAFftDdrJcmNoU6cJ56HRGeg-R6T3bfcxU1zU5xBEmMtxnHNgfw@mail.gmail.com>
From: William Roberts <william.c.roberts@intel.com>
In previous work to cleanup the exports and linker scripts, I introduced
a regression causing symbols to be named in both the 1.0 and 1.1
sections. This went un-noticed and was reported by
nicolas.iooss@m4x.org.
Previous patches checked for correctness by:
This was checked by generating an old export map (from master):
nm --defined-only -g ./src/libsemanage.so | cut -d' ' -f 3-3 | grep -v '^_' > old.map
Then creating a new one for this library after this patch is applied:
nm --defined-only -g ./src/libsemanage.so | cut -d' ' -f 3-3 | grep -v '^_' > new.map
And diffing them:
diff old.map new.map
However, this discards the version information. Nicolas points out a
better way, by using objdump so we can see the version information. A
better sequence of commands for checking is as follows:
git checkout 1967477913f6e
objdump -T ./src/libsemanage.so | grep LIBSEMANAGE | cut -d' ' -f 8- | sed 's/^ //' > map.old
git checkout origin/master
objdump -T ./src/libsemanage.so | grep LIBSEMANAGE | cut -d' ' -f 8- | sed 's/^ //' > map.new
diff map.old map.new
Signed-off-by: William Roberts <william.c.roberts@intel.com>
---
libsemanage/src/libsemanage.map | 28 ----------------------------
1 file changed, 28 deletions(-)
diff --git a/libsemanage/src/libsemanage.map b/libsemanage/src/libsemanage.map
index ff5977b9f483..8ba2746deaa2 100644
--- a/libsemanage/src/libsemanage.map
+++ b/libsemanage/src/libsemanage.map
@@ -76,10 +76,7 @@ LIBSEMANAGE_1.0 {
semanage_fcontext_set_con;
semanage_fcontext_set_expr;
semanage_fcontext_set_type;
- semanage_get_default_priority;
semanage_get_disable_dontaudit;
- semanage_get_hll_compiler_path;
- semanage_get_ignore_module_cache;
semanage_get_preserve_tunables;
semanage_handle_create;
semanage_handle_destroy;
@@ -170,39 +167,17 @@ LIBSEMANAGE_1.0 {
semanage_mls_enabled;
semanage_module_disable;
semanage_module_enable;
- semanage_module_extract;
semanage_module_get_enabled;
- semanage_module_get_module_info;
semanage_module_get_name;
semanage_module_get_version;
- semanage_module_info_create;
semanage_module_info_datum_destroy;
- semanage_module_info_destroy;
- semanage_module_info_get_enabled;
- semanage_module_info_get_lang_ext;
- semanage_module_info_get_name;
- semanage_module_info_get_priority;
- semanage_module_info_set_enabled;
- semanage_module_info_set_lang_ext;
- semanage_module_info_set_name;
- semanage_module_info_set_priority;
semanage_module_install;
semanage_module_install_base;
semanage_module_install_base_file;
semanage_module_install_file;
- semanage_module_install_info;
- semanage_module_key_create;
- semanage_module_key_destroy;
- semanage_module_key_get_name;
- semanage_module_key_get_priority;
- semanage_module_key_set_name;
- semanage_module_key_set_priority;
semanage_module_list;
- semanage_module_list_all;
semanage_module_list_nth;
semanage_module_remove;
- semanage_module_remove_key;
- semanage_module_set_enabled;
semanage_module_upgrade;
semanage_module_upgrade_file;
semanage_msg_get_channel;
@@ -276,14 +251,11 @@ LIBSEMANAGE_1.0 {
semanage_select_store;
semanage_set_check_contexts;
semanage_set_create_store;
- semanage_set_default_priority;
semanage_set_disable_dontaudit;
- semanage_set_ignore_module_cache;
semanage_set_preserve_tunables;
semanage_set_rebuild;
semanage_set_reload;
semanage_set_root;
- semanage_set_store_root;
semanage_seuser_clone;
semanage_seuser_compare;
semanage_seuser_compare2;
--
2.17.1
next prev parent reply other threads:[~2020-04-13 13:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 16:26 Duplicate versions of libsemanage symbols Nicolas Iooss
2020-04-12 16:45 ` William Roberts
2020-04-12 17:07 ` [PATCH] libsemanage: fix linker script symbol versions bill.c.roberts
2020-04-12 17:42 ` William Roberts
2020-04-12 18:47 ` Nicolas Iooss
2020-04-13 12:49 ` William Roberts
2020-04-13 13:02 ` bill.c.roberts [this message]
2020-04-13 13:04 ` [PATCH 1/2] " William Roberts
2020-04-13 13:03 ` [PATCH v2 " bill.c.roberts
2020-04-13 13:03 ` [PATCH v2 2/2] libsemanage: rm semanage_module_upgrade_info from map bill.c.roberts
2020-04-13 17:12 ` [PATCH v2 1/2] libsemanage: fix linker script symbol versions Nicolas Iooss
2020-04-13 17:39 ` William Roberts
2020-04-15 15:29 ` William Roberts
2020-04-12 17:35 ` Duplicate versions of libsemanage symbols William Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413130248.25296-1-william.c.roberts@intel.com \
--to=bill.c.roberts@gmail.com \
--cc=nicolas.iooss@m4x.org \
--cc=selinux@vger.kernel.org \
--cc=william.c.roberts@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.