From: Lev Olshvang <levonshe@gmail.com>
To: keescook@chromium.orh
Cc: kernel-hardening@lists.openwall.com, Lev Olshvang <levonshe@gmail.com>
Subject: [PATCH v3 1/5] Hardening x86: Forbid writes to read-only memory pages of a process
Date: Mon, 13 Apr 2020 18:32:07 +0300 [thread overview]
Message-ID: <20200413153211.29876-2-levonshe@gmail.com> (raw)
In-Reply-To: <20200413153211.29876-1-levonshe@gmail.com>
Signed-off-by: Lev Olshvang <levonshe@gmail.com>
---
arch/x86/include/asm/mmu_context.h | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/arch/x86/include/asm/mmu_context.h b/arch/x86/include/asm/mmu_context.h
index 701a7367babf..4e55370e48e8 100644
--- a/arch/x86/include/asm/mmu_context.h
+++ b/arch/x86/include/asm/mmu_context.h
@@ -5,7 +5,6 @@
#include <asm/desc.h>
#include <linux/atomic.h>
#include <linux/mm_types.h>
-#include <linux/printk.h>
#include <linux/pkeys.h>
#include <trace/events/tlb.h>
@@ -217,12 +216,7 @@ static inline void arch_unmap(struct mm_struct *mm, unsigned long start,
static inline bool arch_vma_access_permitted(struct vm_area_struct *vma,
bool write, bool execute, bool foreign)
{
- if (unlikely(!vma_write_allowed(vma, write, execute, foreign))) {
- pr_err_once("Error : PID[%d] %s writes to read only memory\n",
- current->tgid, current->comm);
- return false;
- }
- /* Don't check PKRU since pkeys never affect instruction fetches */
+ /* pkeys never affect instruction fetches */
if (execute)
return true;
/* allow access if the VMA is not one from this process */
--
2.17.1
next prev parent reply other threads:[~2020-04-13 15:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 15:32 [PATCH v3 0/5] hardening : prevent write to proces's read-only pages Lev Olshvang
2020-04-13 15:32 ` Lev Olshvang [this message]
2020-04-13 15:32 ` [PATCH v3 2/5] Hardening PowerPC: Forbid writes to read-only memory pages of a process Lev Olshvang
2020-04-13 15:32 ` [PATCH v3 3/5] Hardening um: " Lev Olshvang
2020-04-13 15:32 ` [PATCH v3 4/5] Hardening unicore32: " Lev Olshvang
2020-04-13 15:32 ` [PATCH v3 5/5] Hardening : PPC book3s64: " Lev Olshvang
2020-04-13 17:13 ` [PATCH v3 0/5] hardening : prevent write to proces's read-only pages Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413153211.29876-2-levonshe@gmail.com \
--to=levonshe@gmail.com \
--cc=keescook@chromium.orh \
--cc=kernel-hardening@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.