From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org,
"J. Bruce Fields" <bfields@fieldses.org>,
Chuck Lever <chuck.lever@oracle.com>,
linux-nfs@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>,
linux-nvdimm@lists.01.org, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, Zzy Wysm <zzy@zzywysm.com>
Subject: [PATCH 2/9] fs: fix empty-body warning in posix_acl.c
Date: Sat, 18 Apr 2020 11:41:04 -0700 [thread overview]
Message-ID: <20200418184111.13401-3-rdunlap@infradead.org> (raw)
In-Reply-To: <20200418184111.13401-1-rdunlap@infradead.org>
Fix gcc empty-body warning when -Wextra is used:
../fs/posix_acl.c: In function ‘get_acl’:
../fs/posix_acl.c:127:22: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
/* fall through */ ;
^
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
fs/posix_acl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20200327.orig/fs/posix_acl.c
+++ linux-next-20200327/fs/posix_acl.c
@@ -124,7 +124,7 @@ struct posix_acl *get_acl(struct inode *
* be an unlikely race.)
*/
if (cmpxchg(p, ACL_NOT_CACHED, sentinel) != ACL_NOT_CACHED)
- /* fall through */ ;
+ do_empty(); /* fall through */
/*
* Normally, the ACL returned by ->get_acl will be cached.
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org,
"J. Bruce Fields" <bfields@fieldses.org>,
Chuck Lever <chuck.lever@oracle.com>,
linux-nfs@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>,
Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
linux-nvdimm@lists.01.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
Zzy Wysm <zzy@zzywysm.com>
Subject: [PATCH 2/9] fs: fix empty-body warning in posix_acl.c
Date: Sat, 18 Apr 2020 11:41:04 -0700 [thread overview]
Message-ID: <20200418184111.13401-3-rdunlap@infradead.org> (raw)
In-Reply-To: <20200418184111.13401-1-rdunlap@infradead.org>
Fix gcc empty-body warning when -Wextra is used:
../fs/posix_acl.c: In function ‘get_acl’:
../fs/posix_acl.c:127:22: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
/* fall through */ ;
^
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
fs/posix_acl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20200327.orig/fs/posix_acl.c
+++ linux-next-20200327/fs/posix_acl.c
@@ -124,7 +124,7 @@ struct posix_acl *get_acl(struct inode *
* be an unlikely race.)
*/
if (cmpxchg(p, ACL_NOT_CACHED, sentinel) != ACL_NOT_CACHED)
- /* fall through */ ;
+ do_empty(); /* fall through */
/*
* Normally, the ACL returned by ->get_acl will be cached.
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: alsa-devel@alsa-project.org, Randy Dunlap <rdunlap@infradead.org>,
Zzy Wysm <zzy@zzywysm.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
target-devel@vger.kernel.org, Dave Jiang <dave.jiang@intel.com>,
linux-scsi@vger.kernel.org, linux-nvdimm@lists.01.org,
Vishal Verma <vishal.l.verma@intel.com>,
Chuck Lever <chuck.lever@oracle.com>,
linux-input@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Dan Williams <dan.j.williams@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-nfs@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Takashi Iwai <tiwai@suse.com>,
linux-usb@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCH 2/9] fs: fix empty-body warning in posix_acl.c
Date: Sat, 18 Apr 2020 18:41:04 +0000 [thread overview]
Message-ID: <20200418184111.13401-3-rdunlap@infradead.org> (raw)
In-Reply-To: <20200418184111.13401-1-rdunlap@infradead.org>
Fix gcc empty-body warning when -Wextra is used:
../fs/posix_acl.c: In function ‘get_acl’:
../fs/posix_acl.c:127:22: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
/* fall through */ ;
^
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
fs/posix_acl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20200327.orig/fs/posix_acl.c
+++ linux-next-20200327/fs/posix_acl.c
@@ -124,7 +124,7 @@ struct posix_acl *get_acl(struct inode *
* be an unlikely race.)
*/
if (cmpxchg(p, ACL_NOT_CACHED, sentinel) != ACL_NOT_CACHED)
- /* fall through */ ;
+ do_empty(); /* fall through */
/*
* Normally, the ACL returned by ->get_acl will be cached.
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: alsa-devel@alsa-project.org, Randy Dunlap <rdunlap@infradead.org>,
Zzy Wysm <zzy@zzywysm.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
target-devel@vger.kernel.org, Dave Jiang <dave.jiang@intel.com>,
linux-scsi@vger.kernel.org, linux-nvdimm@lists.01.org,
Vishal Verma <vishal.l.verma@intel.com>,
Chuck Lever <chuck.lever@oracle.com>,
linux-input@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Dan Williams <dan.j.williams@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-nfs@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Takashi Iwai <tiwai@suse.com>,
linux-usb@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCH 2/9] fs: fix empty-body warning in posix_acl.c
Date: Sat, 18 Apr 2020 11:41:04 -0700 [thread overview]
Message-ID: <20200418184111.13401-3-rdunlap@infradead.org> (raw)
In-Reply-To: <20200418184111.13401-1-rdunlap@infradead.org>
Fix gcc empty-body warning when -Wextra is used:
../fs/posix_acl.c: In function ‘get_acl’:
../fs/posix_acl.c:127:22: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
/* fall through */ ;
^
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
fs/posix_acl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20200327.orig/fs/posix_acl.c
+++ linux-next-20200327/fs/posix_acl.c
@@ -124,7 +124,7 @@ struct posix_acl *get_acl(struct inode *
* be an unlikely race.)
*/
if (cmpxchg(p, ACL_NOT_CACHED, sentinel) != ACL_NOT_CACHED)
- /* fall through */ ;
+ do_empty(); /* fall through */
/*
* Normally, the ACL returned by ->get_acl will be cached.
next prev parent reply other threads:[~2020-04-18 18:41 UTC|newest]
Thread overview: 156+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 18:41 [RFC PATCH 0/9] fix -Wempty-body build warnings Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:41 ` [RFC PATCH 1/9] kernel.h: add do_empty() macro Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:44 ` Joe Perches
2020-04-18 18:44 ` Joe Perches
2020-04-18 18:44 ` Joe Perches
2020-04-18 18:44 ` Joe Perches
2020-04-18 18:49 ` Randy Dunlap
2020-04-18 18:49 ` Randy Dunlap
2020-04-18 18:49 ` Randy Dunlap
2020-04-18 18:49 ` Randy Dunlap
2020-04-18 22:20 ` Bart Van Assche
2020-04-18 22:20 ` Bart Van Assche
2020-04-18 22:20 ` Bart Van Assche
2020-04-18 22:20 ` Bart Van Assche
2020-04-18 22:24 ` Randy Dunlap
2020-04-18 22:24 ` Randy Dunlap
2020-04-18 22:24 ` Randy Dunlap
2020-04-18 22:24 ` Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap [this message]
2020-04-18 18:41 ` [PATCH 2/9] fs: fix empty-body warning in posix_acl.c Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:53 ` Linus Torvalds
2020-04-18 18:53 ` Linus Torvalds
2020-04-18 18:53 ` Linus Torvalds
2020-04-18 18:53 ` Linus Torvalds
2020-04-18 18:55 ` Randy Dunlap
2020-04-18 18:55 ` Randy Dunlap
2020-04-18 18:55 ` Randy Dunlap
2020-04-18 18:55 ` Randy Dunlap
2020-04-20 19:58 ` [PATCH 2/9] " Zzy Wysm
2020-04-20 19:58 ` Zzy Wysm
2020-04-20 19:58 ` Zzy Wysm
2020-04-20 19:58 ` Zzy Wysm
2020-04-18 18:41 ` [PATCH 3/9] input: fix empty-body warning in synaptics.c Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:41 ` [PATCH 4/9] sound: fix empty-body warning in vx_core.c Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:41 ` [PATCH 5/9] usb: fix empty-body warning in sysfs.c Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:44 ` Matthew Wilcox
2020-04-18 18:44 ` Matthew Wilcox
2020-04-18 18:44 ` Matthew Wilcox
2020-04-18 18:44 ` Matthew Wilcox
2020-04-18 18:46 ` Randy Dunlap
2020-04-18 18:46 ` Randy Dunlap
2020-04-18 18:46 ` Randy Dunlap
2020-04-18 18:46 ` Randy Dunlap
2020-04-18 19:54 ` Alan Stern
2020-04-18 19:54 ` Alan Stern
2020-04-18 19:54 ` Alan Stern
2020-04-18 19:54 ` Alan Stern
2020-04-21 1:20 ` NeilBrown
2020-04-21 1:20 ` NeilBrown
2020-04-21 1:20 ` NeilBrown
2020-04-21 1:20 ` NeilBrown
2020-04-21 13:58 ` Alan Stern
2020-04-21 13:58 ` Alan Stern
2020-04-21 13:58 ` Alan Stern
2020-04-21 13:58 ` Alan Stern
2020-04-18 18:41 ` [PATCH 6/9] nfsd: fix empty-body warning in nfs4state.c Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:45 ` Chuck Lever
2020-04-18 18:45 ` Chuck Lever
2020-04-18 18:45 ` Chuck Lever
2020-04-18 18:45 ` Chuck Lever
2020-04-18 18:53 ` Joe Perches
2020-04-18 18:53 ` Joe Perches
2020-04-18 18:53 ` Joe Perches
2020-04-18 18:53 ` Joe Perches
2020-04-18 18:57 ` Randy Dunlap
2020-04-18 18:57 ` Randy Dunlap
2020-04-18 18:57 ` Randy Dunlap
2020-04-18 18:57 ` Randy Dunlap
2020-04-18 22:28 ` Trond Myklebust
2020-04-18 22:28 ` Trond Myklebust
2020-04-18 22:28 ` Trond Myklebust
2020-04-18 22:28 ` Trond Myklebust
2020-04-18 22:32 ` Randy Dunlap
2020-04-18 22:32 ` Randy Dunlap
2020-04-18 22:32 ` Randy Dunlap
2020-04-18 22:32 ` Randy Dunlap
2020-04-18 22:33 ` Chuck Lever
2020-04-18 22:33 ` Chuck Lever
2020-04-18 22:33 ` Chuck Lever
2020-04-18 22:33 ` Chuck Lever
2020-04-19 9:32 ` Sergei Shtylyov
2020-04-19 9:32 ` Sergei Shtylyov
2020-04-19 9:32 ` Sergei Shtylyov
2020-04-19 9:32 ` Sergei Shtylyov
2020-04-18 18:41 ` [PATCH 7/9] drivers/base: fix empty-body warnings in devcoredump.c Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:50 ` Matthew Wilcox
2020-04-18 18:50 ` Matthew Wilcox
2020-04-18 18:50 ` Matthew Wilcox
2020-04-18 18:50 ` Matthew Wilcox
2020-04-18 18:53 ` Randy Dunlap
2020-04-18 18:53 ` Randy Dunlap
2020-04-18 18:53 ` Randy Dunlap
2020-04-18 18:53 ` Randy Dunlap
2020-04-18 18:55 ` Joe Perches
2020-04-18 18:55 ` Joe Perches
2020-04-18 18:55 ` Joe Perches
2020-04-18 18:55 ` Joe Perches
2020-04-18 19:13 ` Matthew Wilcox
2020-04-18 19:13 ` Matthew Wilcox
2020-04-18 19:13 ` Matthew Wilcox
2020-04-18 19:13 ` Matthew Wilcox
2020-04-18 19:16 ` Johannes Berg
2020-04-18 19:16 ` Johannes Berg
2020-04-18 19:16 ` Johannes Berg
2020-04-18 19:16 ` Johannes Berg
2020-04-18 19:15 ` Linus Torvalds
2020-04-18 19:15 ` Linus Torvalds
2020-04-18 19:15 ` Linus Torvalds
2020-04-18 19:15 ` Linus Torvalds
2020-04-19 12:03 ` Greg Kroah-Hartman
2020-04-19 12:03 ` Greg Kroah-Hartman
2020-04-19 12:03 ` Greg Kroah-Hartman
2020-04-19 12:03 ` Greg Kroah-Hartman
2020-04-19 6:02 ` Greg Kroah-Hartman
2020-04-19 6:02 ` Greg Kroah-Hartman
2020-04-19 6:02 ` Greg Kroah-Hartman
2020-04-19 6:02 ` Greg Kroah-Hartman
2020-04-19 6:04 ` Greg Kroah-Hartman
2020-04-19 6:04 ` Greg Kroah-Hartman
2020-04-19 6:04 ` Greg Kroah-Hartman
2020-04-19 6:04 ` Greg Kroah-Hartman
2020-04-18 18:41 ` [PATCH 8/9] dax: fix empty-body warnings in bus.c Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-19 8:15 ` Christoph Hellwig
2020-04-19 8:15 ` Christoph Hellwig
2020-04-19 8:15 ` Christoph Hellwig
2020-04-19 8:15 ` Christoph Hellwig
2020-04-18 18:41 ` [PATCH 9/9] target: fix empty-body warning in target_core_pscsi.c Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
2020-04-18 18:41 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200418184111.13401-3-rdunlap@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johannes@sipsolutions.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=perex@perex.cz \
--cc=target-devel@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=zzy@zzywysm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.