From: Dan Carpenter <dan.carpenter@oracle.com> To: Faisal Latif <faisal.latif@intel.com> Cc: Shiraz Saleem <shiraz.saleem@intel.com>, Doug Ledford <dledford@redhat.com>, Jason Gunthorpe <jgg@ziepe.ca>, Shannon Nelson <shannon.nelson@intel.com>, Anjali Singhai Jain <anjali.singhai@intel.com>, linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] i40iw: Fix error handling in i40iw_manage_arp_cache() Date: Wed, 22 Apr 2020 12:22:11 +0300 [thread overview] Message-ID: <20200422092211.GA195357@mwanda> (raw) The i40iw_arp_table() function can return -EOVERFLOW if i40iw_alloc_resource() fails so we can't just test for "== -1". Fixes: 4e9042e647ff ("i40iw: add hw and utils files") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/infiniband/hw/i40iw/i40iw_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/i40iw/i40iw_hw.c b/drivers/infiniband/hw/i40iw/i40iw_hw.c index 55a1fbf0e670..ae8b97c30665 100644 --- a/drivers/infiniband/hw/i40iw/i40iw_hw.c +++ b/drivers/infiniband/hw/i40iw/i40iw_hw.c @@ -534,7 +534,7 @@ void i40iw_manage_arp_cache(struct i40iw_device *iwdev, int arp_index; arp_index = i40iw_arp_table(iwdev, ip_addr, ipv4, mac_addr, action); - if (arp_index == -1) + if (arp_index < 0) return; cqp_request = i40iw_get_cqp_request(&iwdev->cqp, false); if (!cqp_request) -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com> To: Faisal Latif <faisal.latif@intel.com> Cc: Shiraz Saleem <shiraz.saleem@intel.com>, Doug Ledford <dledford@redhat.com>, Jason Gunthorpe <jgg@ziepe.ca>, Shannon Nelson <shannon.nelson@intel.com>, Anjali Singhai Jain <anjali.singhai@intel.com>, linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] i40iw: Fix error handling in i40iw_manage_arp_cache() Date: Wed, 22 Apr 2020 09:22:11 +0000 [thread overview] Message-ID: <20200422092211.GA195357@mwanda> (raw) The i40iw_arp_table() function can return -EOVERFLOW if i40iw_alloc_resource() fails so we can't just test for "= -1". Fixes: 4e9042e647ff ("i40iw: add hw and utils files") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/infiniband/hw/i40iw/i40iw_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/i40iw/i40iw_hw.c b/drivers/infiniband/hw/i40iw/i40iw_hw.c index 55a1fbf0e670..ae8b97c30665 100644 --- a/drivers/infiniband/hw/i40iw/i40iw_hw.c +++ b/drivers/infiniband/hw/i40iw/i40iw_hw.c @@ -534,7 +534,7 @@ void i40iw_manage_arp_cache(struct i40iw_device *iwdev, int arp_index; arp_index = i40iw_arp_table(iwdev, ip_addr, ipv4, mac_addr, action); - if (arp_index = -1) + if (arp_index < 0) return; cqp_request = i40iw_get_cqp_request(&iwdev->cqp, false); if (!cqp_request) -- 2.25.1
next reply other threads:[~2020-04-22 9:24 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-22 9:22 Dan Carpenter [this message] 2020-04-22 9:22 ` [PATCH] i40iw: Fix error handling in i40iw_manage_arp_cache() Dan Carpenter 2020-04-25 23:00 ` Jason Gunthorpe 2020-04-25 23:00 ` Jason Gunthorpe 2020-04-27 17:54 ` Saleem, Shiraz 2020-04-27 17:54 ` Saleem, Shiraz 2020-05-04 17:13 ` Jason Gunthorpe 2020-05-04 17:13 ` Jason Gunthorpe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200422092211.GA195357@mwanda \ --to=dan.carpenter@oracle.com \ --cc=anjali.singhai@intel.com \ --cc=dledford@redhat.com \ --cc=faisal.latif@intel.com \ --cc=jgg@ziepe.ca \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-rdma@vger.kernel.org \ --cc=shannon.nelson@intel.com \ --cc=shiraz.saleem@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.