From: Hou Pu <houpu@bytedance.com> To: martin.petersen@oracle.com, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Cc: mchristi@redhat.com, Hou Pu <houpu@bytedance.com> Subject: [PATCH v3 2/2] iscsi-target: Fix inconsistent debug message in __iscsi_target_sk_check_close Date: Fri, 24 Apr 2020 12:35:28 +0000 [thread overview] Message-ID: <20200424123528.17627-3-houpu@bytedance.com> (raw) In-Reply-To: <20200424123528.17627-1-houpu@bytedance.com> The commit 25cdda95fda7 ("iscsi-target: Fix initial login PDU asynchronous socket close OOPs") changed the return value of __iscsi_target_sk_check_close. But the pr_debug is still printing FALSE when returning TRUE which is a little confusing. Signed-off-by: Hou Pu <houpu@bytedance.com> --- drivers/target/iscsi/iscsi_target_nego.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c index 4cfa742e61df..7c36368e617d 100644 --- a/drivers/target/iscsi/iscsi_target_nego.c +++ b/drivers/target/iscsi/iscsi_target_nego.c @@ -481,7 +481,7 @@ static bool __iscsi_target_sk_check_close(struct sock *sk) { if (sk->sk_state = TCP_CLOSE_WAIT || sk->sk_state = TCP_CLOSE) { pr_debug("__iscsi_target_sk_check_close: TCP_CLOSE_WAIT|TCP_CLOSE," - "returning FALSE\n"); + "returning TRUE\n"); return true; } return false; -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: Hou Pu <houpu@bytedance.com> To: martin.petersen@oracle.com, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Cc: mchristi@redhat.com, Hou Pu <houpu@bytedance.com> Subject: [PATCH v3 2/2] iscsi-target: Fix inconsistent debug message in __iscsi_target_sk_check_close Date: Fri, 24 Apr 2020 08:35:28 -0400 [thread overview] Message-ID: <20200424123528.17627-3-houpu@bytedance.com> (raw) In-Reply-To: <20200424123528.17627-1-houpu@bytedance.com> The commit 25cdda95fda7 ("iscsi-target: Fix initial login PDU asynchronous socket close OOPs") changed the return value of __iscsi_target_sk_check_close. But the pr_debug is still printing FALSE when returning TRUE which is a little confusing. Signed-off-by: Hou Pu <houpu@bytedance.com> --- drivers/target/iscsi/iscsi_target_nego.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c index 4cfa742e61df..7c36368e617d 100644 --- a/drivers/target/iscsi/iscsi_target_nego.c +++ b/drivers/target/iscsi/iscsi_target_nego.c @@ -481,7 +481,7 @@ static bool __iscsi_target_sk_check_close(struct sock *sk) { if (sk->sk_state == TCP_CLOSE_WAIT || sk->sk_state == TCP_CLOSE) { pr_debug("__iscsi_target_sk_check_close: TCP_CLOSE_WAIT|TCP_CLOSE," - "returning FALSE\n"); + "returning TRUE\n"); return true; } return false; -- 2.11.0
next prev parent reply other threads:[~2020-04-24 12:35 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-24 12:35 [PATCH v3 0/2] iscsi-target: fix login error when receiving is too fast Hou Pu 2020-04-24 12:35 ` Hou Pu 2020-04-24 12:35 ` [PATCH v3 1/2] " Hou Pu 2020-04-24 12:35 ` Hou Pu 2020-04-24 17:01 ` Mike Christie 2020-04-24 17:01 ` Mike Christie 2020-04-25 17:45 ` Mike Christie 2020-04-25 17:45 ` Mike Christie 2020-04-26 5:49 ` [External] " Hou Pu 2020-04-26 5:49 ` Hou Pu 2020-04-26 6:09 ` Hou Pu 2020-04-26 6:09 ` Hou Pu 2020-04-28 17:50 ` Mike Christie 2020-04-28 17:50 ` Mike Christie 2020-04-29 6:59 ` Hou Pu 2020-04-29 6:59 ` Hou Pu 2020-04-24 12:35 ` Hou Pu [this message] 2020-04-24 12:35 ` [PATCH v3 2/2] iscsi-target: Fix inconsistent debug message in __iscsi_target_sk_check_close Hou Pu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200424123528.17627-3-houpu@bytedance.com \ --to=houpu@bytedance.com \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=mchristi@redhat.com \ --cc=target-devel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.