All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: dri-devel@lists.freedesktop.org,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Neil Armstrong <narmstrong@baylibre.com>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
	Martyn Welch <martyn.welch@collabora.co.uk>,
	Jonas Karlman <jonas@kwiboo.se>,
	Peter Senna Tschudin <peter.senna@gmail.com>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Martin Donnelly <martin.donnelly@ge.com>
Subject: [PATCH v2 02/21] drm/panel: panel-simple: add default connector_type
Date: Mon, 27 Apr 2020 10:18:31 +0200	[thread overview]
Message-ID: <20200427081850.17512-3-sam@ravnborg.org> (raw)
In-Reply-To: <20200427081850.17512-1-sam@ravnborg.org>

All panels shall report a connector type.
panel-simple has a lot of panels with no connector_type,
and for these fall back to DPI as the default.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/panel/panel-simple.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 80388706057e..13c25ee38dbf 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -451,6 +451,7 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc)
 	struct panel_simple *panel;
 	struct display_timing dt;
 	struct device_node *ddc;
+	int connector_type;
 	int err;
 
 	panel = devm_kzalloc(dev, sizeof(*panel), GFP_KERNEL);
@@ -495,8 +496,13 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc)
 			panel_simple_parse_panel_timing_node(dev, panel, &dt);
 	}
 
-	drm_panel_init(&panel->base, dev, &panel_simple_funcs,
-		       desc->connector_type);
+	/* Default DRM_MODE_CONNECTOR_DPI if no connector_type is set */
+	if (desc->connector_type != 0)
+		connector_type = desc->connector_type;
+	else
+		connector_type = DRM_MODE_CONNECTOR_DPI;
+
+	drm_panel_init(&panel->base, dev, &panel_simple_funcs, connector_type);
 
 	err = drm_panel_of_backlight(&panel->base);
 	if (err)
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-04-27  8:19 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27  8:18 [PATCH v2 0/21] drm/bridge: support drm bridge connector helper + panel updates Sam Ravnborg
2020-04-27  8:18 ` [PATCH v2 01/21] drm/panel: add connector type to boe, hv070wsa-100 panel Sam Ravnborg
2020-04-27  8:18 ` Sam Ravnborg [this message]
2020-04-27  8:18 ` [PATCH v2 03/21] drm/bridge: tc358764: drop drm_connector_(un)register Sam Ravnborg
2020-04-27  8:18 ` [PATCH v2 04/21] drm/bridge: tc358764: add drm_panel_bridge support Sam Ravnborg
2020-04-29  3:08   ` kbuild test robot
2020-04-29  3:08     ` kbuild test robot
2020-04-29  3:08   ` [PATCH] drm/bridge: tc358764: fix ptr_ret.cocci warnings kbuild test robot
2020-04-29  3:08     ` kbuild test robot
2020-04-27  8:18 ` [PATCH v2 05/21] drm/bridge: tc358764: make connector creation optional Sam Ravnborg
2020-04-27  8:18 ` [PATCH v2 06/21] drm/bridge: tc358767: add drm_panel_bridge support Sam Ravnborg
2020-04-27  8:18 ` [PATCH v2 07/21] drm/bridge: tc358767: add detect bridge operation Sam Ravnborg
2020-04-27  8:18 ` [PATCH v2 08/21] drm/bridge: tc358767: add get_edid bride operation Sam Ravnborg
2020-04-27  8:18 ` [PATCH v2 09/21] drm/bridge: tc358767: make connector creation optional Sam Ravnborg
2020-04-27  8:18 ` [PATCH v2 10/21] drm/bridge: ti-tpd12s015: " Sam Ravnborg
2020-04-27  8:18 ` [PATCH v2 11/21] drm/bridge: parade-ps8622: add drm_panel_bridge support Sam Ravnborg
2020-04-27  8:18 ` [PATCH v2 12/21] drm/bridge: parade-ps8622: make connector creation optional Sam Ravnborg
2020-04-27  8:18 ` [PATCH v2 13/21] drm/bridge: megachips: add helper to create connector Sam Ravnborg
2020-04-27  8:18 ` [PATCH v2 14/21] drm/bridge: megachips: get drm_device from bridge Sam Ravnborg
2020-04-27  8:18 ` [PATCH v2 15/21] drm/bridge: megachips: enable detect bridge operation Sam Ravnborg
2020-04-27  8:18 ` [PATCH v2 16/21] drm/bridge: megachips: add get_edid " Sam Ravnborg
2020-04-27  8:18 ` [PATCH v2 17/21] drm/bridge: megachips: make connector creation optional Sam Ravnborg
2020-04-27  8:18 ` [PATCH v2 18/21] drm/bridge: nxp-ptn3460: add drm_panel_bridge support Sam Ravnborg
2020-04-27  8:18 ` [PATCH v2 19/21] drm/bridge: nxp-ptn3460: add get_modes bridge operation Sam Ravnborg
2020-04-27  8:18 ` [PATCH v2 20/21] drm/bridge: nxp-ptn3460: make connector creation optional Sam Ravnborg
2020-04-27  8:18 ` [PATCH v2 21/21] drm/bridge: ti-sn65dsi86: add drm_panel_bridge support Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200427081850.17512-3-sam@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=a.hajda@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@siol.net \
    --cc=jonas@kwiboo.se \
    --cc=martin.donnelly@ge.com \
    --cc=martyn.welch@collabora.co.uk \
    --cc=narmstrong@baylibre.com \
    --cc=peter.senna@gmail.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.