From: Tero Kristo <t-kristo@ti.com>
To: <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
<linux-crypto@vger.kernel.org>
Cc: <linux-omap@vger.kernel.org>
Subject: [PATCH 1/6] crypto: omap-aes: avoid spamming console with self tests
Date: Wed, 29 Apr 2020 17:42:00 +0300 [thread overview]
Message-ID: <20200429144205.5291-2-t-kristo@ti.com> (raw)
In-Reply-To: <20200429144205.5291-1-t-kristo@ti.com>
Running the self test suite for omap-aes with extra tests enabled causes
huge spam with the tag message wrong indicators. With self tests, this
is fine as there are some tests that purposedly pass bad data to the
driver. Also, returning -EBADMSG from the driver is enough, so remove the
dev_err message completely.
Signed-off-by: Tero Kristo <t-kristo@ti.com>
---
drivers/crypto/omap-aes-gcm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/crypto/omap-aes-gcm.c b/drivers/crypto/omap-aes-gcm.c
index 32dc00dc570b..9f937bdc53a7 100644
--- a/drivers/crypto/omap-aes-gcm.c
+++ b/drivers/crypto/omap-aes-gcm.c
@@ -77,7 +77,6 @@ static void omap_aes_gcm_done_task(struct omap_aes_dev *dd)
tag = (u8 *)rctx->auth_tag;
for (i = 0; i < dd->authsize; i++) {
if (tag[i]) {
- dev_err(dd->dev, "GCM decryption: Tag Message is wrong\n");
ret = -EBADMSG;
}
}
--
2.17.1
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-04-29 14:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 14:41 crypto: omap: sha/aes fixes Tero Kristo
2020-04-29 14:42 ` Tero Kristo [this message]
2020-04-29 14:42 ` [PATCH 2/6] crypto: omap-sham: force kernel driver usage for sha algos Tero Kristo
2020-04-29 14:42 ` [PATCH 3/6] crypto: omap-crypto: fix userspace copied buffer access Tero Kristo
2020-05-08 5:08 ` Herbert Xu
2020-05-08 5:47 ` Tero Kristo
2020-04-29 14:42 ` [PATCH 4/6] crypto: omap-sham: huge buffer access fixes Tero Kristo
2020-04-29 14:42 ` [PATCH 5/6] crypto: omap-sham: fix very small data size handling Tero Kristo
2020-04-29 14:42 ` [PATCH 6/6] crypto: omap-aes: prevent unregistering algorithms twice Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429144205.5291-2-t-kristo@ti.com \
--to=t-kristo@ti.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.