All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: kvm@vger.kernel.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	linux-s390@vger.kernel.org, Cornelia Huck <cohuck@redhat.com>,
	David Hildenbrand <david@redhat.com>
Subject: [kvm-unit-tests PULL 13/17] s390x: smp: Loop if secondary cpu returns into cpu setup again
Date: Thu, 30 Apr 2020 17:24:26 +0200	[thread overview]
Message-ID: <20200430152430.40349-14-david@redhat.com> (raw)
In-Reply-To: <20200430152430.40349-1-david@redhat.com>

From: Janosch Frank <frankja@linux.ibm.com>

Up to now a secondary cpu could have returned from the function it was
executing and ending up somewhere in cstart64.S. This was mostly
circumvented by an endless loop in the function that it executed.

Let's add a loop to the end of the cpu setup, so we don't have to rely
on added loops in the tests.

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Message-Id: <20200429143518.1360468-6-frankja@linux.ibm.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
 s390x/cstart64.S | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/s390x/cstart64.S b/s390x/cstart64.S
index 9af6bb3..ecffbe0 100644
--- a/s390x/cstart64.S
+++ b/s390x/cstart64.S
@@ -161,7 +161,9 @@ smp_cpu_setup_state:
 	lctlg   %c0, %c0, GEN_LC_SW_INT_CRS
 	/* We should only go once through cpu setup and not for every restart */
 	stg	%r14, GEN_LC_RESTART_NEW_PSW + 8
-	br	%r14
+	brasl	%r14, %r14
+	/* If the function returns, just loop here */
+0:	j	0
 
 pgm_int:
 	SAVE_REGS
-- 
2.25.3

  parent reply	other threads:[~2020-04-30 15:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30 15:24 [kvm-unit-tests PULL 00/17] s390x updates David Hildenbrand
2020-04-30 15:24 ` [kvm-unit-tests PULL 01/17] MAINTAINERS: Add Janosch as a s390x maintainer David Hildenbrand
2020-04-30 15:24 ` [kvm-unit-tests PULL 02/17] MAINTAINERS: s390x: add myself as reviewer David Hildenbrand
2020-04-30 15:24 ` [kvm-unit-tests PULL 03/17] MAINTAINERS: s390x: add linux-s390 list David Hildenbrand
2020-04-30 15:24 ` [kvm-unit-tests PULL 04/17] s390x: Add stsi 3.2.2 tests David Hildenbrand
2020-04-30 15:24 ` [kvm-unit-tests PULL 05/17] s390x/smp: fix detection of "running" David Hildenbrand
2020-04-30 15:24 ` [kvm-unit-tests PULL 06/17] s390x: STFLE operates on doublewords David Hildenbrand
2020-04-30 15:24 ` [kvm-unit-tests PULL 07/17] s390x/smp: add minimal test for sigp sense running status David Hildenbrand
2020-04-30 15:24 ` [kvm-unit-tests PULL 08/17] s390x: unittests: Use smp parameter David Hildenbrand
2020-04-30 15:24 ` [kvm-unit-tests PULL 09/17] s390x: smp: Test all CRs on initial reset David Hildenbrand
2020-04-30 15:24 ` [kvm-unit-tests PULL 10/17] s390x: smp: Dirty fpc before initial reset test David Hildenbrand
2020-04-30 15:24 ` [kvm-unit-tests PULL 11/17] s390x: smp: Test stop and store status on a running and stopped cpu David Hildenbrand
2020-04-30 15:24 ` [kvm-unit-tests PULL 12/17] s390x: smp: Test local interrupts after cpu reset David Hildenbrand
2020-04-30 15:24 ` David Hildenbrand [this message]
2020-04-30 15:24 ` [kvm-unit-tests PULL 14/17] s390x: smp: Remove unneeded cpu loops David Hildenbrand
2020-04-30 15:24 ` [kvm-unit-tests PULL 15/17] s390x: smp: Use full PSW to bringup new cpu David Hildenbrand
2020-04-30 15:24 ` [kvm-unit-tests PULL 16/17] s390x: smp: Add restart when running test David Hildenbrand
2020-04-30 15:24 ` [kvm-unit-tests PULL 17/17] s390x: Fix library constant definitions David Hildenbrand
2020-05-04 16:44 ` [kvm-unit-tests PULL 00/17] s390x updates Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200430152430.40349-14-david@redhat.com \
    --to=david@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.